mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-07-25 23:17:08 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
node-runtime-fix
pnpm/installing/deps-installer/test/install/bunRuntime.ts
Zoltan Kochan 187049055f chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2 (#11332) 
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2

- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
  20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
  `it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
  instead of relying on `@types/jest` ambient declarations. Under the
  new tsgo build, `import { jest } from '@jest/globals'` shadows the
  ambient `jest` namespace, breaking `@types/jest`'s `declare var
  describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
  now import from it, and add `@types/node` to packages that need it
  but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
  no longer globally available.

* chore: fix remaining tsgo type-strictness errors

- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
  toStrictEqual / toEqual; @jest/globals rejects the typed objects
  (which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
  for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
  return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
  expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
  for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
  that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
  two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.

* chore: address Copilot review on #11332

- Move misplaced `@jest/globals` imports to the top import block in
  checkEngine, run.ts, and workspace/root-finder tests where the
  script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
  in bins/linker, lockfile/fs, and resolving/local-resolver tests with
  `await expect(x()).rejects.toMatchObject({...})`. The old pattern
  swallowed an unrelated `throw` if the under-test call silently
  succeeded, which would fail on the catch-block assertion with a
  misleading message.
2026-04-21 22:50:40 +02:00

275 lines
6.9 KiB
TypeScript
Raw Permalink Blame History

import { expect, test } from '@jest/globals'
import { LOCKFILE_VERSION, WANTED_LOCKFILE } from '@pnpm/constants'
import { addDependenciesToPackage, install } from '@pnpm/installing.deps-installer'
import { prepareEmpty } from '@pnpm/prepare'
import { getIntegrity } from '@pnpm/registry-mock'
import { rimrafSync } from '@zkochan/rimraf'
import { writeYamlFileSync } from 'write-yaml-file'
import { testDefaults } from '../utils/index.js'
const RESOLUTIONS = [
{
targets: [
{
os: 'darwin',
cpu: 'arm64',
},
],
resolution: {
type: 'binary',
archive: 'zip',
url: 'https://github.com/oven-sh/bun/releases/download/bun-v1.2.19/bun-darwin-aarch64.zip',
integrity: 'sha256-Z0pIN4NC76rcPCkVlrVzAQ88I4iVj3xEZ42H9vt1mZE=',
prefix: 'bun-darwin-aarch64',
bin: 'bun',
},
},
{
targets: [
{
os: 'darwin',
cpu: 'x64',
},
],
resolution: {
type: 'binary',
archive: 'zip',
url: 'https://github.com/oven-sh/bun/releases/download/bun-v1.2.19/bun-darwin-x64.zip',
integrity: 'sha256-39fkxHMRtdvTgjCzz9NX9dC+ro75eZYsW0EAj8QcJaA=',
prefix: 'bun-darwin-x64',
bin: 'bun',
},
},
{
targets: [
{
os: 'linux',
cpu: 'arm64',
libc: 'musl',
},
],
resolution: {
type: 'binary',
archive: 'zip',
url: 'https://github.com/oven-sh/bun/releases/download/bun-v1.2.19/bun-linux-aarch64-musl.zip',
integrity: 'sha256-ECBLT4ZeQCUI1pVr75O+Y11qek3cl0lCGxY2qseZZbY=',
prefix: 'bun-linux-aarch64-musl',
bin: 'bun',
},
},
{
targets: [
{
os: 'linux',
cpu: 'arm64',
},
],
resolution: {
type: 'binary',
archive: 'zip',
url: 'https://github.com/oven-sh/bun/releases/download/bun-v1.2.19/bun-linux-aarch64.zip',
integrity: 'sha256-/P1HHNvVp4/Uo5DinMzSu3AEpJ01K6A3rzth1P1dC4M=',
prefix: 'bun-linux-aarch64',
bin: 'bun',
},
},
{
targets: [
{
os: 'linux',
cpu: 'x64',
libc: 'musl',
},
],
resolution: {
type: 'binary',
archive: 'zip',
url: 'https://github.com/oven-sh/bun/releases/download/bun-v1.2.19/bun-linux-x64-musl.zip',
integrity: 'sha256-3M13Zi0KtkLSgO704yFtYCru4VGfdTXKHYOsqRjo/os=',
prefix: 'bun-linux-x64-musl',
bin: 'bun',
},
},
{
targets: [
{
os: 'linux',
cpu: 'x64',
},
],
resolution: {
type: 'binary',
archive: 'zip',
url: 'https://github.com/oven-sh/bun/releases/download/bun-v1.2.19/bun-linux-x64.zip',
integrity: 'sha256-w9PBTppeyD/2fQrP525DFa0G2p809Z/HsTgTeCyvH2Y=',
prefix: 'bun-linux-x64',
bin: 'bun',
},
},
{
targets: [
{
os: 'win32',
cpu: 'x64',
},
],
resolution: {
type: 'binary',
archive: 'zip',
url: 'https://github.com/oven-sh/bun/releases/download/bun-v1.2.19/bun-windows-x64.zip',
integrity: 'sha256-pIj0ZM5nsw4Ayw6lay9i5JuBw/zqe6kkYdNiJLBvdfg=',
prefix: 'bun-windows-x64',
bin: 'bun.exe',
},
},
]
test('installing Bun runtime', async () => {
const project = prepareEmpty()
const { updatedManifest: manifest } = await addDependenciesToPackage({}, ['bun@runtime:1.2.19'], testDefaults({ fastUnpack: false }))
project.isExecutable('.bin/bun')
expect(project.readLockfile()).toStrictEqual({
settings: {
autoInstallPeers: true,
excludeLinksFromLockfile: false,
},
importers: {
'.': {
dependencies: {
bun: {
specifier: 'runtime:1.2.19',
version: 'runtime:1.2.19',
},
},
},
},
lockfileVersion: LOCKFILE_VERSION,
packages: {
'bun@runtime:1.2.19': {
hasBin: true,
resolution: {
type: 'variations',
variants: RESOLUTIONS,
},
version: '1.2.19',
},
},
snapshots: {
'bun@runtime:1.2.19': {},
},
})
rimrafSync('node_modules')
await install(manifest, testDefaults({ frozenLockfile: true }, {
offline: true, // We want to verify that Bun is resolved from cache.
}))
project.isExecutable('.bin/bun')
await addDependenciesToPackage(manifest, ['@pnpm.e2e/dep-of-pkg-with-1-dep@100.1.0'], testDefaults({ fastUnpack: false }))
project.has('@pnpm.e2e/dep-of-pkg-with-1-dep')
expect(project.readLockfile()).toStrictEqual({
settings: {
autoInstallPeers: true,
excludeLinksFromLockfile: false,
},
importers: {
'.': {
dependencies: {
bun: {
specifier: 'runtime:1.2.19',
version: 'runtime:1.2.19',
},
'@pnpm.e2e/dep-of-pkg-with-1-dep': {
specifier: '100.1.0',
version: '100.1.0',
},
},
},
},
lockfileVersion: LOCKFILE_VERSION,
packages: {
'bun@runtime:1.2.19': {
hasBin: true,
resolution: {
type: 'variations',
variants: RESOLUTIONS,
},
version: '1.2.19',
},
'@pnpm.e2e/dep-of-pkg-with-1-dep@100.1.0': {
resolution: {
integrity: getIntegrity('@pnpm.e2e/dep-of-pkg-with-1-dep', '100.1.0'),
},
},
},
snapshots: {
'bun@runtime:1.2.19': {},
'@pnpm.e2e/dep-of-pkg-with-1-dep@100.1.0': {},
},
})
})
test('installing Bun runtime fails if offline mode is used and Bun not found locally', async () => {
prepareEmpty()
await expect(
addDependenciesToPackage({}, ['bun@runtime:1.2.19'], testDefaults({ fastUnpack: false }, { offline: true }))
).rejects.toThrow(/Failed to resolve bun@1.2.19 in package mirror/)
})
test('installing Bun runtime fails if integrity check fails', async () => {
prepareEmpty()
writeYamlFileSync(WANTED_LOCKFILE, {
settings: {
autoInstallPeers: true,
excludeLinksFromLockfile: false,
},
importers: {
'.': {
devDependencies: {
bun: {
specifier: 'runtime:1.2.19',
version: 'runtime:1.2.19',
},
},
},
},
lockfileVersion: LOCKFILE_VERSION,
packages: {
'bun@runtime:1.2.19': {
hasBin: true,
resolution: {
type: 'variations',
variants: RESOLUTIONS.map((resolutionVariant) => ({
...resolutionVariant,
resolution: {
...resolutionVariant.resolution,
integrity: 'sha256-0000000000000000000000000000000000000000000=',
},
})),
},
version: '1.2.19',
},
},
snapshots: {
'bun@runtime:1.2.19': {},
},
}, {
lineWidth: -1,
})
const manifest = {
devDependencies: {
bun: 'runtime:1.2.19',
},
}
await expect(install(manifest, testDefaults({ frozenLockfile: true }, {
retry: {
retries: 0,
},
}))).rejects.toThrow(/Got unexpected checksum for/)
})
Reference in New Issue View Git Blame Copy Permalink