mirror of
https://github.com/pnpm/pnpm.git
synced 2026-07-28 16:37:47 -04:00
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
308 lines
8.0 KiB
TypeScript
308 lines
8.0 KiB
TypeScript
import path from 'node:path'
|
|
|
|
import { expect, jest, test } from '@jest/globals'
|
|
import { WANTED_LOCKFILE } from '@pnpm/constants'
|
|
import {
|
|
install,
|
|
type MutatedProject,
|
|
mutateModules,
|
|
} from '@pnpm/installing.deps-installer'
|
|
import { prepareEmpty, preparePackages } from '@pnpm/prepare'
|
|
import type { ProjectRootDir } from '@pnpm/types'
|
|
|
|
import { testDefaults } from '../utils/index.js'
|
|
|
|
test(`frozen-lockfile: installation fails if specs in package.json don't match the ones in ${WANTED_LOCKFILE}`, async () => {
|
|
prepareEmpty()
|
|
|
|
await install(
|
|
{
|
|
dependencies: {
|
|
'is-positive': '1.0.0',
|
|
},
|
|
},
|
|
testDefaults()
|
|
)
|
|
|
|
await expect(
|
|
install({
|
|
dependencies: {
|
|
'is-positive': '^3.1.0',
|
|
},
|
|
}, testDefaults({ frozenLockfile: true }))
|
|
).rejects.toThrow(`Cannot install with "frozen-lockfile" because ${WANTED_LOCKFILE} is not up to date with ${path.join('<ROOT>', 'package.json')}`)
|
|
})
|
|
|
|
test(`frozen-lockfile+hoistPattern: installation fails if specs in package.json don't match the ones in ${WANTED_LOCKFILE}`, async () => {
|
|
prepareEmpty()
|
|
|
|
await install({
|
|
dependencies: {
|
|
'is-positive': '1.0.0',
|
|
},
|
|
}, testDefaults({ hoistPattern: '*' }))
|
|
|
|
await expect(
|
|
install({
|
|
dependencies: {
|
|
'is-positive': '^3.1.0',
|
|
},
|
|
}, testDefaults({ frozenLockfile: true, hoistPattern: '*' }))
|
|
).rejects.toThrow(`Cannot install with "frozen-lockfile" because ${WANTED_LOCKFILE} is not up to date with ${path.join('<ROOT>', 'package.json')}`)
|
|
})
|
|
|
|
test(`frozen-lockfile: fail on a shared ${WANTED_LOCKFILE} that does not satisfy one of the package.json files`, async () => {
|
|
prepareEmpty()
|
|
|
|
const projects: MutatedProject[] = [
|
|
{
|
|
mutation: 'install',
|
|
rootDir: path.resolve('p1') as ProjectRootDir,
|
|
},
|
|
{
|
|
mutation: 'install',
|
|
rootDir: path.resolve('p2') as ProjectRootDir,
|
|
},
|
|
]
|
|
const project1 = {
|
|
buildIndex: 0,
|
|
manifest: {
|
|
name: 'p1',
|
|
|
|
dependencies: {
|
|
'is-positive': '1.0.0',
|
|
},
|
|
},
|
|
rootDir: path.resolve('p1') as ProjectRootDir,
|
|
}
|
|
const project2 = {
|
|
buildIndex: 0,
|
|
manifest: {
|
|
name: 'p2',
|
|
|
|
dependencies: {
|
|
'is-negative': '1.0.0',
|
|
},
|
|
},
|
|
rootDir: path.resolve('p2') as ProjectRootDir,
|
|
}
|
|
await mutateModules(projects, testDefaults({
|
|
allProjects: [project1, project2],
|
|
}))
|
|
|
|
project1.manifest = {
|
|
...project1.manifest,
|
|
dependencies: {
|
|
'is-positive': '^3.1.0',
|
|
},
|
|
}
|
|
|
|
await expect(
|
|
mutateModules(projects, testDefaults({ frozenLockfile: true, allProjects: [project1, project2] }))
|
|
).rejects.toThrow(`Cannot install with "frozen-lockfile" because ${WANTED_LOCKFILE} is not up to date with ${path.join('<ROOT>', 'p1/package.json')}`)
|
|
})
|
|
|
|
test(`frozen-lockfile: should successfully install when ${WANTED_LOCKFILE} is available`, async () => {
|
|
const project = prepareEmpty()
|
|
|
|
const { updatedManifest: manifest } = await install({
|
|
dependencies: {
|
|
'is-positive': '^3.0.0',
|
|
},
|
|
}, testDefaults({ lockfileOnly: true }))
|
|
|
|
project.hasNot('is-positive')
|
|
|
|
await install(manifest, testDefaults({ frozenLockfile: true }))
|
|
|
|
project.has('is-positive')
|
|
})
|
|
|
|
test(`frozen-lockfile: should fail if no ${WANTED_LOCKFILE} is present`, async () => {
|
|
prepareEmpty()
|
|
|
|
await expect(
|
|
install({
|
|
dependencies: {
|
|
'is-positive': '^3.0.0',
|
|
},
|
|
}, testDefaults({ frozenLockfile: true }))
|
|
).rejects.toThrow(`Cannot install with "frozen-lockfile" because ${WANTED_LOCKFILE} is absent`)
|
|
})
|
|
|
|
test(`prefer-frozen-lockfile: should prefer headless installation when ${WANTED_LOCKFILE} satisfies package.json`, async () => {
|
|
const project = prepareEmpty()
|
|
|
|
const { updatedManifest: manifest } = await install({
|
|
dependencies: {
|
|
'is-positive': '^3.0.0',
|
|
},
|
|
}, testDefaults({ lockfileOnly: true }))
|
|
|
|
project.hasNot('is-positive')
|
|
|
|
const reporter = jest.fn()
|
|
await install(manifest, testDefaults({ reporter, preferFrozenLockfile: true }))
|
|
|
|
expect(reporter).toHaveBeenCalledWith(expect.objectContaining({
|
|
level: 'info',
|
|
message: 'Lockfile is up to date, resolution step is skipped',
|
|
name: 'pnpm',
|
|
}))
|
|
|
|
project.has('is-positive')
|
|
})
|
|
|
|
test(`prefer-frozen-lockfile: should not prefer headless installation when ${WANTED_LOCKFILE} does not satisfy package.json`, async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await install({
|
|
dependencies: {
|
|
'is-positive': '^3.0.0',
|
|
},
|
|
}, testDefaults({ lockfileOnly: true }))
|
|
|
|
project.hasNot('is-positive')
|
|
|
|
const reporter = jest.fn()
|
|
await install({
|
|
dependencies: {
|
|
'is-negative': '1.0.0',
|
|
},
|
|
}, testDefaults({ reporter, preferFrozenLockfile: true }))
|
|
|
|
expect(reporter).not.toHaveBeenCalledWith(expect.objectContaining({
|
|
level: 'info',
|
|
message: 'Lockfile is up to date, resolution step is skipped',
|
|
name: 'pnpm',
|
|
}))
|
|
|
|
project.has('is-negative')
|
|
})
|
|
|
|
test(`prefer-frozen-lockfile: should not fail if no ${WANTED_LOCKFILE} is present and project has no deps`, async () => {
|
|
prepareEmpty()
|
|
|
|
await install({}, testDefaults({ preferFrozenLockfile: true }))
|
|
})
|
|
|
|
test(`frozen-lockfile: should not fail if no ${WANTED_LOCKFILE} is present and project has no deps`, async () => {
|
|
prepareEmpty()
|
|
|
|
await install({}, testDefaults({ frozenLockfile: true }))
|
|
})
|
|
|
|
test(`prefer-frozen-lockfile+hoistPattern: should prefer headless installation when ${WANTED_LOCKFILE} satisfies package.json`, async () => {
|
|
const project = prepareEmpty()
|
|
|
|
const { updatedManifest: manifest } = await install({
|
|
dependencies: {
|
|
'@pnpm.e2e/pkg-with-1-dep': '100.0.0',
|
|
},
|
|
}, testDefaults({ lockfileOnly: true }))
|
|
|
|
project.hasNot('@pnpm.e2e/pkg-with-1-dep')
|
|
|
|
const reporter = jest.fn()
|
|
await install(manifest, testDefaults({
|
|
hoistPattern: '*',
|
|
preferFrozenLockfile: true,
|
|
reporter,
|
|
}))
|
|
|
|
expect(reporter).toHaveBeenCalledWith(expect.objectContaining({
|
|
level: 'info',
|
|
message: 'Lockfile is up to date, resolution step is skipped',
|
|
name: 'pnpm',
|
|
}))
|
|
|
|
project.has('@pnpm.e2e/pkg-with-1-dep')
|
|
project.has('.pnpm/node_modules/@pnpm.e2e/dep-of-pkg-with-1-dep')
|
|
})
|
|
|
|
test('prefer-frozen-lockfile: should prefer frozen-lockfile when package has linked dependency', async () => {
|
|
const projects = preparePackages([
|
|
{
|
|
name: 'p1',
|
|
|
|
dependencies: {
|
|
p2: 'link:../p2',
|
|
},
|
|
},
|
|
{
|
|
name: 'p2',
|
|
|
|
dependencies: {
|
|
'is-negative': '1.0.0',
|
|
},
|
|
},
|
|
])
|
|
|
|
const mutatedProjects: MutatedProject[] = [
|
|
{
|
|
mutation: 'install',
|
|
rootDir: path.resolve('p1') as ProjectRootDir,
|
|
},
|
|
{
|
|
mutation: 'install',
|
|
rootDir: path.resolve('p2') as ProjectRootDir,
|
|
},
|
|
]
|
|
const allProjects = [
|
|
{
|
|
buildIndex: 0,
|
|
manifest: {
|
|
name: 'p1',
|
|
|
|
dependencies: {
|
|
p2: 'link:../p2',
|
|
},
|
|
},
|
|
rootDir: path.resolve('p1') as ProjectRootDir,
|
|
},
|
|
{
|
|
buildIndex: 0,
|
|
manifest: {
|
|
name: 'p2',
|
|
|
|
dependencies: {
|
|
'is-negative': '1.0.0',
|
|
},
|
|
},
|
|
rootDir: path.resolve('p2') as ProjectRootDir,
|
|
},
|
|
]
|
|
await mutateModules(mutatedProjects, testDefaults({ allProjects }))
|
|
|
|
const reporter = jest.fn()
|
|
await mutateModules(mutatedProjects, testDefaults({
|
|
allProjects,
|
|
preferFrozenLockfile: true,
|
|
reporter,
|
|
}))
|
|
|
|
expect(reporter).toHaveBeenCalledWith(expect.objectContaining({
|
|
level: 'info',
|
|
message: 'Lockfile is up to date, resolution step is skipped',
|
|
name: 'pnpm',
|
|
}))
|
|
|
|
projects['p1'].has('p2')
|
|
projects['p2'].has('is-negative')
|
|
})
|
|
|
|
test('frozen-lockfile: installation fails if the value of auto-install-peers changes', async () => {
|
|
prepareEmpty()
|
|
const manifest = {
|
|
dependencies: {
|
|
'is-positive': '^3.0.0',
|
|
},
|
|
}
|
|
|
|
await install(manifest, testDefaults({ autoInstallPeers: true }))
|
|
|
|
await expect(
|
|
install(manifest, testDefaults({ frozenLockfile: true, autoInstallPeers: false }))
|
|
).rejects.toThrow('Cannot proceed with the frozen installation. The current "settings.autoInstallPeers" configuration doesn\'t match the value found in the lockfile')
|
|
})
|