mirror of
https://github.com/pnpm/pnpm.git
synced 2026-07-26 23:47:20 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
72 lines
2.5 KiB
TypeScript
72 lines
2.5 KiB
TypeScript
import { expect, test } from '@jest/globals'
|
|
import { WANTED_LOCKFILE } from '@pnpm/constants'
|
|
import { addDependenciesToPackage } from '@pnpm/installing.deps-installer'
|
|
import { prepareEmpty } from '@pnpm/prepare'
|
|
|
|
import { testDefaults } from '../utils/index.js'
|
|
|
|
test('fail if installed package does not support the current engine and engine-strict = true', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await expect(
|
|
addDependenciesToPackage({}, ['@pnpm.e2e/not-compatible-with-any-os'], testDefaults({}, {}, {}, {
|
|
engineStrict: true,
|
|
}))
|
|
).rejects.toThrow()
|
|
project.hasNot('@pnpm.e2e/not-compatible-with-any-os')
|
|
project.storeHasNot('@pnpm.e2e/not-compatible-with-any-os', '1.0.0')
|
|
})
|
|
|
|
test('do not fail if installed package does not support the current engine and engine-strict = false', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await addDependenciesToPackage({}, ['@pnpm.e2e/not-compatible-with-any-os'], testDefaults({
|
|
engineStrict: false,
|
|
}))
|
|
|
|
project.has('@pnpm.e2e/not-compatible-with-any-os')
|
|
project.storeHas('@pnpm.e2e/not-compatible-with-any-os', '1.0.0')
|
|
|
|
const lockfile = project.readLockfile()
|
|
expect(lockfile.packages['@pnpm.e2e/not-compatible-with-any-os@1.0.0'].os).toStrictEqual(['this-os-does-not-exist'])
|
|
})
|
|
|
|
test('do not fail if installed package requires the node version that was passed in and engine-strict = true', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await addDependenciesToPackage({}, ['@pnpm.e2e/for-legacy-node'], testDefaults({
|
|
engineStrict: true,
|
|
nodeVersion: '0.10.0',
|
|
}))
|
|
|
|
project.has('@pnpm.e2e/for-legacy-node')
|
|
project.storeHas('@pnpm.e2e/for-legacy-node', '1.0.0')
|
|
|
|
const lockfile = project.readLockfile()
|
|
expect(lockfile.packages['@pnpm.e2e/for-legacy-node@1.0.0'].engines).toStrictEqual({ node: '0.10' })
|
|
})
|
|
|
|
test(`save cpu field to ${WANTED_LOCKFILE}`, async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await addDependenciesToPackage({}, ['@pnpm.e2e/has-cpu-specified'], testDefaults())
|
|
|
|
const lockfile = project.readLockfile()
|
|
|
|
expect(
|
|
lockfile.packages['@pnpm.e2e/has-cpu-specified@1.0.0'].cpu
|
|
).toStrictEqual(
|
|
['x64', 'ia32']
|
|
)
|
|
})
|
|
|
|
test(`engines field is not added to ${WANTED_LOCKFILE} when "node": "*" is in "engines" field`, async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await addDependenciesToPackage({}, ['jsonify@0.0.0'], testDefaults())
|
|
|
|
const lockfile = project.readLockfile()
|
|
|
|
expect(lockfile.packages['jsonify@0.0.0']).not.toHaveProperty(['engines'])
|
|
})
|