mirror of
https://github.com/pnpm/pnpm.git
synced 2026-07-25 15:07:06 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
166 lines
4.3 KiB
TypeScript
166 lines
4.3 KiB
TypeScript
import fs from 'node:fs'
|
|
import path from 'node:path'
|
|
|
|
import { expect, test } from '@jest/globals'
|
|
import { addDependenciesToPackage, install } from '@pnpm/installing.deps-installer'
|
|
import { prepareEmpty } from '@pnpm/prepare'
|
|
|
|
import { testDefaults } from '../utils/index.js'
|
|
|
|
test('production install (with --production flag)', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await install({
|
|
dependencies: {
|
|
'@pnpm.e2e/pkg-with-1-dep': '100.0.0',
|
|
'write-yaml': '1.0.0',
|
|
},
|
|
devDependencies: {
|
|
'@zkochan/foo': '1.0.0',
|
|
// js-yaml is also a dependency of write-yaml
|
|
// covers issue https://github.com/pnpm/pnpm/issues/2882
|
|
'js-yaml': '3.14.0',
|
|
once: '^1.4.0',
|
|
},
|
|
}, testDefaults({
|
|
fastUnpack: false,
|
|
include: {
|
|
dependencies: true,
|
|
devDependencies: false,
|
|
optionalDependencies: true,
|
|
},
|
|
}))
|
|
|
|
expect(fs.existsSync(path.resolve('node_modules/.pnpm/@zkochan/foo@1.0.0'))).toBeFalsy()
|
|
expect(fs.existsSync(path.resolve('node_modules/.pnpm/js-yaml@3.14.0'))).toBeTruthy()
|
|
project.has('@pnpm.e2e/pkg-with-1-dep')
|
|
project.has('write-yaml')
|
|
project.hasNot('@zkochan/foo')
|
|
project.hasNot('js-yaml')
|
|
})
|
|
|
|
test('production install with --no-optional', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await install({
|
|
dependencies: {
|
|
'@pnpm.e2e/pkg-with-1-dep': '100.0.0',
|
|
'write-yaml': '1.0.0',
|
|
},
|
|
optionalDependencies: {
|
|
'@zkochan/foo': '1.0.0',
|
|
// js-yaml is also a dependency of write-yaml
|
|
// covers issue https://github.com/pnpm/pnpm/issues/2882
|
|
'js-yaml': '3.14.0',
|
|
once: '^1.4.0',
|
|
},
|
|
}, testDefaults({
|
|
fastUnpack: false,
|
|
include: {
|
|
dependencies: true,
|
|
devDependencies: false,
|
|
optionalDependencies: false,
|
|
},
|
|
}))
|
|
|
|
expect(fs.existsSync(path.resolve('node_modules/.pnpm/@zkochan/foo@1.0.0'))).toBeFalsy()
|
|
expect(fs.existsSync(path.resolve('node_modules/.pnpm/js-yaml@3.14.0'))).toBeTruthy()
|
|
project.has('@pnpm.e2e/pkg-with-1-dep')
|
|
project.has('write-yaml')
|
|
project.hasNot('@zkochan/foo')
|
|
project.hasNot('js-yaml')
|
|
})
|
|
|
|
test('install dev dependencies only', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
const { updatedManifest: manifest } = await install({
|
|
dependencies: {
|
|
'is-positive': '1.0.0',
|
|
once: '^1.4.0',
|
|
},
|
|
devDependencies: {
|
|
inflight: '1.0.6',
|
|
},
|
|
}, testDefaults({
|
|
include: {
|
|
dependencies: false,
|
|
devDependencies: true,
|
|
optionalDependencies: false,
|
|
},
|
|
}))
|
|
|
|
project.has('inflight')
|
|
project.hasNot('once')
|
|
|
|
{
|
|
const currentLockfile = project.readCurrentLockfile()
|
|
expect(currentLockfile.packages['is-positive@1.0.0']).toBeFalsy()
|
|
}
|
|
|
|
// Repeat normal installation adds missing deps to node_modules
|
|
await install(manifest, testDefaults())
|
|
|
|
project.has('once')
|
|
|
|
{
|
|
const currentLockfile = project.readCurrentLockfile()
|
|
expect(currentLockfile.packages['is-positive@1.0.0']).toBeTruthy()
|
|
}
|
|
})
|
|
|
|
test('fail if installing different types of dependencies in a project that uses an external lockfile', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
const lockfileDir = path.resolve('..')
|
|
|
|
const { updatedManifest: manifest } = await install({
|
|
dependencies: {
|
|
'is-positive': '1.0.0',
|
|
once: '^1.4.0',
|
|
},
|
|
devDependencies: {
|
|
inflight: '1.0.6',
|
|
},
|
|
}, testDefaults({
|
|
include: {
|
|
dependencies: false,
|
|
devDependencies: true,
|
|
optionalDependencies: false,
|
|
},
|
|
lockfileDir,
|
|
}))
|
|
|
|
project.has('inflight')
|
|
project.hasNot('once')
|
|
|
|
const newOpts = testDefaults({
|
|
confirmModulesPurge: false,
|
|
include: {
|
|
dependencies: true,
|
|
devDependencies: true,
|
|
optionalDependencies: true,
|
|
},
|
|
lockfileDir,
|
|
})
|
|
|
|
await expect(
|
|
addDependenciesToPackage(manifest, ['is-negative'], newOpts)
|
|
).rejects.toThrow(/was installed with devDependencies. Current install wants optionalDependencies, dependencies, devDependencies./)
|
|
|
|
await install(manifest, newOpts)
|
|
})
|
|
|
|
test('installation should not fail if a linked dependency points to a directory that does not exist', async () => {
|
|
const project = prepareEmpty()
|
|
|
|
await install({
|
|
dependencies: {
|
|
'is-positive': '1.0.0',
|
|
'not-exists': 'link:../not-exists',
|
|
},
|
|
}, testDefaults())
|
|
|
|
project.has('is-positive')
|
|
})
|