mirror of
https://github.com/pnpm/pnpm.git
synced 2026-07-21 21:22:26 -04:00
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
111 lines
4.6 KiB
TypeScript
111 lines
4.6 KiB
TypeScript
/// <reference path="../../../__typings__/index.d.ts"/>
|
|
// cspell:ignore buildserver
|
|
import { expect, test } from '@jest/globals'
|
|
import { createFetchFromRegistry } from '@pnpm/network.fetch'
|
|
import { resolveFromTarball as _resolveFromTarball } from '@pnpm/resolving.tarball-resolver'
|
|
|
|
const fetch = createFetchFromRegistry({})
|
|
const resolveFromTarball = _resolveFromTarball.bind(null, fetch)
|
|
|
|
test('tarball from npm registry (immutable)', async () => {
|
|
const resolutionResult = await resolveFromTarball({ bareSpecifier: 'https://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz' })
|
|
|
|
expect(resolutionResult).toStrictEqual({
|
|
id: 'https://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz',
|
|
normalizedBareSpecifier: 'https://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz',
|
|
resolution: {
|
|
tarball: 'https://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz',
|
|
},
|
|
resolvedVia: 'url',
|
|
})
|
|
})
|
|
test('tarball from npm.jsr.io registry (immutable)', async () => {
|
|
const resolutionResult = await resolveFromTarball({ bareSpecifier: 'https://npm.jsr.io/~/11/@jsr/luca__flag/1.0.1.tgz' })
|
|
|
|
expect(resolutionResult).toStrictEqual({
|
|
id: 'https://npm.jsr.io/~/11/@jsr/luca__flag/1.0.1.tgz',
|
|
normalizedBareSpecifier: 'https://npm.jsr.io/~/11/@jsr/luca__flag/1.0.1.tgz',
|
|
resolution: {
|
|
tarball: 'https://npm.jsr.io/~/11/@jsr/luca__flag/1.0.1.tgz',
|
|
},
|
|
resolvedVia: 'url',
|
|
})
|
|
})
|
|
|
|
test('tarball from URL that contain port number', async () => {
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const fetch: any = async (url: string) => ({ url })
|
|
const resolutionResult = await _resolveFromTarball(fetch, { bareSpecifier: 'http://buildserver.mycompany.com:81/my-private-package-0.1.6.tgz' })
|
|
|
|
expect(resolutionResult).toStrictEqual({
|
|
id: 'http://buildserver.mycompany.com:81/my-private-package-0.1.6.tgz',
|
|
normalizedBareSpecifier: 'http://buildserver.mycompany.com:81/my-private-package-0.1.6.tgz',
|
|
resolution: {
|
|
tarball: 'http://buildserver.mycompany.com:81/my-private-package-0.1.6.tgz',
|
|
},
|
|
resolvedVia: 'url',
|
|
})
|
|
})
|
|
|
|
test('tarball from URL with redundant port', async () => {
|
|
const resolutionResult = await resolveFromTarball({ bareSpecifier: 'https://registry.npmjs.org:443/is-array/-/is-array-1.0.1.tgz' })
|
|
|
|
expect(resolutionResult).toStrictEqual({
|
|
id: 'https://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz',
|
|
normalizedBareSpecifier: 'https://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz',
|
|
resolution: {
|
|
tarball: 'https://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz',
|
|
},
|
|
resolvedVia: 'url',
|
|
})
|
|
})
|
|
|
|
test('tarball from URL that redirects to a different URL (immutable)', async () => {
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
const fetch: any = async (url: string) => {
|
|
if (url === 'http://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz') {
|
|
return {
|
|
url: 'https://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz',
|
|
headers: new Map([['cache-control', 'immutable']]),
|
|
}
|
|
}
|
|
return { url }
|
|
}
|
|
const resolutionResult = await _resolveFromTarball(fetch, { bareSpecifier: 'http://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz' })
|
|
|
|
expect(resolutionResult).toStrictEqual({
|
|
id: 'http://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz',
|
|
normalizedBareSpecifier: 'http://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz',
|
|
resolution: {
|
|
tarball: 'https://registry.npmjs.org/is-array/-/is-array-1.0.1.tgz',
|
|
},
|
|
resolvedVia: 'url',
|
|
})
|
|
})
|
|
|
|
test('tarball not from npm registry (mutable)', async () => {
|
|
const resolutionResult = await resolveFromTarball({ bareSpecifier: 'https://github.com/hegemonic/taffydb/tarball/master' })
|
|
|
|
expect(resolutionResult).toStrictEqual({
|
|
id: 'https://github.com/hegemonic/taffydb/tarball/master',
|
|
normalizedBareSpecifier: 'https://github.com/hegemonic/taffydb/tarball/master',
|
|
resolution: {
|
|
tarball: 'https://github.com/hegemonic/taffydb/tarball/master',
|
|
},
|
|
resolvedVia: 'url',
|
|
})
|
|
})
|
|
|
|
test('tarballs from GitHub (is-negative)', async () => {
|
|
const resolutionResult = await resolveFromTarball({ bareSpecifier: 'https://github.com/kevva/is-negative/archive/1d7e288222b53a0cab90a331f1865220ec29560c.tar.gz' })
|
|
|
|
expect(resolutionResult).toStrictEqual({
|
|
id: 'https://github.com/kevva/is-negative/archive/1d7e288222b53a0cab90a331f1865220ec29560c.tar.gz',
|
|
normalizedBareSpecifier: 'https://github.com/kevva/is-negative/archive/1d7e288222b53a0cab90a331f1865220ec29560c.tar.gz',
|
|
resolution: {
|
|
tarball: 'https://github.com/kevva/is-negative/archive/1d7e288222b53a0cab90a331f1865220ec29560c.tar.gz',
|
|
},
|
|
resolvedVia: 'url',
|
|
})
|
|
})
|