Files
pnpm/cli/default-reporter/test/reportingUpdateCheck.ts
Brandon Cheng b217edbfd8 test: fix silently failing tests in default-reporter package (#9253)
* test: move expect blocks (without other changes) to end of test

This is required for the refactor in the next commit. The log statements
have to run before consuming the output stream, otherwise the output
stream will be empty.

* test: fix swallowed Jest expect errors in `default-reporter` package

* test: fix expected to match actual values in default-reporter tests

* refactor: remove redundant `.pipe(take(1))`

With the refactor to use `firstValueFrom`, the `take(1)` is now
redundant in many places.

```ts
firstValueFrom(output$.pipe(take(1)))
```

```ts
firstValueFrom(output$)
```
2025-03-10 00:47:58 +01:00

102 lines
2.5 KiB
TypeScript

import { setTimeout } from 'node:timers/promises'
import { type Config } from '@pnpm/config'
import { updateCheckLogger } from '@pnpm/core-loggers'
import { toOutput$ } from '@pnpm/default-reporter'
import { createStreamParser } from '@pnpm/logger'
import { firstValueFrom } from 'rxjs'
import { stripVTControlCharacters as stripAnsi } from 'util'
const NO_OUTPUT = Symbol('test should not log anything')
test('does not print update if latest is less than current', async () => {
const output$ = toOutput$({
context: {
argv: ['install'],
env: {},
},
streamParser: createStreamParser(),
})
updateCheckLogger.debug({
currentVersion: '10.0.0',
latestVersion: '9.0.0',
})
const output = await Promise.race([
firstValueFrom(output$),
setTimeout(10).then(() => NO_OUTPUT),
])
expect(output).toEqual(NO_OUTPUT)
})
test('print update notification if the latest version is greater than the current', async () => {
const output$ = toOutput$({
context: {
argv: ['install'],
config: { recursive: true } as Config,
env: {},
},
streamParser: createStreamParser(),
})
updateCheckLogger.debug({
currentVersion: '10.0.0',
latestVersion: '11.0.0',
})
expect.assertions(1)
const output = await firstValueFrom(output$)
expect(stripAnsi(output)).toMatchSnapshot()
})
test('print update notification for Corepack if the latest version is greater than the current', async () => {
const output$ = toOutput$({
context: {
argv: ['install'],
config: { recursive: true } as Config,
env: {
COREPACK_ROOT: '/usr/bin/corepack',
},
},
streamParser: createStreamParser(),
})
updateCheckLogger.debug({
currentVersion: '10.0.0',
latestVersion: '11.0.0',
})
expect.assertions(1)
const output = await firstValueFrom(output$)
expect(stripAnsi(output)).toMatchSnapshot()
})
test('print update notification that suggests to use the standalone scripts for the upgrade', async () => {
const output$ = toOutput$({
context: {
argv: ['install'],
config: { recursive: true } as Config,
env: {
PNPM_HOME: '/home/user/.local/share/pnpm',
},
process: {
pkg: true,
} as any, // eslint-disable-line
},
streamParser: createStreamParser(),
})
updateCheckLogger.debug({
currentVersion: '10.0.0',
latestVersion: '11.0.0',
})
expect.assertions(1)
const output = await firstValueFrom(output$)
expect(stripAnsi(output)).toMatchSnapshot()
})