mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-12 10:11:42 -04:00
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
148 lines
4.9 KiB
TypeScript
148 lines
4.9 KiB
TypeScript
/// <reference path="../../../__typings__/index.d.ts"/>
|
|
import fs from 'node:fs'
|
|
import path from 'node:path'
|
|
|
|
import { expect, test } from '@jest/globals'
|
|
import { PnpmError } from '@pnpm/error'
|
|
import { runLifecycleHook, runLifecycleHooksConcurrently, runPostinstallHooks } from '@pnpm/exec.lifecycle'
|
|
import { tempDir } from '@pnpm/prepare'
|
|
import type { StoreController } from '@pnpm/store.controller-types'
|
|
import { fixtures } from '@pnpm/test-fixtures'
|
|
import { createTestIpcServer } from '@pnpm/test-ipc-server'
|
|
import type { ProjectRootDir } from '@pnpm/types'
|
|
import isWindows from 'is-windows'
|
|
|
|
const skipOnWindows = isWindows() ? test.skip : test
|
|
|
|
const f = fixtures(path.join(import.meta.dirname, 'fixtures'))
|
|
const rootModulesDir = path.join(import.meta.dirname, '..', 'node_modules')
|
|
|
|
test('runLifecycleHook()', async () => {
|
|
const pkgRoot = f.find('simple')
|
|
await using server = await createTestIpcServer(path.join(pkgRoot, 'test.sock'))
|
|
const { default: pkg } = await import(path.join(pkgRoot, 'package.json'))
|
|
await runLifecycleHook('postinstall', pkg, {
|
|
depPath: '/simple/1.0.0',
|
|
optional: false,
|
|
pkgRoot,
|
|
rootModulesDir,
|
|
unsafePerm: true,
|
|
})
|
|
|
|
expect(server.getLines()).toStrictEqual(['install'])
|
|
})
|
|
|
|
test('runLifecycleHook() escapes the args passed to the script', async () => {
|
|
const pkgRoot = f.find('escape-args')
|
|
const { default: pkg } = await import(path.join(pkgRoot, 'package.json'))
|
|
await runLifecycleHook('echo', pkg, {
|
|
depPath: '/escape-args/1.0.0',
|
|
pkgRoot,
|
|
rootModulesDir,
|
|
unsafePerm: true,
|
|
args: ['Revert "feature (#1)"'],
|
|
})
|
|
|
|
expect((await import(path.join(pkgRoot, 'output.json'))).default).toStrictEqual(['Revert "feature (#1)"'])
|
|
})
|
|
|
|
test('runLifecycleHook() passes newline correctly', async () => {
|
|
const pkgRoot = f.find('escape-newline')
|
|
const { default: pkg } = await import(path.join(pkgRoot, 'package.json'))
|
|
await runLifecycleHook('echo', pkg, {
|
|
depPath: 'escape-newline@1.0.0',
|
|
pkgRoot,
|
|
rootModulesDir,
|
|
unsafePerm: true,
|
|
args: ['a\nb != \'A\\nB\''],
|
|
})
|
|
|
|
expect((await import(path.join(pkgRoot, 'output.json'))).default).toStrictEqual([
|
|
process.platform === 'win32' ? 'a\\nb != \'A\\\\nB\'' : 'a\nb != \'A\\nB\'',
|
|
])
|
|
})
|
|
|
|
test('runLifecycleHook() does not set npm_config env vars', async () => {
|
|
const pkgRoot = f.find('inspect-frozen-lockfile')
|
|
await using server = await createTestIpcServer(path.join(pkgRoot, 'test.sock'))
|
|
const { default: pkg } = await import(path.join(pkgRoot, 'package.json'))
|
|
await runLifecycleHook('postinstall', pkg, {
|
|
depPath: '/inspect-frozen-lockfile/1.0.0',
|
|
pkgRoot,
|
|
rootModulesDir,
|
|
unsafePerm: true,
|
|
})
|
|
|
|
expect(server.getLines()).toStrictEqual(['unset'])
|
|
})
|
|
|
|
test('runPostinstallHooks()', async () => {
|
|
const pkgRoot = f.find('with-many-scripts')
|
|
await using server = await createTestIpcServer(path.join(pkgRoot, 'test.sock'))
|
|
await runPostinstallHooks({
|
|
depPath: '/with-many-scripts/1.0.0',
|
|
optional: false,
|
|
pkgRoot,
|
|
rootModulesDir,
|
|
unsafePerm: true,
|
|
})
|
|
|
|
expect(server.getLines()).toStrictEqual(['preinstall', 'install', 'postinstall'])
|
|
})
|
|
|
|
test('runLifecycleHook() should throw an error while missing script start or file server.js', async () => {
|
|
const pkgRoot = f.find('without-script-start-serverjs')
|
|
const { default: pkg } = await import(path.join(pkgRoot, 'package.json'))
|
|
await expect(
|
|
runLifecycleHook('start', pkg, {
|
|
depPath: '/without-script-start-serverjs/1.0.0',
|
|
optional: false,
|
|
pkgRoot,
|
|
rootModulesDir,
|
|
unsafePerm: true,
|
|
})
|
|
).rejects.toThrow(new PnpmError('NO_SCRIPT_OR_SERVER', 'Missing script start or file server.js'))
|
|
})
|
|
|
|
test('preinstall script does not trigger node-gyp rebuild', async () => {
|
|
const pkgRoot = f.find('gyp-with-preinstall')
|
|
await using server = await createTestIpcServer(path.join(pkgRoot, 'test.sock'))
|
|
await runPostinstallHooks({
|
|
depPath: '/gyp-with-preinstall/1.0.0',
|
|
optional: false,
|
|
pkgRoot,
|
|
rootModulesDir,
|
|
unsafePerm: true,
|
|
})
|
|
|
|
expect(server.getLines()).toStrictEqual(['preinstall'])
|
|
})
|
|
|
|
skipOnWindows('runLifecycleHooksConcurrently() should check binding.gyp', async () => {
|
|
const projectDir = tempDir(false)
|
|
|
|
fs.writeFileSync(path.join(projectDir, 'binding.gyp'), JSON.stringify({
|
|
targets: [
|
|
{
|
|
target_name: 'run_js_script',
|
|
actions: [
|
|
{
|
|
action_name: 'execute_postinstall',
|
|
inputs: [],
|
|
outputs: ['foo'],
|
|
action: ['node', '-e', 'require(\'fs\').writeFileSync(\'foo\', \'\', \'utf8\')'],
|
|
},
|
|
],
|
|
},
|
|
],
|
|
}), 'utf8')
|
|
|
|
await runLifecycleHooksConcurrently(['install'], [{ buildIndex: 0, rootDir: projectDir as ProjectRootDir, modulesDir: '', manifest: {} }], 5, {
|
|
storeController: {} as StoreController,
|
|
optional: false,
|
|
unsafePerm: true,
|
|
})
|
|
|
|
expect(fs.existsSync(path.join(projectDir, 'foo'))).toBeTruthy()
|
|
})
|