mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-06-30 02:45:11 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
37669c200d3fff2db20a032bc092ed7dc797be45
pnpm/installing/commands/test/update/update.ts
Zoltan Kochan ae2175829a feat(registry-access): extract dist-tag + adduser helpers, dogfood from tests (#11926) 
* feat(registry-access): extract setDistTag and dogfood from tests

Add `@pnpm/registry-access.commands#setDistTag` — the low-level PUT to
`/-/package/:pkg/dist-tags/:tag`. The CLI `dist-tag add` handler now
calls it instead of issuing the fetch inline.

Tests in this monorepo now use a thin new package
`@pnpm/testing.registry-mock` (REGISTRY_MOCK_PORT + REGISTRY_MOCK_CREDENTIALS
baked in) that delegates to `setDistTag`, replacing `addDistTag` from
`@pnpm/registry-mock`. That dropped helper relied on
`anonymous-npm-registry-client` and a verdaccio-era
fetch-then-DELETE-then-PUT dance that is no longer needed against
pnpm-registry.

39 test files swapped from `@pnpm/registry-mock` to
`@pnpm/testing.registry-mock`.

* fix: move setDistTag to its own package to break tsconfig project-reference cycle

testing/registry-mock → registry-access.commands → releasing/commands
→ installing/commands → installing/deps-installer → testing/registry-mock.

Extract setDistTag into @pnpm/registry-access.set-dist-tag (only depends
on @pnpm/error, @pnpm/network.fetch, @pnpm/npm-package-arg). Both
@pnpm/registry-access.commands and @pnpm/testing.registry-mock import
from it. Cycle gone.

* feat(registry-access): extract addUser helper, dogfood from login + tests

Add @pnpm/registry-access.add-user — a small helper that PUTs to
/-/user/org.couchdb.user:<name> and returns { token }. The CLI's
classicLogin (pnpm login fallback path) now calls it, and tests
use it via @pnpm/testing.registry-mock instead of the legacy
addUser from @pnpm/registry-mock.

Swapped 3 call sites: globalSetup.js, installing/deps-installer's
auth.ts, and pnpm/test/dlx.ts. AddUserHttpError exposes status +
text + parsed-json-if-applicable + headers so the CLI can still
do its OTP detection. One webauth-OTP login test mock had to be
adjusted to provide its body via `text` (JSON-stringified) rather
than `json` only, since the helper consumes the body via `text()`.

* refactor: consolidate set-dist-tag + add-user helpers into one @pnpm/registry-access.client package

One shared package is better than splitting per endpoint. Future endpoints
(publish, deprecate, etc.) can land here without another wrapper.

No behavioral change — same setDistTag and addUser exports as before,
just under one roof. Callers updated: registry-access.commands,
auth.commands, testing.registry-mock.

* fix(registry-access): sort imports
2026-05-25 14:01:00 +02:00

416 lines
12 KiB
TypeScript
Raw Blame History

import path from 'node:path'
import { beforeAll, describe, expect, it, test } from '@jest/globals'
import type { PnpmError } from '@pnpm/error'
import { install, update } from '@pnpm/installing.commands'
import { prepare, preparePackages } from '@pnpm/prepare'
import { addDistTag } from '@pnpm/testing.registry-mock'
import type { ProjectManifest } from '@pnpm/types'
import { loadJsonFileSync } from 'load-json-file'
import { DEFAULT_OPTS } from '../utils/index.js'
test('update with "*" pattern', async () => {
await addDistTag({ package: '@pnpm.e2e/peer-a', version: '1.0.1', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/peer-c', version: '2.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/foo', version: '2.0.0', distTag: 'latest' })
const project = prepare({
dependencies: {
'@pnpm.e2e/peer-a': '1.0.0',
'@pnpm.e2e/peer-c': '1.0.0',
'@pnpm.e2e/foo': '1.0.0',
},
})
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
})
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: true,
}, ['@pnpm.e2e/peer-*'])
const lockfile = project.readLockfile()
expect(lockfile.packages['@pnpm.e2e/peer-a@1.0.1']).toBeTruthy()
expect(lockfile.packages['@pnpm.e2e/peer-c@2.0.0']).toBeTruthy()
expect(lockfile.packages['@pnpm.e2e/foo@1.0.0']).toBeTruthy()
})
test('update to latest should not touch the automatically installed peer dependencies', async () => {
await addDistTag({ package: '@pnpm.e2e/peer-a', version: '1.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/peer-c', version: '1.0.0', distTag: 'latest' })
const project = prepare({
dependencies: {
'@pnpm.e2e/abc': '1.0.0',
},
})
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
})
await addDistTag({ package: '@pnpm.e2e/peer-a', version: '1.0.1', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/peer-c', version: '1.0.1', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/abc', version: '2.0.0', distTag: 'latest' })
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: true,
}, ['@pnpm.e2e/abc'])
const lockfile = project.readLockfile()
expect(lockfile.packages['@pnpm.e2e/peer-a@1.0.0']).toBeTruthy()
expect(lockfile.packages['@pnpm.e2e/peer-a@1.0.1']).toBeFalsy()
expect(lockfile.packages['@pnpm.e2e/peer-c@1.0.0']).toBeTruthy()
expect(lockfile.packages['@pnpm.e2e/peer-c@1.0.1']).toBeFalsy()
})
test('update with negation pattern', async () => {
await addDistTag({ package: '@pnpm.e2e/peer-a', version: '1.0.1', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/peer-c', version: '2.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/foo', version: '2.0.0', distTag: 'latest' })
const project = prepare({
dependencies: {
'@pnpm.e2e/peer-a': '1.0.0',
'@pnpm.e2e/peer-c': '1.0.0',
'@pnpm.e2e/foo': '1.0.0',
},
})
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
})
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: true,
}, ['!@pnpm.e2e/peer-*'])
const lockfile = project.readLockfile()
expect(lockfile.packages['@pnpm.e2e/peer-a@1.0.0']).toBeTruthy()
expect(lockfile.packages['@pnpm.e2e/peer-c@1.0.0']).toBeTruthy()
expect(lockfile.packages['@pnpm.e2e/foo@2.0.0']).toBeTruthy()
})
test('update: fail when both "latest" and "workspace" are true', async () => {
preparePackages([
{
name: 'project-1',
version: '1.0.0',
},
{
name: 'project-2',
version: '2.0.0',
},
])
let err!: PnpmError
try {
await update.handler({
...DEFAULT_OPTS,
dir: path.resolve('project-1'),
latest: true,
linkWorkspacePackages: false,
saveWorkspaceProtocol: false,
workspace: true,
workspaceDir: process.cwd(),
}, ['project-2'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_BAD_OPTIONS')
expect(err.message).toBe('Cannot use --latest with --workspace simultaneously')
})
test('update --latest forbids specs', async () => {
prepare()
let err!: PnpmError
try {
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: true,
workspaceDir: process.cwd(),
}, ['foo@latest', 'bar@next', 'baz'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_LATEST_WITH_SPEC')
expect(err.message).toBe('Specs are not allowed to be used with --latest (foo@latest, bar@next)')
})
describe('update by package name', () => {
beforeAll(async () => {
prepare({
dependencies: {
'@pnpm.e2e/peer-a': '1.0.0',
'@pnpm.e2e/peer-c': '1.0.0',
},
})
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
})
})
it("should fail when the package isn't in the direct dependencies and depth is 0", async () => {
let err!: PnpmError
try {
await update.handler({
...DEFAULT_OPTS,
depth: 0,
dir: process.cwd(),
sharedWorkspaceLockfile: true,
}, ['@pnpm.e2e/peer-b'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_NO_PACKAGE_IN_DEPENDENCIES')
expect(err.message).toBe('None of the specified packages were found in the dependencies.')
})
it("shouldn't fail when the package isn't in the direct dependencies", async () => {
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
sharedWorkspaceLockfile: true,
}, ['@pnpm.e2e/peer-b'])
})
})
test('update --no-save should not update package.json and pnpm-lock.yaml', async () => {
await addDistTag({ package: '@pnpm.e2e/peer-a', version: '1.0.0', distTag: 'latest' })
const project = prepare({
dependencies: {
'@pnpm.e2e/peer-a': '^1.0.0',
},
})
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
})
{
const manifest = loadJsonFileSync<ProjectManifest>('package.json')
expect(manifest.dependencies?.['@pnpm.e2e/peer-a']).toBe('^1.0.0')
const lockfile = project.readLockfile()
expect(lockfile.importers['.'].dependencies?.['@pnpm.e2e/peer-a'].specifier).toBe('^1.0.0')
expect(lockfile.packages['@pnpm.e2e/peer-a@1.0.0']).toBeTruthy()
}
await addDistTag({ package: '@pnpm.e2e/peer-a', version: '1.0.1', distTag: 'latest' })
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: true,
save: false,
}, [])
{
const manifest = loadJsonFileSync<ProjectManifest>('package.json')
expect(manifest.dependencies?.['@pnpm.e2e/peer-a']).toBe('^1.0.0')
const lockfile = project.readLockfile()
expect(lockfile.importers['.'].dependencies?.['@pnpm.e2e/peer-a'].specifier).toBe('^1.0.0')
expect(lockfile.packages['@pnpm.e2e/peer-a@1.0.1']).toBeTruthy()
}
})
// fix: https://github.com/pnpm/pnpm/issues/4196
test('update should work normal when set empty string version', async () => {
await addDistTag({ package: '@pnpm.e2e/peer-a', version: '1.0.1', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/peer-c', version: '2.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/foo', version: '2.0.0', distTag: 'latest' })
const project = prepare({
dependencies: {
'@pnpm.e2e/peer-a': '1.0.0',
},
devDependencies: {
'@pnpm.e2e/foo': '',
'@pnpm.e2e/peer-c': '',
},
})
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
})
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: true,
}, ['*'])
const lockfile = project.readLockfile()
expect(lockfile.packages['@pnpm.e2e/peer-a@1.0.1']).toBeTruthy()
expect(lockfile.packages['@pnpm.e2e/peer-c@2.0.0']).toBeTruthy()
expect(lockfile.packages['@pnpm.e2e/foo@2.0.0']).toBeTruthy()
expect(lockfile.importers['.'].dependencies?.['@pnpm.e2e/peer-a'].version).toBe('1.0.1')
expect(lockfile.importers['.'].devDependencies?.['@pnpm.e2e/foo'].version).toBe('2.0.0')
expect(lockfile.importers['.'].devDependencies?.['@pnpm.e2e/peer-c'].version).toBe('2.0.0')
})
test('ignore packages in package.json > updateConfig.ignoreDependencies fields in update command', async () => {
await addDistTag({ package: '@pnpm.e2e/foo', version: '100.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/bar', version: '100.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/qar', version: '100.0.0', distTag: 'latest' })
const project = prepare({
dependencies: {
'@pnpm.e2e/foo': '100.0.0',
'@pnpm.e2e/bar': '100.0.0',
'@pnpm.e2e/qar': '100.0.0',
},
})
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
})
const lockfile = project.readLockfile()
expect(lockfile.packages['@pnpm.e2e/foo@100.0.0']).toBeTruthy()
expect(lockfile.packages['@pnpm.e2e/bar@100.0.0']).toBeTruthy()
expect(lockfile.packages['@pnpm.e2e/qar@100.0.0']).toBeTruthy()
await addDistTag({ package: '@pnpm.e2e/foo', version: '100.1.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/bar', version: '100.1.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/qar', version: '100.1.0', distTag: 'latest' })
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: true,
updateConfig: {
ignoreDependencies: [
'@pnpm.e2e/foo',
'@pnpm.e2e/bar',
],
},
})
const lockfileUpdated = project.readLockfile()
expect(lockfileUpdated.packages['@pnpm.e2e/foo@100.0.0']).toBeTruthy()
expect(lockfileUpdated.packages['@pnpm.e2e/bar@100.0.0']).toBeTruthy()
expect(lockfileUpdated.packages['@pnpm.e2e/qar@100.1.0']).toBeTruthy()
})
test('not ignore packages if these are specified in parameter even if these are listed in package.json > pnpm.update.ignoreDependencies fields in update command', async () => {
await addDistTag({ package: '@pnpm.e2e/foo', version: '100.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/bar', version: '100.0.0', distTag: 'latest' })
const project = prepare({
dependencies: {
'@pnpm.e2e/foo': '100.0.0',
'@pnpm.e2e/bar': '100.0.0',
},
})
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
})
const lockfile = project.readLockfile()
expect(lockfile.packages['@pnpm.e2e/foo@100.0.0']).toBeTruthy()
expect(lockfile.packages['@pnpm.e2e/bar@100.0.0']).toBeTruthy()
await addDistTag({ package: '@pnpm.e2e/foo', version: '100.1.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/bar', version: '100.1.0', distTag: 'latest' })
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
updateConfig: {
ignoreDependencies: [
'@pnpm.e2e/foo',
],
},
}, ['@pnpm.e2e/foo@latest', '@pnpm.e2e/bar@latest'])
const lockfileUpdated = project.readLockfile()
expect(lockfileUpdated.packages['@pnpm.e2e/foo@100.1.0']).toBeTruthy()
expect(lockfileUpdated.packages['@pnpm.e2e/bar@100.1.0']).toBeTruthy()
})
test('do not update anything if all the dependencies are ignored and trying to update to latest', async () => {
await addDistTag({ package: '@pnpm.e2e/foo', version: '100.1.0', distTag: 'latest' })
const project = prepare({
dependencies: {
'@pnpm.e2e/foo': '100.0.0',
},
})
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
})
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: true,
updateConfig: {
ignoreDependencies: [
'@pnpm.e2e/foo',
],
},
}, [])
const lockfileUpdated = project.readLockfile()
expect(lockfileUpdated.packages['@pnpm.e2e/foo@100.0.0']).toBeTruthy()
})
test('should not update tag version when --latest not set', async () => {
await addDistTag({ package: '@pnpm.e2e/peer-a', version: '1.0.1', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/peer-c', version: '2.0.0', distTag: 'canary' })
await addDistTag({ package: '@pnpm.e2e/foo', version: '2.0.0', distTag: 'latest' })
prepare({
dependencies: {
'@pnpm.e2e/peer-a': 'latest',
'@pnpm.e2e/peer-c': 'canary',
'@pnpm.e2e/foo': '1.0.0',
},
})
await install.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
})
await update.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
latest: false,
})
const manifest = loadJsonFileSync<ProjectManifest>('package.json')
expect(manifest.dependencies?.['@pnpm.e2e/peer-a']).toBe('latest')
expect(manifest.dependencies?.['@pnpm.e2e/peer-c']).toBe('canary')
expect(manifest.dependencies?.['@pnpm.e2e/foo']).toBe('1.0.0')
})
Reference in New Issue View Git Blame Copy Permalink