Files
pnpm/cache/commands/test/cacheView.cmd.test.ts
Zoltan Kochan 187049055f chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2 (#11332)
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2

- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
  20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
  `it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
  instead of relying on `@types/jest` ambient declarations. Under the
  new tsgo build, `import { jest } from '@jest/globals'` shadows the
  ambient `jest` namespace, breaking `@types/jest`'s `declare var
  describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
  now import from it, and add `@types/node` to packages that need it
  but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
  no longer globally available.

* chore: fix remaining tsgo type-strictness errors

- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
  toStrictEqual / toEqual; @jest/globals rejects the typed objects
  (which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
  for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
  return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
  expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
  for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
  that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
  two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.

* chore: address Copilot review on #11332

- Move misplaced `@jest/globals` imports to the top import block in
  checkEngine, run.ts, and workspace/root-finder tests where the
  script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
  in bins/linker, lockfile/fs, and resolving/local-resolver tests with
  `await expect(x()).rejects.toMatchObject({...})`. The old pattern
  swallowed an unrelated `throw` if the under-test call silently
  succeeded, which would fail on the catch-block assertion with a
  misleading message.
2026-04-21 22:50:40 +02:00

118 lines
3.1 KiB
TypeScript

import path from 'node:path'
import { beforeEach, describe, expect, test } from '@jest/globals'
import { cache } from '@pnpm/cache.commands'
import { prepare } from '@pnpm/prepare'
import { REGISTRY_MOCK_PORT } from '@pnpm/registry-mock'
import { rimrafSync } from '@zkochan/rimraf'
import { safeExeca as execa } from 'execa'
const pnpmBin = path.join(import.meta.dirname, '../../../pnpm/bin/pnpm.mjs')
const REGISTRY = `http://localhost:${REGISTRY_MOCK_PORT}/`
describe('cache view', () => {
let cacheDir: string
let storeDir: string
beforeEach(async () => {
prepare()
cacheDir = path.resolve('cache')
storeDir = path.resolve('store')
await execa('node', [
pnpmBin,
'add',
'is-negative@2.1.0',
`--store-dir=${storeDir}`,
`--cache-dir=${cacheDir}`,
'--config.resolution-mode=highest',
`--registry=${REGISTRY}`,
])
rimrafSync('node_modules')
rimrafSync('pnpm-lock.yaml')
await execa('node', [
pnpmBin,
'add',
'is-negative@2.1.0',
`--store-dir=${storeDir}`,
`--cache-dir=${cacheDir}`,
'--config.resolution-mode=highest',
])
})
test('lists all metadata for requested package', async () => {
const result = await cache.handler({
cacheDir,
cliOptions: {},
pnpmHomeDir: process.cwd(),
storeDir,
}, ['view', 'is-negative'])
expect(JSON.parse(result!)).toMatchObject({
[`localhost:${REGISTRY_MOCK_PORT}`]: {
cachedVersions: ['2.1.0'],
nonCachedVersions: [
'1.0.0',
'1.0.1',
'2.0.0',
'2.0.1',
'2.0.2',
],
},
'registry.npmjs.org': {
cachedVersions: ['2.1.0'],
nonCachedVersions: [
'1.0.0',
'1.0.1',
'2.0.0',
'2.0.1',
'2.0.2',
],
},
})
})
test('lists metadata for requested package from specified registry', async () => {
const result = await cache.handler({
cacheDir,
cliOptions: {
registry: 'https://registry.npmjs.org/',
},
pnpmHomeDir: process.cwd(),
storeDir,
}, ['view', 'is-negative'])
expect(JSON.parse(result!)).toMatchObject({
'registry.npmjs.org': {
cachedVersions: ['2.1.0'],
nonCachedVersions: [
'1.0.0',
'1.0.1',
'2.0.0',
'2.0.1',
'2.0.2',
],
},
})
})
test('lists all metadata for requested package should specify a package name', async () => {
await expect(
cache.handler({
cacheDir,
cliOptions: {},
pnpmHomeDir: process.cwd(),
storeDir,
}, ['view'])
).rejects.toThrow('`pnpm cache view` requires the package name')
})
test('lists all metadata for requested package should not accept more than one package name', async () => {
await expect(
cache.handler({
cacheDir,
cliOptions: {},
pnpmHomeDir: process.cwd(),
storeDir,
}, ['view', 'is-negative', 'is-positive'])
).rejects.toThrow('`pnpm cache view` only accepts one package name')
})
})