mirror of
https://github.com/pnpm/pnpm.git
synced 2026-06-28 09:55:39 -04:00
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
162 lines
4.7 KiB
TypeScript
162 lines
4.7 KiB
TypeScript
import fs from 'node:fs'
|
|
import path from 'node:path'
|
|
import util from 'node:util'
|
|
|
|
import { expect, test } from '@jest/globals'
|
|
import { WANTED_LOCKFILE } from '@pnpm/constants'
|
|
import type { PnpmError } from '@pnpm/error'
|
|
import { addDependenciesToPackage, install } from '@pnpm/installing.deps-installer'
|
|
import { prepareEmpty, preparePackages } from '@pnpm/prepare'
|
|
import { rimrafSync } from '@zkochan/rimraf'
|
|
import { isCI } from 'ci-info'
|
|
|
|
import { testDefaults } from './utils/index.js'
|
|
|
|
test('fail on non-compatible node_modules', async () => {
|
|
prepareEmpty()
|
|
const opts = testDefaults()
|
|
|
|
await saveModulesYaml('0.50.0', opts.storeDir)
|
|
|
|
try {
|
|
await addDependenciesToPackage({}, ['is-negative'], opts)
|
|
throw new Error('should have failed')
|
|
} catch (err: any) { // eslint-disable-line
|
|
expect(err.code).toBe('ERR_PNPM_MODULES_BREAKING_CHANGE')
|
|
}
|
|
})
|
|
|
|
test("don't fail on non-compatible node_modules when forced", async () => {
|
|
prepareEmpty()
|
|
const opts = testDefaults({ force: true })
|
|
|
|
await saveModulesYaml('0.50.0', opts.storeDir)
|
|
|
|
await install({}, opts)
|
|
})
|
|
|
|
test("don't fail on non-compatible node_modules when forced in a workspace", async () => {
|
|
preparePackages([
|
|
{
|
|
location: 'pkg',
|
|
package: {},
|
|
},
|
|
])
|
|
const opts = testDefaults({ force: true })
|
|
|
|
process.chdir('pkg')
|
|
const { updatedManifest: manifest } = await addDependenciesToPackage({}, ['is-positive@1.0.0'], testDefaults({ lockfileDir: path.resolve('..') }))
|
|
rimrafSync('node_modules')
|
|
|
|
process.chdir('..')
|
|
|
|
fs.writeFileSync('node_modules/.modules.yaml', `packageManager: pnpm@${3}\nstore: ${opts.storeDir}\nlayoutVersion: 1`)
|
|
|
|
await install(manifest, { ...opts, dir: path.resolve('pkg'), lockfileDir: process.cwd() })
|
|
})
|
|
|
|
test('do not fail on non-compatible node_modules when forced with a named installation', async () => {
|
|
prepareEmpty()
|
|
const opts = testDefaults()
|
|
|
|
await saveModulesYaml('0.50.0', opts.storeDir)
|
|
|
|
let err!: PnpmError
|
|
try {
|
|
await addDependenciesToPackage({}, ['is-negative'], opts)
|
|
} catch (_err: any) { // eslint-disable-line
|
|
err = _err
|
|
}
|
|
expect(err.code).toBe('ERR_PNPM_MODULES_BREAKING_CHANGE')
|
|
|
|
await install({}, {
|
|
...opts,
|
|
confirmModulesPurge: false,
|
|
})
|
|
})
|
|
|
|
test("don't fail on non-compatible store when forced", async () => {
|
|
prepareEmpty()
|
|
const opts = testDefaults({ force: true })
|
|
|
|
await saveModulesYaml('0.32.0', opts.storeDir)
|
|
|
|
await install({}, opts)
|
|
})
|
|
|
|
test('do not fail on non-compatible store when forced during named installation', async () => {
|
|
prepareEmpty()
|
|
const opts = testDefaults()
|
|
|
|
await saveModulesYaml('0.32.0', opts.storeDir)
|
|
|
|
let err!: PnpmError
|
|
try {
|
|
await addDependenciesToPackage({}, ['is-negative'], opts)
|
|
} catch (_err: any) { // eslint-disable-line
|
|
err = _err
|
|
}
|
|
expect(err.code).toBe('ERR_PNPM_MODULES_BREAKING_CHANGE')
|
|
|
|
await install({}, {
|
|
...opts,
|
|
confirmModulesPurge: false,
|
|
})
|
|
})
|
|
|
|
test('fail fast with actionable hint on non-TTY when modules purge needs confirmation', async () => {
|
|
prepareEmpty()
|
|
const opts = testDefaults()
|
|
|
|
await saveModulesYaml('0.50.0', opts.storeDir)
|
|
|
|
const originalIsTTY = process.stdin.isTTY
|
|
Object.defineProperty(process.stdin, 'isTTY', { value: false, configurable: true })
|
|
|
|
let err: unknown
|
|
try {
|
|
await install({}, opts)
|
|
} catch (_err: unknown) {
|
|
err = _err
|
|
} finally {
|
|
Object.defineProperty(process.stdin, 'isTTY', { value: originalIsTTY, configurable: true })
|
|
}
|
|
|
|
expect(util.types.isNativeError(err)).toBeTruthy()
|
|
if (util.types.isNativeError(err)) {
|
|
expect('code' in err && err.code).toBe('ERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTY')
|
|
expect(err.message).toContain('no TTY')
|
|
expect('hint' in err && typeof err.hint === 'string' && err.hint).toContain('confirmModulesPurge')
|
|
}
|
|
})
|
|
|
|
async function saveModulesYaml (pnpmVersion: string, storeDir: string) {
|
|
fs.mkdirSync('node_modules')
|
|
fs.writeFileSync('node_modules/.modules.yaml', `packageManager: pnpm@${pnpmVersion}\nstoreDir: ${storeDir}`)
|
|
}
|
|
|
|
test(`fail on non-compatible ${WANTED_LOCKFILE} when frozen lockfile installation is used`, async () => {
|
|
if (isCI) {
|
|
console.log('this test will always fail on CI servers')
|
|
return
|
|
}
|
|
|
|
prepareEmpty()
|
|
fs.writeFileSync(WANTED_LOCKFILE, '')
|
|
|
|
try {
|
|
await addDependenciesToPackage({}, ['is-negative'], testDefaults({ frozenLockfile: true }))
|
|
throw new Error('should have failed')
|
|
} catch (err: any) { // eslint-disable-line
|
|
if (err.message === 'should have failed') throw err
|
|
expect(err.code).toBe('ERR_PNPM_BROKEN_LOCKFILE')
|
|
}
|
|
})
|
|
|
|
test(`don't fail on non-compatible ${WANTED_LOCKFILE} when forced`, async () => {
|
|
prepareEmpty()
|
|
fs.writeFileSync(WANTED_LOCKFILE, '')
|
|
|
|
await addDependenciesToPackage({}, ['is-negative'], testDefaults({ force: true }))
|
|
})
|