mirror of
https://github.com/pnpm/pnpm.git
synced 2026-04-26 18:09:06 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
83 lines
1.9 KiB
TypeScript
83 lines
1.9 KiB
TypeScript
import { expect, test } from '@jest/globals'
|
|
|
|
import { getNodeArtifactAddress } from '../lib/getNodeArtifactAddress.js'
|
|
|
|
test.each([
|
|
[
|
|
'16.0.0',
|
|
'https://nodejs.org/download/release/',
|
|
'win32',
|
|
'ia32',
|
|
{
|
|
basename: 'node-v16.0.0-win-x86',
|
|
dirname: 'https://nodejs.org/download/release/v16.0.0',
|
|
extname: '.zip',
|
|
},
|
|
],
|
|
[
|
|
'16.0.0',
|
|
'https://nodejs.org/download/release/',
|
|
'linux',
|
|
'arm',
|
|
{
|
|
basename: 'node-v16.0.0-linux-armv7l',
|
|
dirname: 'https://nodejs.org/download/release/v16.0.0',
|
|
extname: '.tar.gz',
|
|
},
|
|
],
|
|
[
|
|
'16.0.0',
|
|
'https://nodejs.org/download/release/',
|
|
'linux',
|
|
'x64',
|
|
{
|
|
basename: 'node-v16.0.0-linux-x64',
|
|
dirname: 'https://nodejs.org/download/release/v16.0.0',
|
|
extname: '.tar.gz',
|
|
},
|
|
],
|
|
[
|
|
'15.14.0',
|
|
'https://nodejs.org/download/release/',
|
|
'darwin',
|
|
'arm64',
|
|
{
|
|
basename: 'node-v15.14.0-darwin-x64',
|
|
dirname: 'https://nodejs.org/download/release/v15.14.0',
|
|
extname: '.tar.gz',
|
|
},
|
|
],
|
|
[
|
|
'16.0.0',
|
|
'https://nodejs.org/download/release/',
|
|
'darwin',
|
|
'arm64',
|
|
{
|
|
basename: 'node-v16.0.0-darwin-arm64',
|
|
dirname: 'https://nodejs.org/download/release/v16.0.0',
|
|
extname: '.tar.gz',
|
|
},
|
|
],
|
|
])('getNodeArtifactAddress', (version, nodeMirrorBaseUrl, platform, arch, tarball) => {
|
|
expect(getNodeArtifactAddress({
|
|
version,
|
|
baseUrl: nodeMirrorBaseUrl,
|
|
platform,
|
|
arch,
|
|
})).toStrictEqual(tarball)
|
|
})
|
|
|
|
test('getNodeArtifactAddress with libc=musl appends -musl suffix to arch', () => {
|
|
expect(getNodeArtifactAddress({
|
|
version: '22.0.0',
|
|
baseUrl: 'https://unofficial-builds.nodejs.org/download/release/',
|
|
platform: 'linux',
|
|
arch: 'x64',
|
|
libc: 'musl',
|
|
})).toStrictEqual({
|
|
basename: 'node-v22.0.0-linux-x64-musl',
|
|
dirname: 'https://unofficial-builds.nodejs.org/download/release/v22.0.0',
|
|
extname: '.tar.gz',
|
|
})
|
|
})
|