mirror of
https://github.com/pnpm/pnpm.git
synced 2026-04-26 18:09:06 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
49 lines
1.8 KiB
TypeScript
49 lines
1.8 KiB
TypeScript
import { expect, test } from '@jest/globals'
|
|
|
|
import { parseNodeSpecifier } from '../lib/parseNodeSpecifier.js'
|
|
|
|
test.each([
|
|
// Semver ranges → release channel
|
|
['6', '6', 'release'],
|
|
['16.0', '16.0', 'release'],
|
|
// Exact prerelease with rc channel
|
|
['16.0.0-rc.0', '16.0.0-rc.0', 'rc'],
|
|
// Channel/range combo (major only)
|
|
['rc/10', '10', 'rc'],
|
|
// Standalone channel name → latest from that channel
|
|
['nightly', 'latest', 'nightly'],
|
|
['rc', 'latest', 'rc'],
|
|
['test', 'latest', 'test'],
|
|
['v8-canary', 'latest', 'v8-canary'],
|
|
['release', 'latest', 'release'],
|
|
// Well-known aliases
|
|
['lts', 'lts', 'release'],
|
|
['latest', 'latest', 'release'],
|
|
// LTS codenames
|
|
['argon', 'argon', 'release'],
|
|
['iron', 'iron', 'release'],
|
|
// Exact stable version
|
|
['22.0.0', '22.0.0', 'release'],
|
|
// Stable release with explicit channel prefix, aliases, and semver ranges
|
|
['release/22.0.0', '22.0.0', 'release'],
|
|
['release/latest', 'latest', 'release'],
|
|
['release/lts', 'lts', 'release'],
|
|
['release/18', '18', 'release'],
|
|
// Channel/version combos
|
|
['rc/18', '18', 'rc'],
|
|
['rc/18.0.0-rc.4', '18.0.0-rc.4', 'rc'],
|
|
['nightly/latest', 'latest', 'nightly'],
|
|
// Exact nightly version
|
|
['24.0.0-nightly20250315d765e70802', '24.0.0-nightly20250315d765e70802', 'nightly'],
|
|
// Exact v8-canary version
|
|
['22.0.0-v8-canary20250101abc', '22.0.0-v8-canary20250101abc', 'v8-canary'],
|
|
])('Node.js version specifier is parsed: %s', (specifier, expectedVersionSpecifier, expectedReleaseChannel) => {
|
|
const result = parseNodeSpecifier(specifier)
|
|
expect(result.versionSpecifier).toBe(expectedVersionSpecifier)
|
|
expect(result.releaseChannel).toBe(expectedReleaseChannel)
|
|
})
|
|
|
|
test('throws for unknown release channel', () => {
|
|
expect(() => parseNodeSpecifier('foo/18')).toThrow('"foo" is not a valid Node.js release channel')
|
|
})
|