Files
pnpm/exec/commands/test/testRecursive.ts
Zoltan Kochan 187049055f chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2 (#11332)
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2

- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
  20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
  `it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
  instead of relying on `@types/jest` ambient declarations. Under the
  new tsgo build, `import { jest } from '@jest/globals'` shadows the
  ambient `jest` namespace, breaking `@types/jest`'s `declare var
  describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
  now import from it, and add `@types/node` to packages that need it
  but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
  no longer globally available.

* chore: fix remaining tsgo type-strictness errors

- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
  toStrictEqual / toEqual; @jest/globals rejects the typed objects
  (which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
  for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
  return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
  expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
  for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
  that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
  two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.

* chore: address Copilot review on #11332

- Move misplaced `@jest/globals` imports to the top import block in
  checkEngine, run.ts, and workspace/root-finder tests where the
  script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
  in bins/linker, lockfile/fs, and resolving/local-resolver tests with
  `await expect(x()).rejects.toMatchObject({...})`. The old pattern
  swallowed an unrelated `throw` if the under-test call silently
  succeeded, which would fail on the catch-block assertion with a
  misleading message.
2026-04-21 22:50:40 +02:00

183 lines
4.0 KiB
TypeScript

import path from 'node:path'
import { expect, test } from '@jest/globals'
import { run } from '@pnpm/exec.commands'
import { preparePackages } from '@pnpm/prepare'
import { createTestIpcServer } from '@pnpm/test-ipc-server'
import { filterProjectsBySelectorObjectsFromDir } from '@pnpm/workspace.projects-filter'
import { filterProjectsBySelectorObjects } from '@pnpm/workspace.projects-filter'
import { safeExeca as execa } from 'execa'
import { DEFAULT_OPTS, REGISTRY_URL } from './utils/index.js'
const pnpmBin = path.join(import.meta.dirname, '../../../pnpm/bin/pnpm.mjs')
test('pnpm recursive test', async () => {
await using server1 = await createTestIpcServer()
await using server2 = await createTestIpcServer()
preparePackages([
{
name: 'project-1',
version: '1.0.0',
scripts: {
test: `${server1.sendLineScript('project-1')} && ${server2.sendLineScript('project-1')}`,
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
test: server1.sendLineScript('project-2'),
},
},
{
name: 'project-3',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
test: server2.sendLineScript('project-3'),
},
},
{
name: 'project-0',
version: '1.0.0',
dependencies: {},
},
])
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
await execa('node', [
pnpmBin,
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
await run.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
}, ['test'])
expect(server1.getLines()).toStrictEqual(['project-1', 'project-2'])
expect(server2.getLines()).toStrictEqual(['project-1', 'project-3'])
})
test('`pnpm recursive test` does not fail if none of the packages has a test command', async () => {
preparePackages([
{
name: 'project-1',
version: '1.0.0',
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
},
{
name: 'project-3',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
},
{
name: 'project-0',
version: '1.0.0',
dependencies: {},
},
])
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
await execa('node', [
pnpmBin,
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
await run.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
}, ['test'])
})
test('pnpm recursive test with filtering', async () => {
await using server = await createTestIpcServer()
preparePackages([
{
name: 'project-1',
version: '1.0.0',
scripts: {
test: server.sendLineScript('project-1'),
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'project-1': '1',
},
scripts: {
test: server.sendLineScript('project-2'),
},
},
])
const { allProjects } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
const { selectedProjectsGraph } = await filterProjectsBySelectorObjects(
allProjects,
[{ namePattern: 'project-1' }],
{ workspaceDir: process.cwd() }
)
await execa('node', [
pnpmBin,
'install',
'-r',
'--registry',
REGISTRY_URL,
'--store-dir',
path.resolve(DEFAULT_OPTS.storeDir),
])
await run.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
}, ['test'])
expect(server.getLines()).toStrictEqual(['project-1'])
})