mirror of
https://github.com/pnpm/pnpm.git
synced 2026-04-27 10:30:58 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
41 lines
1.6 KiB
TypeScript
41 lines
1.6 KiB
TypeScript
import path from 'node:path'
|
|
|
|
import { expect, test } from '@jest/globals'
|
|
|
|
import { getEditDirPath } from '../src/getEditDirPath.js'
|
|
|
|
test('getEditDirPath() returns path to pkg@version inside node_modules/.pnpm_patches', () => {
|
|
expect(getEditDirPath('pkg', {
|
|
alias: 'pkg',
|
|
bareSpecifier: '0.1.2',
|
|
}, { modulesDir: 'node_modules' })).toBe(path.join('node_modules', '.pnpm_patches', 'pkg@0.1.2'))
|
|
})
|
|
|
|
test('getEditDirPath() returns path to pkg@version inside .pnpm_patches inside specified modules dir', () => {
|
|
expect(getEditDirPath('pkg', {
|
|
alias: 'pkg',
|
|
bareSpecifier: '0.1.2',
|
|
}, {
|
|
modulesDir: 'user-defined-modules-dir',
|
|
})).toBe(path.join('user-defined-modules-dir', '.pnpm_patches', 'pkg@0.1.2'))
|
|
})
|
|
|
|
test('getEditDirPath() returns valid path even if bareSpecifier contains special characters', () => {
|
|
expect(getEditDirPath('pkg', {
|
|
alias: 'pkg',
|
|
bareSpecifier: 'https://codeload.github.com/zkochan/hi/tar.gz',
|
|
}, { modulesDir: 'node_modules' })).toBe(path.join('node_modules', '.pnpm_patches', 'pkg@https+codeload.github.com+zkochan+hi+tar.gz'))
|
|
})
|
|
|
|
test('getEditDirPath() returns path with name of alias if bareSpecifier is not available', () => {
|
|
expect(getEditDirPath('pkg', {
|
|
alias: 'resolved-pkg',
|
|
}, { modulesDir: 'node_modules' })).toBe(path.join('node_modules', '.pnpm_patches', 'resolved-pkg'))
|
|
})
|
|
|
|
test('getEditDirPath() returns path with name of param if alias is not available', () => {
|
|
expect(getEditDirPath('pkg', {
|
|
bareSpecifier: '0.1.2',
|
|
}, { modulesDir: 'node_modules' })).toBe(path.join('node_modules', '.pnpm_patches', 'pkg'))
|
|
})
|