Files
pnpm/pkg-manager/core/test/breakingChanges.ts
Zoltan Kochan 2f3a745795 fix(core): improve no-TTY modules purge hint (#10973)
Cherry-picked from main (672e58c285).
2026-03-24 15:52:50 +01:00

159 lines
4.7 KiB
TypeScript

import fs from 'fs'
import path from 'path'
import util from 'util'
import { WANTED_LOCKFILE } from '@pnpm/constants'
import { type PnpmError } from '@pnpm/error'
import { prepareEmpty, preparePackages } from '@pnpm/prepare'
import { addDependenciesToPackage, install } from '@pnpm/core'
import { sync as rimraf } from '@zkochan/rimraf'
import { isCI } from 'ci-info'
import { testDefaults } from './utils/index.js'
test('fail on non-compatible node_modules', async () => {
prepareEmpty()
const opts = testDefaults()
await saveModulesYaml('0.50.0', opts.storeDir)
try {
await addDependenciesToPackage({}, ['is-negative'], opts)
throw new Error('should have failed')
} catch (err: any) { // eslint-disable-line
expect(err.code).toBe('ERR_PNPM_MODULES_BREAKING_CHANGE')
}
})
test("don't fail on non-compatible node_modules when forced", async () => {
prepareEmpty()
const opts = testDefaults({ force: true })
await saveModulesYaml('0.50.0', opts.storeDir)
await install({}, opts)
})
test("don't fail on non-compatible node_modules when forced in a workspace", async () => {
preparePackages([
{
location: 'pkg',
package: {},
},
])
const opts = testDefaults({ force: true })
process.chdir('pkg')
const { updatedManifest: manifest } = await addDependenciesToPackage({}, ['is-positive@1.0.0'], testDefaults({ lockfileDir: path.resolve('..') }))
rimraf('node_modules')
process.chdir('..')
fs.writeFileSync('node_modules/.modules.yaml', `packageManager: pnpm@${3}\nstore: ${opts.storeDir}\nlayoutVersion: 1`)
await install(manifest, { ...opts, dir: path.resolve('pkg'), lockfileDir: process.cwd() })
})
test('do not fail on non-compatible node_modules when forced with a named installation', async () => {
prepareEmpty()
const opts = testDefaults()
await saveModulesYaml('0.50.0', opts.storeDir)
let err!: PnpmError
try {
await addDependenciesToPackage({}, ['is-negative'], opts)
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_MODULES_BREAKING_CHANGE')
await install({}, {
...opts,
confirmModulesPurge: false,
})
})
test("don't fail on non-compatible store when forced", async () => {
prepareEmpty()
const opts = testDefaults({ force: true })
await saveModulesYaml('0.32.0', opts.storeDir)
await install({}, opts)
})
test('do not fail on non-compatible store when forced during named installation', async () => {
prepareEmpty()
const opts = testDefaults()
await saveModulesYaml('0.32.0', opts.storeDir)
let err!: PnpmError
try {
await addDependenciesToPackage({}, ['is-negative'], opts)
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_MODULES_BREAKING_CHANGE')
await install({}, {
...opts,
confirmModulesPurge: false,
})
})
test('fail fast with actionable hint on non-TTY when modules purge needs confirmation', async () => {
prepareEmpty()
const opts = testDefaults()
await saveModulesYaml('0.50.0', opts.storeDir)
const originalIsTTY = process.stdin.isTTY
Object.defineProperty(process.stdin, 'isTTY', { value: false, configurable: true })
let err: unknown
try {
await install({}, opts)
} catch (_err: unknown) {
err = _err
} finally {
Object.defineProperty(process.stdin, 'isTTY', { value: originalIsTTY, configurable: true })
}
expect(util.types.isNativeError(err)).toBeTruthy()
if (util.types.isNativeError(err)) {
expect('code' in err && err.code).toBe('ERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTY')
expect(err.message).toContain('no TTY')
expect('hint' in err && typeof err.hint === 'string' && err.hint).toContain('confirmModulesPurge')
}
})
async function saveModulesYaml (pnpmVersion: string, storeDir: string) {
fs.mkdirSync('node_modules')
fs.writeFileSync('node_modules/.modules.yaml', `packageManager: pnpm@${pnpmVersion}\nstoreDir: ${storeDir}`)
}
test(`fail on non-compatible ${WANTED_LOCKFILE} when frozen lockfile installation is used`, async () => {
if (isCI) {
console.log('this test will always fail on CI servers')
return
}
prepareEmpty()
fs.writeFileSync(WANTED_LOCKFILE, '')
try {
await addDependenciesToPackage({}, ['is-negative'], testDefaults({ frozenLockfile: true }))
throw new Error('should have failed')
} catch (err: any) { // eslint-disable-line
if (err.message === 'should have failed') throw err
expect(err.code).toBe('ERR_PNPM_BROKEN_LOCKFILE')
}
})
test(`don't fail on non-compatible ${WANTED_LOCKFILE} when forced`, async () => {
prepareEmpty()
fs.writeFileSync(WANTED_LOCKFILE, '')
await addDependenciesToPackage({}, ['is-negative'], testDefaults({ force: true }))
})