mirror of
https://github.com/pnpm/pnpm.git
synced 2026-04-10 18:18:56 -04:00
Major cleanup of the config system after migrating settings from `.npmrc` to `pnpm-workspace.yaml`.
### Config reader simplification
- Remove `checkUnknownSetting` (dead code, always `false`)
- Trim `npmConfigTypes` from ~127 to ~67 keys (remove unused npm config keys)
- Replace `rcOptions` iteration over all type keys with direct construction from defaults + auth overlay
- Remove `rcOptionsTypes` parameter from `getConfig()` and its assembly chain
### Rename `rawConfig` to `authConfig`
- `rawConfig` was a confusing mix of auth data and general settings
- Non-auth settings are already on the typed `Config` object — stop duplicating them in `rawConfig`
- Rename `rawConfig` → `authConfig` across the codebase to clarify it only contains auth/registry data from `.npmrc`
### Remove `rawConfig` from non-auth consumers
- **Lifecycle hooks**: replace `rawConfig: object` with `userAgent?: string` — only user-agent was read
- **Fetchers**: remove unused `rawConfig` from git fetcher, binary fetcher, tarball fetcher, prepare-package
- **Update command**: use `opts.production/dev/optional` instead of `rawConfig.*`
- **`pnpm init`**: accept typed init properties instead of parsing `rawConfig`
### Add `nodeDownloadMirrors` setting
- New `nodeDownloadMirrors?: Record<string, string>` on `PnpmSettings` and `Config`
- Replaces the `node-mirror:<channel>` pattern that was stored in `rawConfig`
- Configured in `pnpm-workspace.yaml`:
```yaml
nodeDownloadMirrors:
release: https://my-mirror.example.com/download/release/
```
- Remove unused `rawConfig` from deno-resolver and bun-resolver
### Refactor `pnpm config get/list`
- New `configToRecord()` builds display data from typed Config properties on the fly
- Excludes sensitive internals (`authInfos`, `sslConfigs`, etc.)
- Non-types keys (e.g., `package-extensions`) resolve through `configToRecord` instead of direct property access
- Delete `processConfig.ts` (replaced by `configToRecord.ts`)
### Pre-push hook improvement
- Add `compile-only` (`tsgo --build`) to pre-push hook to catch type errors before push
310 lines
10 KiB
TypeScript
310 lines
10 KiB
TypeScript
import assert from 'node:assert'
|
|
import fs from 'node:fs/promises'
|
|
import path from 'node:path'
|
|
import util from 'node:util'
|
|
|
|
import { linkBins, linkBinsOfPackages } from '@pnpm/bins.linker'
|
|
import { getWorkspaceConcurrency } from '@pnpm/config.reader'
|
|
import { skippedOptionalDependencyLogger } from '@pnpm/core-loggers'
|
|
import { calcDepState, type DepsStateCache } from '@pnpm/deps.graph-hasher'
|
|
import { PnpmError } from '@pnpm/error'
|
|
import { runPostinstallHooks } from '@pnpm/exec.lifecycle'
|
|
import { logger } from '@pnpm/logger'
|
|
import { applyPatchToDir } from '@pnpm/patching.apply-patch'
|
|
import { safeReadPackageJsonFromDir } from '@pnpm/pkg-manifest.reader'
|
|
import type { StoreController } from '@pnpm/store.controller-types'
|
|
import type {
|
|
AllowBuild,
|
|
DependencyManifest,
|
|
DepPath,
|
|
IgnoredBuilds,
|
|
} from '@pnpm/types'
|
|
import { hardLinkDir } from '@pnpm/worker'
|
|
import pDefer, { type DeferredPromise } from 'p-defer'
|
|
import { pickBy } from 'ramda'
|
|
import { runGroups } from 'run-groups'
|
|
|
|
import { buildSequence, type DependenciesGraph, type DependenciesGraphNode } from './buildSequence.js'
|
|
|
|
export type { DepsStateCache }
|
|
|
|
export async function buildModules<T extends string> (
|
|
depGraph: DependenciesGraph<T>,
|
|
rootDepPaths: T[],
|
|
opts: {
|
|
allowBuild?: AllowBuild
|
|
childConcurrency?: number
|
|
depsToBuild?: Set<string>
|
|
depsStateCache: DepsStateCache
|
|
extraBinPaths?: string[]
|
|
extraNodePaths?: string[]
|
|
extraEnv?: Record<string, string>
|
|
ignoreScripts?: boolean
|
|
lockfileDir: string
|
|
optional: boolean
|
|
preferSymlinkedExecutables?: boolean
|
|
unsafePerm: boolean
|
|
userAgent: string
|
|
scriptsPrependNodePath?: boolean | 'warn-only'
|
|
scriptShell?: string
|
|
shellEmulator?: boolean
|
|
sideEffectsCacheWrite: boolean
|
|
storeController: StoreController
|
|
rootModulesDir: string
|
|
hoistedLocations?: Record<string, string[]>
|
|
enableGlobalVirtualStore?: boolean
|
|
}
|
|
): Promise<{ ignoredBuilds?: IgnoredBuilds }> {
|
|
if (!rootDepPaths.length) return {}
|
|
const warn = (message: string) => {
|
|
logger.warn({ message, prefix: opts.lockfileDir })
|
|
}
|
|
// postinstall hooks
|
|
|
|
const buildDepOpts = {
|
|
...opts,
|
|
builtHoistedDeps: opts.hoistedLocations ? {} : undefined,
|
|
warn,
|
|
}
|
|
const chunks = buildSequence<T>(depGraph, rootDepPaths)
|
|
if (!chunks.length) return {}
|
|
const ignoredBuilds = new Set<DepPath>()
|
|
const allowBuild = opts.allowBuild ?? (() => undefined)
|
|
const groups = chunks.map((chunk) => {
|
|
chunk = chunk.filter((depPath) => {
|
|
const node = depGraph[depPath]
|
|
return (node.requiresBuild || node.patch != null) && !node.isBuilt
|
|
})
|
|
if (opts.depsToBuild != null) {
|
|
chunk = chunk.filter((depPath) => opts.depsToBuild!.has(depPath))
|
|
}
|
|
|
|
return chunk.map((depPath) =>
|
|
() => {
|
|
let ignoreScripts = Boolean(buildDepOpts.ignoreScripts)
|
|
if (!ignoreScripts) {
|
|
const node = depGraph[depPath]
|
|
if (node.requiresBuild) {
|
|
const allowed = allowBuild(node.name, node.version)
|
|
switch (allowed) {
|
|
case false:
|
|
// Explicitly disallowed - don't report as ignored
|
|
ignoreScripts = true
|
|
break
|
|
case undefined:
|
|
// Not in allowlist - report as ignored
|
|
ignoredBuilds.add(node.depPath)
|
|
ignoreScripts = true
|
|
break
|
|
}
|
|
// allowed === true means build is permitted
|
|
}
|
|
}
|
|
return buildDependency(depPath, depGraph, {
|
|
...buildDepOpts,
|
|
ignoreScripts,
|
|
})
|
|
}
|
|
)
|
|
})
|
|
const patchErrors: Error[] = []
|
|
const groupsWithPatchErrors = groups.map((group) =>
|
|
group.map((task) => async () => {
|
|
try {
|
|
await task()
|
|
} catch (err: unknown) {
|
|
if (util.types.isNativeError(err) && 'code' in err && err.code === 'ERR_PNPM_PATCH_FAILED') {
|
|
patchErrors.push(err)
|
|
} else {
|
|
throw err
|
|
}
|
|
}
|
|
})
|
|
)
|
|
await runGroups(getWorkspaceConcurrency(opts.childConcurrency), groupsWithPatchErrors)
|
|
if (patchErrors.length > 0) {
|
|
throw patchErrors[0]
|
|
}
|
|
return { ignoredBuilds }
|
|
}
|
|
|
|
async function buildDependency<T extends string> (
|
|
depPath: T,
|
|
depGraph: DependenciesGraph<T>,
|
|
opts: {
|
|
extraBinPaths?: string[]
|
|
extraNodePaths?: string[]
|
|
extraEnv?: Record<string, string>
|
|
depsStateCache: DepsStateCache
|
|
ignoreScripts?: boolean
|
|
lockfileDir: string
|
|
optional: boolean
|
|
preferSymlinkedExecutables?: boolean
|
|
rootModulesDir: string
|
|
scriptsPrependNodePath?: boolean | 'warn-only'
|
|
scriptShell?: string
|
|
shellEmulator?: boolean
|
|
sideEffectsCacheWrite: boolean
|
|
storeController: StoreController
|
|
unsafePerm: boolean
|
|
userAgent?: string
|
|
hoistedLocations?: Record<string, string[]>
|
|
builtHoistedDeps?: Record<string, DeferredPromise<void>>
|
|
enableGlobalVirtualStore?: boolean
|
|
warn: (message: string) => void
|
|
}
|
|
): Promise<void> {
|
|
const depNode = depGraph[depPath]
|
|
if (!depNode.filesIndexFile) return
|
|
if (opts.builtHoistedDeps) {
|
|
if (opts.builtHoistedDeps[depNode.depPath]) {
|
|
await opts.builtHoistedDeps[depNode.depPath].promise
|
|
return
|
|
}
|
|
opts.builtHoistedDeps[depNode.depPath] = pDefer()
|
|
}
|
|
let buildSucceeded = false
|
|
try {
|
|
await linkBinsOfDependencies(depNode, depGraph, opts)
|
|
let isPatched = false
|
|
if (depNode.patch) {
|
|
if (!depNode.patch.patchFilePath) {
|
|
throw new PnpmError('PATCH_FILE_PATH_MISSING',
|
|
`Cannot apply patch for ${depPath}: patch file path is missing`,
|
|
{ hint: 'Ensure the package is listed in patchedDependencies configuration' }
|
|
)
|
|
}
|
|
isPatched = applyPatchToDir({ patchedDir: depNode.dir, patchFilePath: depNode.patch.patchFilePath })
|
|
}
|
|
const hasSideEffects = !opts.ignoreScripts && await runPostinstallHooks({
|
|
depPath,
|
|
extraBinPaths: opts.extraBinPaths,
|
|
extraEnv: opts.extraEnv,
|
|
initCwd: opts.lockfileDir,
|
|
optional: depNode.optional,
|
|
pkgRoot: depNode.dir,
|
|
rootModulesDir: opts.rootModulesDir,
|
|
scriptsPrependNodePath: opts.scriptsPrependNodePath,
|
|
scriptShell: opts.scriptShell,
|
|
shellEmulator: opts.shellEmulator,
|
|
unsafePerm: opts.unsafePerm || false,
|
|
userAgent: opts.userAgent,
|
|
})
|
|
// Remove the .pnpm-needs-build marker before uploading side effects,
|
|
// so it doesn't get cached as part of the package's side effects diff.
|
|
if (opts.enableGlobalVirtualStore) {
|
|
await fs.unlink(path.join(depNode.dir, '.pnpm-needs-build')).catch(() => {})
|
|
}
|
|
if ((isPatched || hasSideEffects) && opts.sideEffectsCacheWrite) {
|
|
try {
|
|
const sideEffectsCacheKey = calcDepState(depGraph, opts.depsStateCache, depPath, {
|
|
patchFileHash: depNode.patch?.hash,
|
|
includeDepGraphHash: hasSideEffects,
|
|
})
|
|
await opts.storeController.upload(depNode.dir, {
|
|
sideEffectsCacheKey,
|
|
filesIndexFile: depNode.filesIndexFile,
|
|
})
|
|
} catch (err: unknown) {
|
|
assert(util.types.isNativeError(err))
|
|
logger.warn({
|
|
error: err,
|
|
message: `An error occurred while uploading ${depNode.dir}`,
|
|
prefix: opts.lockfileDir,
|
|
})
|
|
}
|
|
}
|
|
buildSucceeded = true
|
|
} catch (err: unknown) {
|
|
assert(util.types.isNativeError(err))
|
|
// In GVS mode, remove the entire hash directory so the next install
|
|
// sees the directory is absent, re-fetches, and re-builds.
|
|
if (opts.enableGlobalVirtualStore) {
|
|
const hashDir = path.resolve(depNode.dir, '../..')
|
|
await fs.rm(hashDir, { recursive: true, force: true })
|
|
}
|
|
if (depNode.optional) {
|
|
// TODO: add parents field to the log
|
|
skippedOptionalDependencyLogger.debug({
|
|
details: err.toString(),
|
|
package: {
|
|
id: depNode.dir,
|
|
name: depNode.name,
|
|
version: depNode.version,
|
|
},
|
|
prefix: opts.lockfileDir,
|
|
reason: 'build_failure',
|
|
})
|
|
return
|
|
}
|
|
throw err
|
|
} finally {
|
|
if (buildSucceeded) {
|
|
const hoistedLocationsOfDep = opts.hoistedLocations?.[depNode.depPath]
|
|
if (hoistedLocationsOfDep) {
|
|
// There is no need to build the same package in every location.
|
|
// We just copy the built package to every location where it is present.
|
|
const currentHoistedLocation = path.relative(opts.lockfileDir, depNode.dir)
|
|
const nonBuiltHoistedDeps = hoistedLocationsOfDep?.filter((hoistedLocation) => hoistedLocation !== currentHoistedLocation)
|
|
await hardLinkDir(depNode.dir, nonBuiltHoistedDeps)
|
|
}
|
|
}
|
|
if (opts.builtHoistedDeps) {
|
|
opts.builtHoistedDeps[depNode.depPath].resolve()
|
|
}
|
|
}
|
|
}
|
|
|
|
export async function linkBinsOfDependencies<T extends string> (
|
|
depNode: DependenciesGraphNode<T>,
|
|
depGraph: DependenciesGraph<T>,
|
|
opts: {
|
|
extraNodePaths?: string[]
|
|
optional: boolean
|
|
preferSymlinkedExecutables?: boolean
|
|
warn: (message: string) => void
|
|
}
|
|
): Promise<void> {
|
|
const childrenToLink: Record<string, T> = opts.optional
|
|
? depNode.children
|
|
: pickBy((child, childAlias) => !depNode.optionalDependencies.has(childAlias), depNode.children)
|
|
|
|
const binPath = path.join(depNode.dir, 'node_modules/.bin')
|
|
|
|
const pkgNodes = [
|
|
...Object.entries(childrenToLink)
|
|
.map(([alias, childDepPath]) => ({ alias, dep: depGraph[childDepPath] }))
|
|
.filter(({ alias, dep }) => {
|
|
if (!dep) {
|
|
// TODO: Try to reproduce this issue with a test in @pnpm/installing.deps-installer
|
|
logger.debug({ message: `Failed to link bins of "${alias}" to "${binPath}". This is probably not an issue.` })
|
|
return false
|
|
}
|
|
return dep.hasBin && dep.installable !== false
|
|
})
|
|
.map(({ dep }) => dep),
|
|
depNode,
|
|
]
|
|
const pkgs = await Promise.all(pkgNodes
|
|
.map(async (dep) => ({
|
|
location: dep.dir,
|
|
manifest: ((await dep.fetching?.())?.bundledManifest ?? (await safeReadPackageJsonFromDir(dep.dir))) as DependencyManifest ?? {},
|
|
}))
|
|
)
|
|
|
|
await linkBinsOfPackages(pkgs, binPath, {
|
|
extraNodePaths: opts.extraNodePaths,
|
|
preferSymlinkedExecutables: opts.preferSymlinkedExecutables,
|
|
})
|
|
|
|
// link also the bundled dependencies` bins
|
|
if (depNode.hasBundledDependencies) {
|
|
const bundledModules = path.join(depNode.dir, 'node_modules')
|
|
await linkBins(bundledModules, binPath, {
|
|
extraNodePaths: opts.extraNodePaths,
|
|
preferSymlinkedExecutables: opts.preferSymlinkedExecutables,
|
|
warn: opts.warn,
|
|
})
|
|
}
|
|
}
|