Files
pnpm/exec/commands/test/verifyDepsBeforeRun.ts
Zoltan Kochan 96704a1c58 refactor(config): rename rawConfig to authConfig, add nodeDownloadMirrors, simplify config reader (#11194)
Major cleanup of the config system after migrating settings from `.npmrc` to `pnpm-workspace.yaml`.

### Config reader simplification
- Remove `checkUnknownSetting` (dead code, always `false`)
- Trim `npmConfigTypes` from ~127 to ~67 keys (remove unused npm config keys)
- Replace `rcOptions` iteration over all type keys with direct construction from defaults + auth overlay
- Remove `rcOptionsTypes` parameter from `getConfig()` and its assembly chain

### Rename `rawConfig` to `authConfig`
- `rawConfig` was a confusing mix of auth data and general settings
- Non-auth settings are already on the typed `Config` object — stop duplicating them in `rawConfig`
- Rename `rawConfig` → `authConfig` across the codebase to clarify it only contains auth/registry data from `.npmrc`

### Remove `rawConfig` from non-auth consumers
- **Lifecycle hooks**: replace `rawConfig: object` with `userAgent?: string` — only user-agent was read
- **Fetchers**: remove unused `rawConfig` from git fetcher, binary fetcher, tarball fetcher, prepare-package
- **Update command**: use `opts.production/dev/optional` instead of `rawConfig.*`
- **`pnpm init`**: accept typed init properties instead of parsing `rawConfig`

### Add `nodeDownloadMirrors` setting
- New `nodeDownloadMirrors?: Record<string, string>` on `PnpmSettings` and `Config`
- Replaces the `node-mirror:<channel>` pattern that was stored in `rawConfig`
- Configured in `pnpm-workspace.yaml`:
  ```yaml
  nodeDownloadMirrors:
    release: https://my-mirror.example.com/download/release/
  ```
- Remove unused `rawConfig` from deno-resolver and bun-resolver

### Refactor `pnpm config get/list`
- New `configToRecord()` builds display data from typed Config properties on the fly
- Excludes sensitive internals (`authInfos`, `sslConfigs`, etc.)
- Non-types keys (e.g., `package-extensions`) resolve through `configToRecord` instead of direct property access
- Delete `processConfig.ts` (replaced by `configToRecord.ts`)

### Pre-push hook improvement
- Add `compile-only` (`tsgo --build`) to pre-push hook to catch type errors before push
2026-04-04 20:33:43 +02:00

131 lines
3.5 KiB
TypeScript

import fs from 'node:fs'
import path from 'node:path'
import { jest } from '@jest/globals'
import type { VerifyDepsBeforeRun } from '@pnpm/config.reader'
import { prepare } from '@pnpm/prepare'
import { DEFAULT_OPTS } from './utils/index.js'
const originalModule = await import('@pnpm/logger')
jest.unstable_mockModule('@pnpm/logger', () => {
return {
...originalModule,
globalWarn: jest.fn(),
}
})
jest.unstable_mockModule('enquirer', () => ({
default: {
prompt: jest.fn(),
},
}))
const { run } = await import('@pnpm/exec.commands')
const { default: enquirer } = await import('enquirer')
const { globalWarn } = await import('@pnpm/logger')
const rootProjectManifest = {
name: 'root',
private: true,
dependencies: {
'is-positive': '1.0.0',
},
scripts: {
test: 'echo hello from script',
},
}
async function runTest (verifyDepsBeforeRun: VerifyDepsBeforeRun): Promise<void> {
await run.handler({
...DEFAULT_OPTS,
bin: 'node_modules/.bin',
dir: process.cwd(),
extraBinPaths: [],
extraEnv: {},
pnpmHomeDir: '',
verifyDepsBeforeRun,
rootProjectManifest,
rootProjectManifestDir: process.cwd(),
}, ['test'])
}
test('throw an error if verifyDepsBeforeRun is set to error', async () => {
prepare(rootProjectManifest)
let err!: Error
try {
await runTest('error')
} catch (_err) {
err = _err as Error
}
expect(err.message).toContain('Cannot check whether dependencies are outdated')
})
test('install the dependencies if verifyDepsBeforeRun is set to install', async () => {
prepare(rootProjectManifest)
await runTest('install')
expect(fs.existsSync(path.resolve('node_modules'))).toBeTruthy()
})
test('log a warning if verifyDepsBeforeRun is set to warn', async () => {
prepare(rootProjectManifest)
await runTest('warn')
expect(globalWarn).toHaveBeenCalledWith(
expect.stringContaining('Your node_modules are out of sync with your lockfile')
)
expect(fs.existsSync(path.resolve('node_modules'))).toBeFalsy()
})
test('prompt the user if verifyDepsBeforeRun is set to prompt', async () => {
prepare(rootProjectManifest)
// Mock the user confirming the prompt
jest.mocked(enquirer.prompt).mockResolvedValue({ runInstall: true })
const originalIsTTY = process.stdin.isTTY
Object.defineProperty(process.stdin, 'isTTY', { value: true, configurable: true })
try {
await runTest('prompt')
} finally {
Object.defineProperty(process.stdin, 'isTTY', { value: originalIsTTY, configurable: true })
}
expect(enquirer.prompt).toHaveBeenCalledWith({
type: 'confirm',
name: 'runInstall',
message: expect.stringContaining(
'Your "node_modules" directory is out of sync with the "pnpm-lock.yaml" file'
),
initial: true,
})
expect(fs.existsSync(path.resolve('node_modules'))).toBeTruthy()
})
test('throw an error if verifyDepsBeforeRun is set to prompt in non-TTY environment', async () => {
prepare(rootProjectManifest)
// Mock non-TTY environment
const originalIsTTY = process.stdin.isTTY
Object.defineProperty(process.stdin, 'isTTY', { value: false, configurable: true })
let err!: Error
try {
await runTest('prompt')
} catch (_err) {
err = _err as Error
} finally {
// Restore original value
Object.defineProperty(process.stdin, 'isTTY', { value: originalIsTTY, configurable: true })
}
expect(err.message).toContain('Cannot check whether dependencies are outdated')
expect(fs.existsSync(path.resolve('node_modules'))).toBeFalsy()
})