Files
pnpm/installing/deps-installer/test/breakingChanges.ts
Zoltan Kochan 4a36b9a110 refactor: rename internal packages to @pnpm/<domain>.<leaf> convention (#10997)
## Summary

Rename all internal packages so their npm names follow the `@pnpm/<domain>.<leaf>` convention, matching their directory structure. Also rename directories to remove redundancy and improve clarity.

### Bulk rename (94 packages)

All `@pnpm/` packages now derive their name from their directory path using dot-separated segments. Exceptions: `packages/`, `__utils__/`, and `pnpm/artifacts/` keep leaf names only.

### Directory renames (removing redundant prefixes)

- `cli/cli-meta` → `cli/meta`, `cli/cli-utils` → `cli/utils`
- `config/config` → `config/reader`, `config/config-writer` → `config/writer`
- `fetching/fetching-types` → `fetching/types`
- `lockfile/lockfile-to-pnp` → `lockfile/to-pnp`
- `store/store-connection-manager` → `store/connection-manager`
- `store/store-controller-types` → `store/controller-types`
- `store/store-path` → `store/path`

### Targeted renames (clarity improvements)

- `deps/dependency-path` → `deps/path` (`@pnpm/deps.path`)
- `deps/calc-dep-state` → `deps/graph-hasher` (`@pnpm/deps.graph-hasher`)
- `deps/inspection/dependencies-hierarchy` → `deps/inspection/tree-builder` (`@pnpm/deps.inspection.tree-builder`)
- `bins/link-bins` → `bins/linker`, `bins/remove-bins` → `bins/remover`, `bins/package-bins` → `bins/resolver`
- `installing/get-context` → `installing/context`
- `store/package-store` → `store/controller`
- `pkg-manifest/manifest-utils` → `pkg-manifest/utils`

### Manifest reader/writer renames

- `workspace/read-project-manifest` → `workspace/project-manifest-reader` (`@pnpm/workspace.project-manifest-reader`)
- `workspace/write-project-manifest` → `workspace/project-manifest-writer` (`@pnpm/workspace.project-manifest-writer`)
- `workspace/read-manifest` → `workspace/workspace-manifest-reader` (`@pnpm/workspace.workspace-manifest-reader`)
- `workspace/manifest-writer` → `workspace/workspace-manifest-writer` (`@pnpm/workspace.workspace-manifest-writer`)

### Workspace package renames

- `workspace/find-packages` → `workspace/projects-reader`
- `workspace/find-workspace-dir` → `workspace/root-finder`
- `workspace/resolve-workspace-range` → `workspace/range-resolver`
- `workspace/filter-packages-from-dir` merged into `workspace/filter-workspace-packages` → `workspace/projects-filter`

### Domain moves

- `pkg-manifest/read-project-manifest` → `workspace/project-manifest-reader`
- `pkg-manifest/write-project-manifest` → `workspace/project-manifest-writer`
- `pkg-manifest/exportable-manifest` → `releasing/exportable-manifest`

### Scope

- 1206 files changed
- Updated: package.json names/deps, TypeScript imports, tsconfig references, changeset files, renovate.json, test fixtures, import ordering
2026-03-17 21:50:40 +01:00

161 lines
4.7 KiB
TypeScript

import fs from 'node:fs'
import path from 'node:path'
import util from 'node:util'
import { WANTED_LOCKFILE } from '@pnpm/constants'
import type { PnpmError } from '@pnpm/error'
import { addDependenciesToPackage, install } from '@pnpm/installing.deps-installer'
import { prepareEmpty, preparePackages } from '@pnpm/prepare'
import { rimrafSync } from '@zkochan/rimraf'
import { isCI } from 'ci-info'
import { testDefaults } from './utils/index.js'
test('fail on non-compatible node_modules', async () => {
prepareEmpty()
const opts = testDefaults()
await saveModulesYaml('0.50.0', opts.storeDir)
try {
await addDependenciesToPackage({}, ['is-negative'], opts)
throw new Error('should have failed')
} catch (err: any) { // eslint-disable-line
expect(err.code).toBe('ERR_PNPM_MODULES_BREAKING_CHANGE')
}
})
test("don't fail on non-compatible node_modules when forced", async () => {
prepareEmpty()
const opts = testDefaults({ force: true })
await saveModulesYaml('0.50.0', opts.storeDir)
await install({}, opts)
})
test("don't fail on non-compatible node_modules when forced in a workspace", async () => {
preparePackages([
{
location: 'pkg',
package: {},
},
])
const opts = testDefaults({ force: true })
process.chdir('pkg')
const { updatedManifest: manifest } = await addDependenciesToPackage({}, ['is-positive@1.0.0'], testDefaults({ lockfileDir: path.resolve('..') }))
rimrafSync('node_modules')
process.chdir('..')
fs.writeFileSync('node_modules/.modules.yaml', `packageManager: pnpm@${3}\nstore: ${opts.storeDir}\nlayoutVersion: 1`)
await install(manifest, { ...opts, dir: path.resolve('pkg'), lockfileDir: process.cwd() })
})
test('do not fail on non-compatible node_modules when forced with a named installation', async () => {
prepareEmpty()
const opts = testDefaults()
await saveModulesYaml('0.50.0', opts.storeDir)
let err!: PnpmError
try {
await addDependenciesToPackage({}, ['is-negative'], opts)
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_MODULES_BREAKING_CHANGE')
await install({}, {
...opts,
confirmModulesPurge: false,
})
})
test("don't fail on non-compatible store when forced", async () => {
prepareEmpty()
const opts = testDefaults({ force: true })
await saveModulesYaml('0.32.0', opts.storeDir)
await install({}, opts)
})
test('do not fail on non-compatible store when forced during named installation', async () => {
prepareEmpty()
const opts = testDefaults()
await saveModulesYaml('0.32.0', opts.storeDir)
let err!: PnpmError
try {
await addDependenciesToPackage({}, ['is-negative'], opts)
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_MODULES_BREAKING_CHANGE')
await install({}, {
...opts,
confirmModulesPurge: false,
})
})
test('fail fast with actionable hint on non-TTY when modules purge needs confirmation', async () => {
prepareEmpty()
const opts = testDefaults()
await saveModulesYaml('0.50.0', opts.storeDir)
const originalIsTTY = process.stdin.isTTY
Object.defineProperty(process.stdin, 'isTTY', { value: false, configurable: true })
let err: unknown
try {
await install({}, opts)
} catch (_err: unknown) {
err = _err
} finally {
Object.defineProperty(process.stdin, 'isTTY', { value: originalIsTTY, configurable: true })
}
expect(util.types.isNativeError(err)).toBeTruthy()
if (util.types.isNativeError(err)) {
expect('code' in err && err.code).toBe('ERR_PNPM_ABORTED_REMOVE_MODULES_DIR_NO_TTY')
expect(err.message).toContain('no TTY')
expect('hint' in err && typeof err.hint === 'string' && err.hint).toContain('confirmModulesPurge')
}
})
async function saveModulesYaml (pnpmVersion: string, storeDir: string) {
fs.mkdirSync('node_modules')
fs.writeFileSync('node_modules/.modules.yaml', `packageManager: pnpm@${pnpmVersion}\nstoreDir: ${storeDir}`)
}
test(`fail on non-compatible ${WANTED_LOCKFILE} when frozen lockfile installation is used`, async () => {
if (isCI) {
console.log('this test will always fail on CI servers')
return
}
prepareEmpty()
fs.writeFileSync(WANTED_LOCKFILE, '')
try {
await addDependenciesToPackage({}, ['is-negative'], testDefaults({ frozenLockfile: true }))
throw new Error('should have failed')
} catch (err: any) { // eslint-disable-line
if (err.message === 'should have failed') throw err
expect(err.code).toBe('ERR_PNPM_BROKEN_LOCKFILE')
}
})
test(`don't fail on non-compatible ${WANTED_LOCKFILE} when forced`, async () => {
prepareEmpty()
fs.writeFileSync(WANTED_LOCKFILE, '')
await addDependenciesToPackage({}, ['is-negative'], testDefaults({ force: true }))
})