mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-12 10:11:42 -04:00
4d7cd56ccc
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
121 lines
5.0 KiB
TypeScript
121 lines
5.0 KiB
TypeScript
import { expect, test } from '@jest/globals'
|
|
|
|
import {
|
|
type ExactToken,
|
|
parsePropertyPath,
|
|
type UnexpectedEndOfInputError,
|
|
type UnexpectedIdentifierError,
|
|
type UnexpectedLiteralError,
|
|
type UnexpectedToken,
|
|
type UnexpectedTokenError,
|
|
} from '../src/index.js'
|
|
|
|
test('valid property path', () => {
|
|
expect(Array.from(parsePropertyPath(''))).toStrictEqual([])
|
|
expect(Array.from(parsePropertyPath('foo'))).toStrictEqual(['foo'])
|
|
expect(Array.from(parsePropertyPath('.foo'))).toStrictEqual(['foo'])
|
|
expect(Array.from(parsePropertyPath('["foo"]'))).toStrictEqual(['foo'])
|
|
expect(Array.from(parsePropertyPath("['foo']"))).toStrictEqual(['foo'])
|
|
expect(Array.from(parsePropertyPath('[ "foo" ]'))).toStrictEqual(['foo'])
|
|
expect(Array.from(parsePropertyPath("[ 'foo' ]"))).toStrictEqual(['foo'])
|
|
expect(Array.from(parsePropertyPath('foo.bar[0]'))).toStrictEqual(['foo', 'bar', 0])
|
|
expect(Array.from(parsePropertyPath('.foo.bar[0]'))).toStrictEqual(['foo', 'bar', 0])
|
|
expect(Array.from(parsePropertyPath('foo["bar"][0]'))).toStrictEqual(['foo', 'bar', 0])
|
|
expect(Array.from(parsePropertyPath(".foo['bar'][0]"))).toStrictEqual(['foo', 'bar', 0])
|
|
expect(Array.from(parsePropertyPath('foo.bar["0"]'))).toStrictEqual(['foo', 'bar', '0'])
|
|
expect(Array.from(parsePropertyPath('a.b.c.d'))).toStrictEqual(['a', 'b', 'c', 'd'])
|
|
expect(Array.from(parsePropertyPath('.a.b.c.d'))).toStrictEqual(['a', 'b', 'c', 'd'])
|
|
expect(Array.from(parsePropertyPath('a .b .c .d'))).toStrictEqual(['a', 'b', 'c', 'd'])
|
|
expect(Array.from(parsePropertyPath('.a .b .c .d'))).toStrictEqual(['a', 'b', 'c', 'd'])
|
|
})
|
|
|
|
test('invalid property path', () => {
|
|
expect(() => Array.from(parsePropertyPath('foo.bar.0'))).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_LITERAL_IN_PROPERTY_PATH',
|
|
token: {
|
|
type: 'numeric-literal',
|
|
content: 0,
|
|
},
|
|
} as Partial<UnexpectedLiteralError>))
|
|
expect(() => Array.from(parsePropertyPath('foo.bar."baz"'))).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_LITERAL_IN_PROPERTY_PATH',
|
|
token: {
|
|
type: 'string-literal',
|
|
quote: '"',
|
|
content: 'baz',
|
|
},
|
|
} as Partial<UnexpectedLiteralError>))
|
|
expect(() => Array.from(parsePropertyPath('foo.bar"baz"'))).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_LITERAL_IN_PROPERTY_PATH',
|
|
token: {
|
|
type: 'string-literal',
|
|
quote: '"',
|
|
content: 'baz',
|
|
},
|
|
} as Partial<UnexpectedLiteralError>))
|
|
expect(() => Array.from(parsePropertyPath('foo.bar "baz"'))).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_LITERAL_IN_PROPERTY_PATH',
|
|
token: {
|
|
type: 'string-literal',
|
|
quote: '"',
|
|
content: 'baz',
|
|
},
|
|
} as Partial<UnexpectedLiteralError>))
|
|
expect(() => Array.from(parsePropertyPath('foo.bar[baz]'))).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_IDENTIFIER_IN_PROPERTY_PATH',
|
|
token: {
|
|
type: 'identifier',
|
|
content: 'baz',
|
|
},
|
|
} as Partial<UnexpectedIdentifierError>))
|
|
expect(() => Array.from(parsePropertyPath('foo.bar..baz'))).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_TOKEN_IN_PROPERTY_PATH',
|
|
token: {
|
|
type: 'exact',
|
|
content: '.',
|
|
},
|
|
} as Partial<UnexpectedTokenError<ExactToken<'.'>>>))
|
|
expect(() => Array.from(parsePropertyPath('foo.bar[[0]]'))).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_TOKEN_IN_PROPERTY_PATH',
|
|
token: {
|
|
type: 'exact',
|
|
content: '[',
|
|
},
|
|
} as Partial<UnexpectedTokenError<ExactToken<'['>>>))
|
|
expect(() => Array.from(parsePropertyPath('foo.bar[0]]'))).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_TOKEN_IN_PROPERTY_PATH',
|
|
token: {
|
|
type: 'exact',
|
|
content: ']',
|
|
},
|
|
} as Partial<UnexpectedTokenError<ExactToken<']'>>>))
|
|
expect(() => Array.from(parsePropertyPath('foo.bar?.baz'))).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_TOKEN_IN_PROPERTY_PATH',
|
|
token: {
|
|
type: 'unexpected',
|
|
content: '?',
|
|
},
|
|
} as Partial<UnexpectedTokenError<UnexpectedToken>>))
|
|
expect(() => Array.from(parsePropertyPath('foo.bar.baz.'))).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_END_OF_PROPERTY_PATH',
|
|
} as Partial<UnexpectedEndOfInputError>))
|
|
expect(() => Array.from(parsePropertyPath('foo.bar.baz[0'))).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_END_OF_PROPERTY_PATH',
|
|
} as Partial<UnexpectedEndOfInputError>))
|
|
})
|
|
|
|
test('partial parse', () => {
|
|
const iter = parsePropertyPath('.foo.bar[123]?.baz')
|
|
expect(iter.next()).toStrictEqual({ done: false, value: 'foo' })
|
|
expect(iter.next()).toStrictEqual({ done: false, value: 'bar' })
|
|
expect(iter.next()).toStrictEqual({ done: false, value: 123 })
|
|
expect(() => iter.next()).toThrow(expect.objectContaining({
|
|
code: 'ERR_PNPM_UNEXPECTED_TOKEN_IN_PROPERTY_PATH',
|
|
token: {
|
|
type: 'unexpected',
|
|
content: '?',
|
|
},
|
|
} as Partial<UnexpectedTokenError<UnexpectedToken>>))
|
|
expect(iter.next()).toStrictEqual({ done: true, value: undefined })
|
|
})
|