mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-13 02:55:56 -04:00
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
147 lines
4.4 KiB
TypeScript
147 lines
4.4 KiB
TypeScript
/// <reference lib="esnext.disposable" />
|
|
import fs from 'node:fs'
|
|
import net from 'node:net'
|
|
import path from 'node:path'
|
|
import { setTimeout } from 'node:timers/promises'
|
|
import { promisify } from 'node:util'
|
|
|
|
import { describe, expect, it } from '@jest/globals'
|
|
import { prepare } from '@pnpm/prepare'
|
|
import { createTestIpcServer } from '@pnpm/test-ipc-server'
|
|
import { safeExeca as execa } from 'execa'
|
|
|
|
const pnpmBin = path.join(import.meta.dirname, '../../../pnpm/bin/pnpm.mjs')
|
|
|
|
describe('TestEchoServer', () => {
|
|
describe('lifecycle', () => {
|
|
it('cleans up through Symbol.asyncDispose', async () => {
|
|
let listenPath: string
|
|
|
|
{
|
|
await using server = await createTestIpcServer()
|
|
listenPath = server.listenPath
|
|
await expect(fs.promises.access(server.listenPath)).resolves.not.toThrow()
|
|
}
|
|
|
|
// The Symbol.asyncDispose method should have been called by this point and
|
|
// removed the listening file.
|
|
await expect(fs.promises.access(listenPath)).rejects.toThrow('ENOENT')
|
|
})
|
|
|
|
it('throws if another server is listening on same socket', async () => {
|
|
await using server = await createTestIpcServer()
|
|
await expect(createTestIpcServer(server.listenPath)).rejects.toThrow('EADDRINUSE')
|
|
})
|
|
})
|
|
|
|
describe('message handling', () => {
|
|
it('receives messages', async () => {
|
|
await using server = await createTestIpcServer()
|
|
await using client = await createClient(server.listenPath)
|
|
await client.sendLine('hello')
|
|
await client.sendLine('world')
|
|
|
|
// Wait a short amount of time for the server to handle incoming messages.
|
|
await setTimeout(50)
|
|
expect(server.getBuffer()).toBe('hello\nworld\n')
|
|
expect(server.getLines()).toStrictEqual(['hello', 'world'])
|
|
})
|
|
|
|
it('clears messages', async () => {
|
|
await using server = await createTestIpcServer()
|
|
await using client = await createClient(server.listenPath)
|
|
await client.sendLine('hello')
|
|
await client.sendLine('world')
|
|
|
|
// Wait a short amount of time for the server to handle incoming messages.
|
|
await setTimeout(50)
|
|
expect(server.getLines()).toStrictEqual(['hello', 'world'])
|
|
|
|
server.clear()
|
|
|
|
expect(server.getLines()).toStrictEqual([])
|
|
})
|
|
})
|
|
|
|
describe('generated scripts', () => {
|
|
it('generates working send message script', async () => {
|
|
await using server = await createTestIpcServer()
|
|
|
|
prepare({
|
|
scripts: {
|
|
build: server.sendLineScript('build script'),
|
|
},
|
|
})
|
|
|
|
await execa('node', [pnpmBin, 'run', 'build'])
|
|
|
|
expect(server.getLines()).toStrictEqual(['build script'])
|
|
})
|
|
|
|
it('send message script works with &&', async () => {
|
|
await using server = await createTestIpcServer()
|
|
|
|
prepare({
|
|
scripts: {
|
|
build: `${server.sendLineScript('message1')} && ${server.sendLineScript('message2')}`,
|
|
},
|
|
})
|
|
|
|
await execa('node', [pnpmBin, 'run', 'build'])
|
|
|
|
expect(server.getLines()).toStrictEqual(['message1', 'message2'])
|
|
})
|
|
|
|
it('generates working stdin script', async () => {
|
|
await using server = await createTestIpcServer()
|
|
|
|
prepare({
|
|
scripts: {
|
|
build: `node -e "process.stdout.write('build script')" | ${server.generateSendStdinScript()}`,
|
|
},
|
|
})
|
|
|
|
await execa('node', [pnpmBin, 'run', 'build'])
|
|
|
|
expect(server.getLines()).toStrictEqual(['build script'])
|
|
})
|
|
})
|
|
|
|
it('has working client binary', async () => {
|
|
const project = prepare({
|
|
scripts: {
|
|
build: "node -e \"process.stdout.write('build script')\" | test-ipc-server-client ./test.sock",
|
|
},
|
|
})
|
|
|
|
await using server = await createTestIpcServer(path.join(project.dir(), './test.sock'))
|
|
|
|
await execa('node', [pnpmBin, 'run', 'build'])
|
|
|
|
expect(server.getLines()).toStrictEqual(['build script'])
|
|
})
|
|
})
|
|
|
|
interface TestClient extends AsyncDisposable {
|
|
sendLine: (message: string) => Promise<void>
|
|
}
|
|
|
|
function createClient (handle: string): Promise<TestClient> {
|
|
const client = net.connect(handle)
|
|
|
|
const write = promisify(client.write).bind(client)
|
|
const destroy = promisify(client.destroy).bind(client)
|
|
|
|
return new Promise((resolve, reject) => {
|
|
client.once('error', reject)
|
|
client.once('ready', () => {
|
|
resolve({
|
|
sendLine: (message: string) => write(message + '\n'),
|
|
[Symbol.asyncDispose]: async () => {
|
|
await destroy(undefined)
|
|
},
|
|
})
|
|
})
|
|
})
|
|
}
|