mirror/pnpm
1
0
Fork 0
mirror of https://github.com/pnpm/pnpm.git synced 2026-05-13 19:16:21 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
d98ac7e4bbf8a0d0220dba68befddd8255c19a8b
pnpm/installing/commands/test/update/recursive.ts
Zoltan Kochan 187049055f chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2 (#11332) 
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2

- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
  20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
  `it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
  instead of relying on `@types/jest` ambient declarations. Under the
  new tsgo build, `import { jest } from '@jest/globals'` shadows the
  ambient `jest` namespace, breaking `@types/jest`'s `declare var
  describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
  now import from it, and add `@types/node` to packages that need it
  but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
  no longer globally available.

* chore: fix remaining tsgo type-strictness errors

- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
  toStrictEqual / toEqual; @jest/globals rejects the typed objects
  (which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
  for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
  return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
  expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
  for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
  that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
  two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.

* chore: address Copilot review on #11332

- Move misplaced `@jest/globals` imports to the top import block in
  checkEngine, run.ts, and workspace/root-finder tests where the
  script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
  in bins/linker, lockfile/fs, and resolving/local-resolver tests with
  `await expect(x()).rejects.toMatchObject({...})`. The old pattern
  swallowed an unrelated `throw` if the under-test call silently
  succeeded, which would fail on the catch-block assertion with a
  misleading message.
2026-04-21 22:50:40 +02:00

446 lines
12 KiB
TypeScript
Raw Blame History

import { expect, test } from '@jest/globals'
import type { PnpmError } from '@pnpm/error'
import { install, update } from '@pnpm/installing.commands'
import { readModulesManifest } from '@pnpm/installing.modules-yaml'
import type { LockfileObject } from '@pnpm/lockfile.types'
import { preparePackages } from '@pnpm/prepare'
import { addDistTag } from '@pnpm/registry-mock'
import { readProjectManifestOnly } from '@pnpm/workspace.project-manifest-reader'
import { filterProjectsBySelectorObjectsFromDir } from '@pnpm/workspace.projects-filter'
import { readYamlFileSync } from 'read-yaml-file'
import { DEFAULT_OPTS } from '../utils/index.js'
test('recursive update', async () => {
const projects = preparePackages([
{
name: 'project-1',
version: '1.0.0',
dependencies: {
'is-positive': '1.0.0',
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'is-negative': '1.0.0',
},
},
])
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
await install.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
})
await update.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
}, ['is-positive@2.0.0'])
expect(projects['project-1'].requireModule('is-positive/package.json').version).toBe('2.0.0')
projects['project-2'].hasNot('is-positive')
})
test('recursive update prod dependencies only', async () => {
await addDistTag({ package: '@pnpm.e2e/foo', version: '100.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/bar', version: '100.0.0', distTag: 'latest' })
preparePackages([
{
name: 'project-1',
version: '1.0.0',
dependencies: {
'@pnpm.e2e/foo': '^100.0.0',
},
},
{
name: 'project-2',
version: '1.0.0',
devDependencies: {
'@pnpm.e2e/bar': '^100.0.0',
},
},
])
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
await install.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
lockfileDir: process.cwd(),
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
})
await addDistTag({ package: '@pnpm.e2e/foo', version: '100.1.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/bar', version: '100.1.0', distTag: 'latest' })
await update.handler({
...DEFAULT_OPTS,
allProjects,
cliOptions: {
optional: false,
production: true,
},
dir: process.cwd(),
lockfileDir: process.cwd(),
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
})
const lockfile = readYamlFileSync<LockfileObject>('./pnpm-lock.yaml')
expect(
Object.keys(lockfile.packages ?? {})
).toStrictEqual(
['@pnpm.e2e/bar@100.0.0', '@pnpm.e2e/foo@100.1.0']
)
const modules = await readModulesManifest('./node_modules')
expect(modules?.included).toStrictEqual({
dependencies: true,
devDependencies: true,
optionalDependencies: true,
})
})
test('recursive update with pattern', async () => {
const projects = preparePackages([
{
name: 'project-1',
version: '1.0.0',
dependencies: {
'@pnpm.e2e/dep-of-pkg-with-1-dep': '100.0.0',
'@pnpm.e2e/foo': '1.0.0',
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'@pnpm.e2e/peer-c': '1.0.0',
},
},
])
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
await install.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
})
await addDistTag({ package: '@pnpm.e2e/dep-of-pkg-with-1-dep', version: '100.1.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/peer-c', version: '2.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/foo', version: '2.0.0', distTag: 'latest' })
await update.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
latest: true,
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
}, ['@pnpm.e2e/peer-*', '@pnpm.e2e/dep-of-pkg-*'])
expect(projects['project-1'].requireModule('@pnpm.e2e/dep-of-pkg-with-1-dep/package.json').version).toBe('100.1.0')
expect(projects['project-1'].requireModule('@pnpm.e2e/foo/package.json').version).toBe('1.0.0')
expect(projects['project-2'].requireModule('@pnpm.e2e/peer-c/package.json').version).toBe('2.0.0')
})
test('recursive update with pattern and name in project', async () => {
await addDistTag({ package: '@pnpm.e2e/dep-of-pkg-with-1-dep', version: '100.1.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/peer-c', version: '2.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/foo', version: '2.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/print-version', version: '2.0.0', distTag: 'latest' })
const projects = preparePackages([
{
name: 'project-1',
version: '1.0.0',
dependencies: {
'@pnpm.e2e/dep-of-pkg-with-1-dep': '100.0.0',
'@pnpm.e2e/foo': '1.0.0',
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'@pnpm.e2e/peer-c': '1.0.0',
'@pnpm.e2e/print-version': '1.0.0',
},
},
])
const lockfileDir = process.cwd()
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
await install.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
lockfileDir,
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
})
let err!: PnpmError
try {
await update.handler({
...DEFAULT_OPTS,
allProjects,
depth: 0,
dir: process.cwd(),
latest: true,
lockfileDir,
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
}, ['@pnpm.e2e/this-does-not-exist'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err).toBeTruthy()
expect(err.code).toBe('ERR_PNPM_NO_PACKAGE_IN_DEPENDENCIES')
// This should not fail because depth=0 is not specified
await update.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
latest: true,
lockfileDir,
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
}, ['@pnpm.e2e/this-does-not-exist'])
await update.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
latest: true,
lockfileDir,
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
}, ['@pnpm.e2e/peer-*', '@pnpm.e2e/dep-of-pkg-*', '@pnpm.e2e/print-version'])
expect(projects['project-1'].requireModule('@pnpm.e2e/dep-of-pkg-with-1-dep/package.json').version).toBe('100.1.0')
expect(projects['project-1'].requireModule('@pnpm.e2e/foo/package.json').version).toBe('1.0.0')
expect(projects['project-2'].requireModule('@pnpm.e2e/peer-c/package.json').version).toBe('2.0.0')
expect(projects['project-2'].requireModule('@pnpm.e2e/print-version/package.json').version).toBe('2.0.0')
})
test('recursive update --latest foo should only update projects that have foo', async () => {
await addDistTag({ package: '@pnpm.e2e/foo', version: '100.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/bar', version: '100.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/qar', version: '100.0.0', distTag: 'latest' })
preparePackages([
{
name: 'project-1',
version: '1.0.0',
dependencies: {
'@pnpm.e2e/foo': '100.0.0',
'@pnpm.e2e/qar': '100.0.0',
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'@zkochan/async-regex-replace': '0.1.0',
'@pnpm.e2e/bar': '^100.0.0',
},
},
])
const lockfileDir = process.cwd()
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
await install.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
lockfileDir,
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
})
await addDistTag({ package: '@pnpm.e2e/foo', version: '100.1.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/bar', version: '100.1.0', distTag: 'latest' })
await update.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
latest: true,
lockfileDir,
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
}, ['@zkochan/async-regex-replace', '@pnpm.e2e/foo'])
const lockfile = readYamlFileSync<LockfileObject>('./pnpm-lock.yaml')
expect(Object.keys(lockfile.packages ?? {}).sort()).toStrictEqual([
'@zkochan/async-regex-replace@0.2.0',
'@pnpm.e2e/bar@100.0.0',
'@pnpm.e2e/foo@100.1.0',
'@pnpm.e2e/qar@100.0.0',
].sort())
})
test('recursive update --latest foo should only update packages that have foo', async () => {
await addDistTag({ package: '@pnpm.e2e/foo', version: '100.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/bar', version: '100.0.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/qar', version: '100.0.0', distTag: 'latest' })
const projects = preparePackages([
{
name: 'project-1',
version: '1.0.0',
dependencies: {
'@pnpm.e2e/foo': '100.0.0',
'@pnpm.e2e/qar': '100.0.0',
},
},
{
name: 'project-2',
version: '1.0.0',
dependencies: {
'@pnpm.e2e/bar': '^100.0.0',
},
},
])
const { allProjects, selectedProjectsGraph } = await filterProjectsBySelectorObjectsFromDir(process.cwd(), [])
await install.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
})
await addDistTag({ package: '@pnpm.e2e/foo', version: '100.1.0', distTag: 'latest' })
await addDistTag({ package: '@pnpm.e2e/bar', version: '100.1.0', distTag: 'latest' })
await update.handler({
...DEFAULT_OPTS,
allProjects,
dir: process.cwd(),
latest: true,
recursive: true,
selectedProjectsGraph,
workspaceDir: process.cwd(),
}, ['@pnpm.e2e/foo'])
{
const lockfile = projects['project-1'].readLockfile()
expect(Object.keys(lockfile.packages ?? {})).toStrictEqual(['@pnpm.e2e/foo@100.1.0', '@pnpm.e2e/qar@100.0.0'])
}
{
const lockfile = projects['project-2'].readLockfile()
expect(Object.keys(lockfile.packages ?? {})).toStrictEqual(['@pnpm.e2e/bar@100.0.0'])
}
})
test('recursive update in workspace should not add new dependencies', async () => {
const projects = preparePackages([
{
name: 'project-1',
version: '1.0.0',
},
{
name: 'project-2',
version: '1.0.0',
},
])
let err!: PnpmError
try {
await update.handler({
...DEFAULT_OPTS,
...await filterProjectsBySelectorObjectsFromDir(process.cwd(), []),
depth: 0,
dir: process.cwd(),
recursive: true,
workspaceDir: process.cwd(),
}, ['is-positive'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err).toBeTruthy()
expect(err.code).toBe('ERR_PNPM_NO_PACKAGE_IN_DEPENDENCIES')
projects['project-1'].hasNot('is-positive')
projects['project-2'].hasNot('is-positive')
})
test('recursive update with aliased workspace dependency (#7975)', async () => {
const projects = preparePackages([
{
name: 'project-1',
version: '1.0.0',
dependencies: {
pkg: 'workspace:project-2@^',
},
},
{
name: 'project-2',
version: '1.0.0',
},
])
await update.handler({
...DEFAULT_OPTS,
...await filterProjectsBySelectorObjectsFromDir(process.cwd(), []),
depth: 0,
dir: process.cwd(),
recursive: true,
workspaceDir: process.cwd(),
saveWorkspaceProtocol: 'rolling',
})
projects['project-1'].has('pkg')
const manifest = await readProjectManifestOnly('project-1')
expect(manifest).toHaveProperty(['dependencies', 'pkg'], 'workspace:project-2@^')
})
Reference in New Issue View Git Blame Copy Permalink