mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-13 02:55:56 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
168 lines
4.5 KiB
TypeScript
168 lines
4.5 KiB
TypeScript
import { expect, test } from '@jest/globals'
|
|
import { guessDependencyType, updateProjectManifestObject } from '@pnpm/pkg-manifest.utils'
|
|
|
|
test('guessDependencyType()', () => {
|
|
expect(
|
|
guessDependencyType('foo', {
|
|
dependencies: {
|
|
bar: '1.0.0',
|
|
},
|
|
devDependencies: {
|
|
foo: '',
|
|
},
|
|
})
|
|
).toBe('devDependencies')
|
|
|
|
expect(
|
|
guessDependencyType('bar', {
|
|
dependencies: {
|
|
bar: '1.0.0',
|
|
},
|
|
devDependencies: {
|
|
foo: '1.0.0',
|
|
},
|
|
})
|
|
).toBe('dependencies')
|
|
})
|
|
|
|
test('peer dependencies fall back to "*" when resolved version is unavailable (git)', async () => {
|
|
const manifest = await updateProjectManifestObject('/project', {}, [
|
|
{
|
|
alias: 'foo',
|
|
bareSpecifier: 'https://github.com/kevva/is-negative',
|
|
peer: true,
|
|
saveType: 'devDependencies',
|
|
},
|
|
])
|
|
|
|
expect(manifest.devDependencies).toStrictEqual({
|
|
foo: 'https://github.com/kevva/is-negative',
|
|
})
|
|
expect(manifest.peerDependencies).toStrictEqual({
|
|
foo: '*',
|
|
})
|
|
})
|
|
|
|
test('peer dependencies fall back to "*" when resolved version is unavailable (tarball)', async () => {
|
|
const manifest = await updateProjectManifestObject('/project', {}, [
|
|
{
|
|
alias: 'foo',
|
|
bareSpecifier: 'https://github.com/hegemonic/taffydb/tarball/master',
|
|
peer: true,
|
|
saveType: 'devDependencies',
|
|
},
|
|
])
|
|
|
|
expect(manifest.devDependencies).toStrictEqual({
|
|
foo: 'https://github.com/hegemonic/taffydb/tarball/master',
|
|
})
|
|
expect(manifest.peerDependencies).toStrictEqual({
|
|
foo: '*',
|
|
})
|
|
})
|
|
|
|
test('peer dependencies use derived range when resolved version is available (git)', async () => {
|
|
const manifest = await updateProjectManifestObject('/project', {}, [
|
|
{
|
|
alias: 'foo',
|
|
bareSpecifier: 'https://github.com/kevva/is-negative',
|
|
resolvedVersion: '2.1.0',
|
|
peer: true,
|
|
saveType: 'devDependencies',
|
|
},
|
|
])
|
|
|
|
expect(manifest.devDependencies).toStrictEqual({
|
|
foo: 'https://github.com/kevva/is-negative',
|
|
})
|
|
expect(manifest.peerDependencies).toStrictEqual({
|
|
foo: '^2.1.0',
|
|
})
|
|
})
|
|
|
|
test('peer dependencies honor pinned version when resolved version is available (tarball)', async () => {
|
|
const manifest = await updateProjectManifestObject('/project', {}, [
|
|
{
|
|
alias: 'foo',
|
|
bareSpecifier: 'https://github.com/hegemonic/taffydb/tarball/master',
|
|
resolvedVersion: '1.4.0',
|
|
pinnedVersion: 'minor',
|
|
peer: true,
|
|
saveType: 'devDependencies',
|
|
},
|
|
])
|
|
|
|
expect(manifest.devDependencies).toStrictEqual({
|
|
foo: 'https://github.com/hegemonic/taffydb/tarball/master',
|
|
})
|
|
expect(manifest.peerDependencies).toStrictEqual({
|
|
foo: '~1.4.0',
|
|
})
|
|
})
|
|
|
|
test('peer dependencies derive range from resolved version for jsr protocol', async () => {
|
|
const manifest = await updateProjectManifestObject('/project', {}, [
|
|
{
|
|
alias: 'foo',
|
|
bareSpecifier: 'jsr:^0.1.0',
|
|
resolvedVersion: '0.1.0',
|
|
peer: true,
|
|
saveType: 'devDependencies',
|
|
},
|
|
])
|
|
|
|
expect(manifest.devDependencies).toStrictEqual({
|
|
foo: 'jsr:^0.1.0',
|
|
})
|
|
expect(manifest.peerDependencies).toStrictEqual({
|
|
foo: '^0.1.0',
|
|
})
|
|
})
|
|
|
|
test('peer dependencies keep prerelease resolved version without prefix', async () => {
|
|
const manifest = await updateProjectManifestObject('/project', {}, [
|
|
{
|
|
alias: 'foo',
|
|
bareSpecifier: 'https://github.com/kevva/is-negative',
|
|
resolvedVersion: '2.1.0-rc.1',
|
|
pinnedVersion: 'minor',
|
|
peer: true,
|
|
saveType: 'devDependencies',
|
|
},
|
|
])
|
|
|
|
expect(manifest.devDependencies).toStrictEqual({
|
|
foo: 'https://github.com/kevva/is-negative',
|
|
})
|
|
expect(manifest.peerDependencies).toStrictEqual({
|
|
foo: '2.1.0-rc.1',
|
|
})
|
|
})
|
|
|
|
test('peer dependencies respect pinned version "patch" and "none"', async () => {
|
|
const cases = [
|
|
{ pinnedVersion: 'patch' as const, expected: '3.2.1' },
|
|
{ pinnedVersion: 'none' as const, expected: '^3.2.1' },
|
|
]
|
|
|
|
await Promise.all(cases.map(async ({ pinnedVersion, expected }) => {
|
|
const manifest = await updateProjectManifestObject('/project', {}, [
|
|
{
|
|
alias: 'foo',
|
|
bareSpecifier: 'https://github.com/kevva/is-negative',
|
|
resolvedVersion: '3.2.1',
|
|
pinnedVersion,
|
|
peer: true,
|
|
saveType: 'devDependencies',
|
|
},
|
|
])
|
|
|
|
expect(manifest.devDependencies).toStrictEqual({
|
|
foo: 'https://github.com/kevva/is-negative',
|
|
})
|
|
expect(manifest.peerDependencies).toStrictEqual({
|
|
foo: expected,
|
|
})
|
|
}))
|
|
})
|