mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-13 02:55:56 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
101 lines
3.6 KiB
TypeScript
101 lines
3.6 KiB
TypeScript
/// <reference path="../../../__typings__/index.d.ts"/>
|
|
import path from 'node:path'
|
|
|
|
import { describe, expect, it } from '@jest/globals'
|
|
import { createClient } from '@pnpm/installing.client'
|
|
import { createPackageStore } from '@pnpm/store.controller'
|
|
import type { FetchPackageToStoreFunction } from '@pnpm/store.controller-types'
|
|
import { StoreIndex } from '@pnpm/store.index'
|
|
import { temporaryDirectory } from 'tempy'
|
|
|
|
describe('store.importPackage()', () => {
|
|
it('selects import method automatically', async () => {
|
|
const tmp = temporaryDirectory()
|
|
const storeDir = path.join(tmp, 'store')
|
|
const cacheDir = path.join(tmp, 'cache')
|
|
const registry = 'https://registry.npmjs.org/'
|
|
const storeIndex = new StoreIndex(storeDir)
|
|
const { resolve, fetchers, clearResolutionCache } = createClient({
|
|
configByUri: {},
|
|
cacheDir: path.join(tmp, 'cache'),
|
|
storeDir: path.join(tmp, 'store'),
|
|
storeIndex,
|
|
registries: {
|
|
default: registry,
|
|
},
|
|
})
|
|
const storeController = createPackageStore(resolve, fetchers, {
|
|
storeDir,
|
|
cacheDir,
|
|
verifyStoreIntegrity: true,
|
|
virtualStoreDirMaxLength: 120,
|
|
clearResolutionCache,
|
|
storeIndex,
|
|
})
|
|
const pkgId = 'registry.npmjs.org/is-positive/1.0.0'
|
|
const fetchResponse = (storeController.fetchPackage as FetchPackageToStoreFunction)({
|
|
force: false,
|
|
lockfileDir: temporaryDirectory(),
|
|
pkg: {
|
|
id: pkgId,
|
|
resolution: {
|
|
integrity: 'sha512-xxzPGZ4P2uN6rROUa5N9Z7zTX6ERuE0hs6GUOc/cKBLF2NqKc16UwqHMt3tFg4CO6EBTE5UecUasg+3jZx3Ckg==',
|
|
tarball: 'https://registry.npmjs.org/is-positive/-/is-positive-1.0.0.tgz',
|
|
},
|
|
},
|
|
})
|
|
const importTo = temporaryDirectory()
|
|
const { importMethod } = await storeController.importPackage(importTo, {
|
|
filesResponse: (await fetchResponse.fetching()).files,
|
|
force: false,
|
|
})
|
|
expect(typeof importMethod).toBe('string')
|
|
expect(typeof (await import(importTo)).default).toBe('function')
|
|
})
|
|
|
|
it('uses copying', async () => {
|
|
const tmp = temporaryDirectory()
|
|
const storeDir = path.join(tmp, 'store')
|
|
const cacheDir = path.join(tmp, 'cache')
|
|
const registry = 'https://registry.npmjs.org/'
|
|
const storeIndex = new StoreIndex(storeDir)
|
|
const { resolve, fetchers, clearResolutionCache } = createClient({
|
|
configByUri: {},
|
|
cacheDir: path.join(tmp, 'cache'),
|
|
storeDir: path.join(tmp, 'store'),
|
|
storeIndex,
|
|
registries: {
|
|
default: registry,
|
|
},
|
|
})
|
|
const storeController = createPackageStore(resolve, fetchers, {
|
|
packageImportMethod: 'copy',
|
|
storeDir,
|
|
cacheDir,
|
|
verifyStoreIntegrity: true,
|
|
virtualStoreDirMaxLength: 120,
|
|
clearResolutionCache,
|
|
storeIndex,
|
|
})
|
|
const pkgId = 'registry.npmjs.org/is-positive/1.0.0'
|
|
const fetchResponse = (storeController.fetchPackage as FetchPackageToStoreFunction)({
|
|
force: false,
|
|
lockfileDir: temporaryDirectory(),
|
|
pkg: {
|
|
id: pkgId,
|
|
resolution: {
|
|
integrity: 'sha512-xxzPGZ4P2uN6rROUa5N9Z7zTX6ERuE0hs6GUOc/cKBLF2NqKc16UwqHMt3tFg4CO6EBTE5UecUasg+3jZx3Ckg==',
|
|
tarball: 'https://registry.npmjs.org/is-positive/-/is-positive-1.0.0.tgz',
|
|
},
|
|
},
|
|
})
|
|
const importTo = temporaryDirectory()
|
|
const { importMethod } = await storeController.importPackage(importTo, {
|
|
filesResponse: (await fetchResponse.fetching()).files,
|
|
force: false,
|
|
})
|
|
expect(importMethod).toBe('copy')
|
|
expect(typeof (await import(importTo)).default).toBe('function')
|
|
})
|
|
})
|