mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-12 18:49:41 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
125 lines
4.4 KiB
TypeScript
125 lines
4.4 KiB
TypeScript
/// <reference path="../../../__typings__/index.d.ts"/>
|
|
import { promises as fs } from 'node:fs'
|
|
import path from 'node:path'
|
|
|
|
import { describe, expect, it } from '@jest/globals'
|
|
import { getRegisteredProjects, registerProject } from '@pnpm/store.controller'
|
|
import { temporaryDirectory } from 'tempy'
|
|
|
|
describe('projectRegistry', () => {
|
|
describe('registerProject()', () => {
|
|
it('creates a symlink in the projects directory', async () => {
|
|
const storeDir = temporaryDirectory()
|
|
const projectDir = temporaryDirectory()
|
|
|
|
await registerProject(storeDir, projectDir)
|
|
|
|
// Check that projects directory was created
|
|
const projectsDir = path.join(storeDir, 'projects')
|
|
const entries = await fs.readdir(projectsDir)
|
|
expect(entries).toHaveLength(1)
|
|
|
|
// Check that the symlink points to the project
|
|
const linkPath = path.join(projectsDir, entries[0])
|
|
const target = await fs.readlink(linkPath)
|
|
expect(path.resolve(path.dirname(linkPath), target)).toBe(projectDir)
|
|
})
|
|
|
|
it('is idempotent - registering the same project twice works', async () => {
|
|
const storeDir = temporaryDirectory()
|
|
const projectDir = temporaryDirectory()
|
|
|
|
await registerProject(storeDir, projectDir)
|
|
await registerProject(storeDir, projectDir)
|
|
|
|
const projectsDir = path.join(storeDir, 'projects')
|
|
const entries = await fs.readdir(projectsDir)
|
|
expect(entries).toHaveLength(1)
|
|
})
|
|
|
|
it('registers multiple projects with different hashes', async () => {
|
|
const storeDir = temporaryDirectory()
|
|
const projectDir1 = temporaryDirectory()
|
|
const projectDir2 = temporaryDirectory()
|
|
|
|
await registerProject(storeDir, projectDir1)
|
|
await registerProject(storeDir, projectDir2)
|
|
|
|
const projectsDir = path.join(storeDir, 'projects')
|
|
const entries = await fs.readdir(projectsDir)
|
|
expect(entries).toHaveLength(2)
|
|
})
|
|
|
|
it('does not create symlink when store is inside project directory', async () => {
|
|
const projectDir = temporaryDirectory()
|
|
const storeDir = path.join(projectDir, 'node_modules', '.pnpm-store')
|
|
await fs.mkdir(storeDir, { recursive: true })
|
|
|
|
await registerProject(storeDir, projectDir)
|
|
|
|
// The projects directory should not be created since we skipped registration
|
|
const projectsDir = path.join(storeDir, 'projects')
|
|
await expect(fs.readdir(projectsDir)).rejects.toThrow(/ENOENT/)
|
|
})
|
|
})
|
|
|
|
describe('getRegisteredProjects()', () => {
|
|
it('returns empty array when no projects are registered', async () => {
|
|
const storeDir = temporaryDirectory()
|
|
|
|
const projects = await getRegisteredProjects(storeDir)
|
|
expect(projects).toEqual([])
|
|
})
|
|
|
|
it('returns registered project paths', async () => {
|
|
const storeDir = temporaryDirectory()
|
|
const projectDir1 = temporaryDirectory()
|
|
const projectDir2 = temporaryDirectory()
|
|
|
|
await registerProject(storeDir, projectDir1)
|
|
await registerProject(storeDir, projectDir2)
|
|
|
|
const projects = await getRegisteredProjects(storeDir)
|
|
expect(projects.sort()).toEqual([projectDir1, projectDir2].sort())
|
|
})
|
|
|
|
it('cleans up stale entries for deleted projects', async () => {
|
|
const storeDir = temporaryDirectory()
|
|
const projectDir = temporaryDirectory()
|
|
|
|
await registerProject(storeDir, projectDir)
|
|
|
|
// Verify project is registered
|
|
let projects = await getRegisteredProjects(storeDir)
|
|
expect(projects).toEqual([projectDir])
|
|
|
|
// Delete the project directory
|
|
await fs.rm(projectDir, { recursive: true })
|
|
|
|
// getRegisteredProjects should clean up stale entry
|
|
projects = await getRegisteredProjects(storeDir)
|
|
expect(projects).toEqual([])
|
|
|
|
// Verify the symlink was removed
|
|
const projectsDir = path.join(storeDir, 'projects')
|
|
const entries = await fs.readdir(projectsDir)
|
|
expect(entries).toEqual([])
|
|
})
|
|
|
|
it('handles mix of valid and stale entries', async () => {
|
|
const storeDir = temporaryDirectory()
|
|
const validProject = temporaryDirectory()
|
|
const staleProject = temporaryDirectory()
|
|
|
|
await registerProject(storeDir, validProject)
|
|
await registerProject(storeDir, staleProject)
|
|
|
|
// Delete one project
|
|
await fs.rm(staleProject, { recursive: true })
|
|
|
|
const projects = await getRegisteredProjects(storeDir)
|
|
expect(projects).toEqual([validProject])
|
|
})
|
|
})
|
|
})
|