mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-13 11:05:52 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
100 lines
2.5 KiB
TypeScript
100 lines
2.5 KiB
TypeScript
import path from 'node:path'
|
|
|
|
import { expect, jest, test } from '@jest/globals'
|
|
import { STORE_VERSION } from '@pnpm/constants'
|
|
import isWindows from 'is-windows'
|
|
|
|
jest.unstable_mockModule('touch', () => {
|
|
return {
|
|
default: jest.fn(),
|
|
}
|
|
})
|
|
jest.unstable_mockModule('root-link-target', () => {
|
|
const MAPPINGS: Record<string, string> = {
|
|
'/src/workspace/project/tmp': '/',
|
|
'/mnt/project/tmp': '/mnt/project',
|
|
}
|
|
|
|
return {
|
|
rootLinkTarget: async function (file: string): Promise<string> {
|
|
return MAPPINGS[file]
|
|
},
|
|
}
|
|
})
|
|
jest.unstable_mockModule('path-temp', () => {
|
|
return {
|
|
pathTemp: function (dir: string): string {
|
|
return path.join(dir, 'tmp')
|
|
},
|
|
}
|
|
})
|
|
jest.unstable_mockModule('os', () => ({
|
|
default: {
|
|
homedir: () => '/home/user',
|
|
},
|
|
}))
|
|
const fsMock = {
|
|
default: {
|
|
promises: {
|
|
mkdir: () => {},
|
|
unlink: () => {},
|
|
rmdir: () => {},
|
|
rm: () => {},
|
|
},
|
|
rmSync: () => {},
|
|
},
|
|
promises: {
|
|
mkdir: () => {},
|
|
unlink: () => {},
|
|
rmdir: () => {},
|
|
rm: () => {},
|
|
},
|
|
}
|
|
jest.unstable_mockModule('fs', () => fsMock)
|
|
jest.unstable_mockModule('node:fs', () => fsMock)
|
|
jest.unstable_mockModule('can-link', () => {
|
|
const CAN_LINK = new Set([
|
|
'/can-link-to-homedir/tmp=>/home/user/tmp',
|
|
'/mnt/project/tmp=>/mnt/tmp/tmp',
|
|
])
|
|
|
|
return {
|
|
canLink: function (existingPath: string, newPath: string): boolean {
|
|
return CAN_LINK.has(`${existingPath}=>${newPath}`)
|
|
},
|
|
}
|
|
})
|
|
|
|
const { getStorePath } = await import('@pnpm/store.path')
|
|
|
|
const skipOnWindows = isWindows() ? test.skip : test
|
|
|
|
skipOnWindows('when a link can be created to the homedir', async () => {
|
|
expect(await getStorePath({
|
|
pkgRoot: '/can-link-to-homedir',
|
|
pnpmHomeDir: '/local/share/pnpm',
|
|
})).toBe(`/local/share/pnpm/store/${STORE_VERSION}`)
|
|
})
|
|
|
|
skipOnWindows('a link can be created to the root of the drive', async () => {
|
|
expect(await getStorePath({
|
|
pkgRoot: '/src/workspace/project',
|
|
pnpmHomeDir: '/local/share/pnpm',
|
|
})).toBe(`/.pnpm-store/${STORE_VERSION}`)
|
|
})
|
|
|
|
skipOnWindows('a link can be created to the a subdir in the root of the drive', async () => {
|
|
expect(await getStorePath({
|
|
pkgRoot: '/mnt/project',
|
|
pnpmHomeDir: '/local/share/pnpm',
|
|
})).toBe(`/mnt/.pnpm-store/${STORE_VERSION}`)
|
|
})
|
|
|
|
test('fail when pnpm home directory is not defined', async () => {
|
|
expect(() => getStorePath({
|
|
pkgRoot: 'pkgRoot',
|
|
// @ts-expect-error
|
|
pnpmHomeDir: undefined,
|
|
})).toThrow('The pnpm home directory is unknown. Cannot calculate the store directory location.')
|
|
})
|