mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-13 11:05:52 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
90 lines
3.3 KiB
TypeScript
90 lines
3.3 KiB
TypeScript
/// <reference path="../../../__typings__/index.d.ts"/>
|
|
import path from 'node:path'
|
|
|
|
import { expect, test } from '@jest/globals'
|
|
import { findPackages } from '@pnpm/workspace.projects-reader'
|
|
|
|
function compare (a: string | undefined, b: string | undefined) {
|
|
if (a == null) return 1
|
|
if (b == null) return -1
|
|
return a.localeCompare(b)
|
|
}
|
|
|
|
const fixtures = path.join(import.meta.dirname, 'findPackages-fixtures')
|
|
|
|
test('finds package', async () => {
|
|
const root = path.join(fixtures, 'one-pkg')
|
|
const pkgs = await findPackages(root)
|
|
|
|
expect(pkgs).toHaveLength(1)
|
|
expect(pkgs[0].rootDir).toBeDefined()
|
|
expect(pkgs[0].manifest).toBeDefined()
|
|
})
|
|
|
|
test('finds packages by patterns', async () => {
|
|
const root = path.join(fixtures, 'many-pkgs')
|
|
const pkgs = await findPackages(root, { patterns: ['components/**'] })
|
|
|
|
expect(pkgs).toHaveLength(2)
|
|
expect(pkgs[0].rootDir).toBeDefined()
|
|
expect(pkgs[0].manifest).toBeDefined()
|
|
expect(pkgs[1].rootDir).toBeDefined()
|
|
expect(pkgs[1].manifest).toBeDefined()
|
|
expect([pkgs[0].manifest.name, pkgs[1].manifest.name].sort(compare)).toStrictEqual(['component-1', 'component-2'])
|
|
})
|
|
|
|
test('finds packages by * pattern', async () => {
|
|
const root = path.join(fixtures, 'many-pkgs-2')
|
|
const pkgs = await findPackages(root, { patterns: ['.', 'components/*'] })
|
|
|
|
expect(pkgs).toHaveLength(3)
|
|
expect([pkgs[0].manifest.name, pkgs[1].manifest.name, pkgs[2].manifest.name].sort(compare)).toStrictEqual(['component-1', 'component-2', 'many-pkgs-2'])
|
|
})
|
|
|
|
test('finds packages by default pattern', async () => {
|
|
const root = path.join(fixtures, 'many-pkgs-2')
|
|
const pkgs = await findPackages(root)
|
|
|
|
expect(pkgs).toHaveLength(4)
|
|
expect(pkgs.map(({ manifest }) => manifest.name).sort(compare)).toStrictEqual(['component-1', 'component-2', 'foo', 'many-pkgs-2'])
|
|
})
|
|
|
|
test('ignore packages by patterns', async () => {
|
|
const root = path.join(fixtures, 'many-pkgs')
|
|
const pkgs = await findPackages(root, { patterns: ['**', '!libs/**'] })
|
|
|
|
expect(pkgs).toHaveLength(2)
|
|
expect(pkgs[0].rootDir).toBeDefined()
|
|
expect(pkgs[0].manifest).toBeDefined()
|
|
expect(pkgs[1].rootDir).toBeDefined()
|
|
expect(pkgs[1].manifest).toBeDefined()
|
|
expect([pkgs[0].manifest.name, pkgs[1].manifest.name].sort(compare)).toStrictEqual(['component-1', 'component-2'])
|
|
})
|
|
|
|
test('ignore packages by patterns with starts with !/', async () => {
|
|
const root = path.join(fixtures, 'many-pkgs')
|
|
const pkgs = await findPackages(root, { patterns: ['**', '!/libs/**'] })
|
|
|
|
expect(pkgs).toHaveLength(3)
|
|
expect(pkgs[0].rootDir).toBeDefined()
|
|
expect(pkgs[0].manifest).toBeDefined()
|
|
expect(pkgs[1].rootDir).toBeDefined()
|
|
expect(pkgs[1].manifest).toBeDefined()
|
|
expect(pkgs[2].rootDir).toBeDefined()
|
|
expect(pkgs[2].manifest).toBeDefined()
|
|
expect([pkgs[0].manifest.name, pkgs[1].manifest.name, pkgs[2].manifest.name].sort(compare)).toStrictEqual(['component-1', 'component-2', 'foo'])
|
|
})
|
|
|
|
test('json and yaml manifests are also found', async () => {
|
|
const root = path.join(fixtures, 'many-pkgs-with-different-manifest-types')
|
|
const pkgs = await findPackages(root)
|
|
|
|
expect(pkgs).toHaveLength(3)
|
|
expect(pkgs[0].rootDir).toBeDefined()
|
|
expect(pkgs[0].manifest.name).toBe('component-1')
|
|
expect(pkgs[1].rootDir).toBeDefined()
|
|
expect(pkgs[1].manifest.name).toBe('component-2')
|
|
expect(pkgs[2].rootDir).toBeDefined()
|
|
expect(pkgs[2].manifest.name).toBe('foo')
|
|
})
|