mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-13 11:05:52 -04:00
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
178 lines
5.0 KiB
TypeScript
178 lines
5.0 KiB
TypeScript
import fs from 'node:fs'
|
|
import path from 'node:path'
|
|
|
|
import { describe, expect, test } from '@jest/globals'
|
|
import { STORE_VERSION } from '@pnpm/constants'
|
|
import { add, install } from '@pnpm/installing.commands'
|
|
import { prepare, prepareEmpty } from '@pnpm/prepare'
|
|
import { rimrafSync } from '@zkochan/rimraf'
|
|
import delay from 'delay'
|
|
import { loadJsonFileSync } from 'load-json-file'
|
|
|
|
import { DEFAULT_OPTS } from './utils/index.js'
|
|
|
|
const describeOnLinuxOnly = process.platform === 'linux' ? describe : describe.skip
|
|
|
|
test('install fails if no package.json is found', async () => {
|
|
prepareEmpty()
|
|
|
|
await expect(install.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
})).rejects.toThrow(/No package\.json found/)
|
|
})
|
|
|
|
test('install does not fail when a new package is added', async () => {
|
|
prepareEmpty()
|
|
|
|
await add.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['is-positive@1.0.0'])
|
|
|
|
const pkg = loadJsonFileSync<{ dependencies: Record<string, string> }>(path.resolve('package.json'))
|
|
|
|
expect(pkg?.dependencies).toStrictEqual({ 'is-positive': '1.0.0' })
|
|
})
|
|
|
|
test('install with no store integrity validation', async () => {
|
|
prepareEmpty()
|
|
|
|
await add.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['is-positive@1.0.0'])
|
|
|
|
// We should have a short delay before modifying the file in the store.
|
|
// Otherwise pnpm will not consider it to be modified.
|
|
await delay(200)
|
|
const readmePath = path.join(DEFAULT_OPTS.storeDir, STORE_VERSION, 'files/9a/f6af85f55c111108eddf1d7ef7ef224b812e7c7bfabae41c79cf8bc9a910352536963809463e0af2799abacb975f22418a35a1d170055ef3fdc3b2a46ef1c5')
|
|
fs.writeFileSync(readmePath, 'modified', 'utf8')
|
|
|
|
rimrafSync('node_modules')
|
|
|
|
await install.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
verifyStoreIntegrity: false,
|
|
})
|
|
|
|
expect(fs.readFileSync('node_modules/is-positive/readme.md', 'utf8')).toBe('modified')
|
|
})
|
|
|
|
// Covers https://github.com/pnpm/pnpm/issues/7362
|
|
describeOnLinuxOnly('filters optional dependencies based on pnpm.supportedArchitectures.libc', () => {
|
|
test.each([
|
|
['glibc', '@pnpm.e2e+only-linux-x64-glibc@1.0.0', '@pnpm.e2e+only-linux-x64-musl@1.0.0'],
|
|
['musl', '@pnpm.e2e+only-linux-x64-musl@1.0.0', '@pnpm.e2e+only-linux-x64-glibc@1.0.0'],
|
|
])('%p → installs %p, does not install %p', async (libc, found, notFound) => {
|
|
const rootProjectManifest = {
|
|
dependencies: {
|
|
'@pnpm.e2e/support-different-architectures': '1.0.0',
|
|
},
|
|
}
|
|
|
|
prepare(rootProjectManifest)
|
|
|
|
await install.handler({
|
|
...DEFAULT_OPTS,
|
|
rootProjectManifest,
|
|
dir: process.cwd(),
|
|
supportedArchitectures: {
|
|
os: ['linux'],
|
|
cpu: ['x64'],
|
|
libc: [libc],
|
|
},
|
|
})
|
|
|
|
const pkgDirs = fs.readdirSync(path.resolve('node_modules', '.pnpm'))
|
|
expect(pkgDirs).toContain('@pnpm.e2e+support-different-architectures@1.0.0')
|
|
expect(pkgDirs).toContain(found)
|
|
expect(pkgDirs).not.toContain(notFound)
|
|
})
|
|
})
|
|
|
|
describeOnLinuxOnly('filters optional dependencies based on --libc', () => {
|
|
test.each([
|
|
['glibc', '@pnpm.e2e+only-linux-x64-glibc@1.0.0', '@pnpm.e2e+only-linux-x64-musl@1.0.0'],
|
|
['musl', '@pnpm.e2e+only-linux-x64-musl@1.0.0', '@pnpm.e2e+only-linux-x64-glibc@1.0.0'],
|
|
])('%p → installs %p, does not install %p', async (libc, found, notFound) => {
|
|
const rootProjectManifest = {
|
|
dependencies: {
|
|
'@pnpm.e2e/support-different-architectures': '1.0.0',
|
|
},
|
|
}
|
|
|
|
prepare(rootProjectManifest)
|
|
|
|
await install.handler({
|
|
...DEFAULT_OPTS,
|
|
rootProjectManifest,
|
|
dir: process.cwd(),
|
|
supportedArchitectures: {
|
|
libc: [libc],
|
|
},
|
|
})
|
|
|
|
const pkgDirs = fs.readdirSync(path.resolve('node_modules', '.pnpm'))
|
|
expect(pkgDirs).toContain('@pnpm.e2e+support-different-architectures@1.0.0')
|
|
expect(pkgDirs).toContain(found)
|
|
expect(pkgDirs).not.toContain(notFound)
|
|
})
|
|
})
|
|
|
|
test('install Node.js when devEngines runtime is set with onFail=download', async () => {
|
|
const project = prepare({
|
|
devEngines: {
|
|
runtime: {
|
|
name: 'node',
|
|
version: '24.0.0',
|
|
onFail: 'download',
|
|
},
|
|
},
|
|
})
|
|
|
|
await install.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
})
|
|
|
|
project.isExecutable('.bin/node')
|
|
const lockfile = project.readLockfile()
|
|
expect(lockfile.importers['.'].devDependencies).toStrictEqual({
|
|
node: {
|
|
specifier: 'runtime:24.0.0',
|
|
version: 'runtime:24.0.0',
|
|
},
|
|
})
|
|
|
|
await add.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['is-positive@1.0.0'])
|
|
|
|
await add.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
}, ['is-even'])
|
|
})
|
|
|
|
test('do not install Node.js when devEngines runtime is not set to onFail=download', async () => {
|
|
const project = prepare({
|
|
devEngines: {
|
|
runtime: {
|
|
name: 'node',
|
|
version: '24.0.0',
|
|
},
|
|
},
|
|
})
|
|
|
|
await install.handler({
|
|
...DEFAULT_OPTS,
|
|
dir: process.cwd(),
|
|
})
|
|
|
|
const lockfile = project.readLockfile()
|
|
expect(lockfile.importers['.'].devDependencies).toBeUndefined()
|
|
})
|