mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-13 19:16:21 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
105 lines
3.5 KiB
TypeScript
105 lines
3.5 KiB
TypeScript
/// <reference path="../../../__typings__/index.d.ts"/>
|
|
import { promises as fs } from 'node:fs'
|
|
import os from 'node:os'
|
|
import path from 'node:path'
|
|
|
|
import { expect, test } from '@jest/globals'
|
|
import { arrayOfWorkspacePackagesToMap, getContext } from '@pnpm/installing.context'
|
|
import type { ProjectId, ProjectRootDir } from '@pnpm/types'
|
|
|
|
import type { GetContextOptions } from '../src/index.js'
|
|
import { readLockfiles } from '../src/readLockfiles.js'
|
|
|
|
const DEFAULT_OPTIONS: GetContextOptions = {
|
|
allProjects: [],
|
|
autoInstallPeers: true,
|
|
excludeLinksFromLockfile: false,
|
|
extraBinPaths: [],
|
|
force: false,
|
|
lockfileDir: path.join(import.meta.dirname, 'lockfile'),
|
|
nodeLinker: 'isolated',
|
|
hoistPattern: ['*'],
|
|
registries: { default: '' },
|
|
useLockfile: false,
|
|
include: {
|
|
dependencies: true,
|
|
devDependencies: true,
|
|
optionalDependencies: true,
|
|
},
|
|
storeDir: path.join(import.meta.dirname, 'store'),
|
|
virtualStoreDirMaxLength: 120,
|
|
peersSuffixMaxLength: 1000,
|
|
}
|
|
|
|
test('getContext - extendNodePath false', async () => {
|
|
const context = await getContext({
|
|
...DEFAULT_OPTIONS,
|
|
extendNodePath: false,
|
|
})
|
|
expect(context.extraNodePaths).toEqual([])
|
|
})
|
|
|
|
test('getContext - extendNodePath true', async () => {
|
|
const context = await getContext({
|
|
...DEFAULT_OPTIONS,
|
|
extendNodePath: true,
|
|
})
|
|
expect(context.extraNodePaths).toEqual([path.join(context.virtualStoreDir, 'node_modules')])
|
|
})
|
|
|
|
// This is supported for compatibility with Yarn's implementation
|
|
// see https://github.com/pnpm/pnpm/issues/2648
|
|
test('arrayOfWorkspacePackagesToMap() treats private packages with no version as packages with 0.0.0 version', () => {
|
|
const privateProject = {
|
|
rootDir: process.cwd() as ProjectRootDir,
|
|
manifest: {
|
|
name: 'private-pkg',
|
|
},
|
|
}
|
|
expect(arrayOfWorkspacePackagesToMap([privateProject])).toStrictEqual(new Map([
|
|
['private-pkg', new Map([
|
|
['0.0.0', privateProject],
|
|
])],
|
|
]))
|
|
})
|
|
|
|
test('readLockfiles() throws on incompatible lockfile in CI when frozenLockfile is true', async () => {
|
|
const lockfileDir = await fs.mkdtemp(path.join(os.tmpdir(), 'pnpm-get-context-'))
|
|
await fs.writeFile(path.join(lockfileDir, 'pnpm-lock.yaml'), 'lockfileVersion: 1.0\nimporters:\n .:\n specifiers: {}\n')
|
|
|
|
await expect(readLockfiles({
|
|
autoInstallPeers: true,
|
|
excludeLinksFromLockfile: false,
|
|
peersSuffixMaxLength: 1000,
|
|
ci: true,
|
|
force: false,
|
|
frozenLockfile: true,
|
|
projects: [{ id: '.' as ProjectId, rootDir: lockfileDir as ProjectRootDir }],
|
|
lockfileDir,
|
|
registry: 'https://registry.npmjs.org/',
|
|
useLockfile: true,
|
|
internalPnpmDir: path.join(lockfileDir, 'node_modules', '.pnpm'),
|
|
})).rejects.toMatchObject({ code: 'ERR_PNPM_LOCKFILE_BREAKING_CHANGE' })
|
|
})
|
|
|
|
test('readLockfiles() ignores incompatible lockfile in CI when frozenLockfile is false', async () => {
|
|
const lockfileDir = await fs.mkdtemp(path.join(os.tmpdir(), 'pnpm-get-context-'))
|
|
await fs.writeFile(path.join(lockfileDir, 'pnpm-lock.yaml'), 'lockfileVersion: 1.0\nimporters:\n .:\n specifiers: {}\n')
|
|
|
|
const context = await readLockfiles({
|
|
autoInstallPeers: true,
|
|
excludeLinksFromLockfile: false,
|
|
peersSuffixMaxLength: 1000,
|
|
ci: true,
|
|
force: false,
|
|
frozenLockfile: false,
|
|
projects: [{ id: '.' as ProjectId, rootDir: lockfileDir as ProjectRootDir }],
|
|
lockfileDir,
|
|
registry: 'https://registry.npmjs.org/',
|
|
useLockfile: true,
|
|
internalPnpmDir: path.join(lockfileDir, 'node_modules', '.pnpm'),
|
|
})
|
|
|
|
expect(context.existsWantedLockfile).toBe(false)
|
|
})
|