Files
pnpm/store/cafs/test/writeBufferToCafs.test.ts
Zoltan Kochan 187049055f chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2 (#11332)
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2

- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
  20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
  `it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
  instead of relying on `@types/jest` ambient declarations. Under the
  new tsgo build, `import { jest } from '@jest/globals'` shadows the
  ambient `jest` namespace, breaking `@types/jest`'s `declare var
  describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
  now import from it, and add `@types/node` to packages that need it
  but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
  no longer globally available.

* chore: fix remaining tsgo type-strictness errors

- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
  toStrictEqual / toEqual; @jest/globals rejects the typed objects
  (which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
  for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
  return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
  expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
  for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
  that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
  two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.

* chore: address Copilot review on #11332

- Move misplaced `@jest/globals` imports to the top import block in
  checkEngine, run.ts, and workspace/root-finder tests where the
  script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
  in bins/linker, lockfile/fs, and resolving/local-resolver tests with
  `await expect(x()).rejects.toMatchObject({...})`. The old pattern
  swallowed an unrelated `throw` if the under-test call silently
  succeeded, which would fail on the catch-block assertion with a
  misleading message.
2026-04-21 22:50:40 +02:00

213 lines
8.6 KiB
TypeScript

import { execSync } from 'node:child_process'
import crypto from 'node:crypto'
import fs from 'node:fs'
import path from 'node:path'
import { fileURLToPath, pathToFileURL } from 'node:url'
import { describe, expect, it } from '@jest/globals'
import { temporaryDirectory } from 'tempy'
import { writeBufferToCafs } from '../src/writeBufferToCafs.js'
const testDir = path.dirname(fileURLToPath(import.meta.url))
describe('writeBufferToCafs', () => {
it('should write directly to the final CAS path', () => {
const storeDir = temporaryDirectory()
const fileDest = 'abc'
const buffer = Buffer.from('abc')
const fullFileDest = path.join(storeDir, fileDest)
const digest = crypto.hash('sha512', buffer, 'hex')
writeBufferToCafs(new Map(), storeDir, buffer, fileDest, 420, { digest, algorithm: 'sha512' })
expect(fs.readFileSync(fullFileDest, 'utf8')).toBe('abc')
})
it('should handle EEXIST when the existing file has correct integrity', () => {
const storeDir = temporaryDirectory()
const fileDest = 'abc'
const buffer = Buffer.from('abc')
const fullFileDest = path.join(storeDir, fileDest)
const digest = crypto.hash('sha512', buffer, 'hex')
const integrity = { digest, algorithm: 'sha512' }
const locker = new Map<string, number>()
// Simulate another process creating the file before our exclusive write
fs.mkdirSync(path.dirname(fullFileDest), { recursive: true })
fs.writeFileSync(fullFileDest, buffer)
// Our call should find the file via stat, verify integrity, and cache it
const result = writeBufferToCafs(locker, storeDir, buffer, fileDest, 420, integrity)
expect(result.filePath).toBe(fullFileDest)
expect(locker.has(fullFileDest)).toBe(true)
expect(fs.readFileSync(fullFileDest, 'utf8')).toBe('abc')
})
it('should overwrite an existing file with wrong integrity without deleting it first', () => {
const storeDir = temporaryDirectory()
const fileDest = 'abc'
const buffer = Buffer.from('abc')
const fullFileDest = path.join(storeDir, fileDest)
const digest = crypto.hash('sha512', buffer, 'hex')
const integrity = { digest, algorithm: 'sha512' }
const locker = new Map<string, number>()
// Create a file with wrong content (simulating corruption or partial write)
fs.mkdirSync(path.dirname(fullFileDest), { recursive: true })
fs.writeFileSync(fullFileDest, 'wrong content')
// Should detect mismatch and overwrite (not delete + recreate)
const result = writeBufferToCafs(locker, storeDir, buffer, fileDest, 420, integrity)
expect(result.filePath).toBe(fullFileDest)
expect(locker.has(fullFileDest)).toBe(true)
expect(fs.readFileSync(fullFileDest, 'utf8')).toBe('abc')
})
it('should handle concurrent writes from multiple processes without corruption', () => {
const storeDir = temporaryDirectory()
const fileDest = 'abc'
const content = crypto.randomBytes(256 * 1024)
const fullFileDest = path.join(storeDir, fileDest)
const digest = crypto.hash('sha512', content, 'hex')
const results = runConcurrentWorkers(storeDir, fileDest, content, digest)
expect(results).toHaveLength(8)
for (const result of results) {
expect(result.filePath).toBe(fullFileDest)
expect(typeof result.checkedAt).toBe('number')
}
const finalContent = fs.readFileSync(fullFileDest)
expect(finalContent).toHaveLength(content.length)
expect(crypto.hash('sha512', finalContent, 'hex')).toBe(digest)
})
it('should recover from a corrupt file when multiple processes write concurrently', () => {
const storeDir = temporaryDirectory()
const fileDest = 'abc'
const content = crypto.randomBytes(256 * 1024)
const fullFileDest = path.join(storeDir, fileDest)
const digest = crypto.hash('sha512', content, 'hex')
// Pre-seed a corrupt file (simulates a previous process that crashed mid-write)
fs.mkdirSync(path.dirname(fullFileDest), { recursive: true })
fs.writeFileSync(fullFileDest, 'partial garbage from a crashed writer')
const results = runConcurrentWorkers(storeDir, fileDest, content, digest)
// All workers must succeed despite the pre-existing corrupt file
expect(results).toHaveLength(8)
for (const result of results) {
expect(result.filePath).toBe(fullFileDest)
expect(typeof result.checkedAt).toBe('number')
}
// Final file must have correct content
const finalContent = fs.readFileSync(fullFileDest)
expect(finalContent).toHaveLength(content.length)
expect(crypto.hash('sha512', finalContent, 'hex')).toBe(digest)
})
it('should recover from a truncated file (simulating crash mid-write)', () => {
const storeDir = temporaryDirectory()
const fileDest = 'abc'
const content = crypto.randomBytes(256 * 1024)
const fullFileDest = path.join(storeDir, fileDest)
const digest = crypto.hash('sha512', content, 'hex')
// Pre-seed a truncated file: first 1 KB of the correct content
// (simulates a process that started writing correctly but crashed)
fs.mkdirSync(path.dirname(fullFileDest), { recursive: true })
fs.writeFileSync(fullFileDest, content.subarray(0, 1024))
const results = runConcurrentWorkers(storeDir, fileDest, content, digest)
expect(results).toHaveLength(8)
for (const result of results) {
expect(result.filePath).toBe(fullFileDest)
}
const finalContent = fs.readFileSync(fullFileDest)
expect(finalContent).toHaveLength(content.length)
expect(crypto.hash('sha512', finalContent, 'hex')).toBe(digest)
})
it('should populate the locker cache when a file already exists with correct integrity', () => {
const storeDir = temporaryDirectory()
const fileDest = 'abc'
const buffer = Buffer.from('abc')
const digest = crypto.hash('sha512', buffer, 'hex')
const integrity = { digest, algorithm: 'sha512' }
const locker = new Map<string, number>()
// First write creates the file
writeBufferToCafs(locker, storeDir, buffer, fileDest, 420, integrity)
// Clear the locker to simulate a fresh lookup
locker.clear()
// Second call should find the file on disk and cache it
const result = writeBufferToCafs(locker, storeDir, buffer, fileDest, 420, integrity)
const fullFileDest = path.join(storeDir, fileDest)
expect(locker.get(fullFileDest)).toBe(result.checkedAt)
// Third call should return from locker cache without hitting disk
const cached = writeBufferToCafs(locker, storeDir, buffer, fileDest, 420, integrity)
expect(cached.checkedAt).toBe(result.checkedAt)
})
})
function runConcurrentWorkers (
storeDir: string,
fileDest: string,
content: Buffer,
digest: string,
numWorkers = 8
): Array<{ filePath: string, checkedAt: number }> {
const libUrl = pathToFileURL(path.resolve(testDir, '../lib/writeBufferToCafs.js')).href
const resultsDir = path.join(storeDir, '_results')
fs.mkdirSync(resultsDir, { recursive: true })
const workerScript = path.join(storeDir, '_worker.mjs')
fs.writeFileSync(workerScript, `
import fs from 'node:fs';
import path from 'node:path';
import { writeBufferToCafs } from ${JSON.stringify(libUrl)};
const content = Buffer.from(${JSON.stringify(content.toString('base64'))}, 'base64');
const locker = new Map();
const result = writeBufferToCafs(locker, ${JSON.stringify(storeDir)}, content, ${JSON.stringify(fileDest)}, 420, { digest: ${JSON.stringify(digest)}, algorithm: 'sha512' });
fs.writeFileSync(path.join(${JSON.stringify(resultsDir)}, process.pid + '.json'), JSON.stringify(result));
`)
const spawnerScript = path.join(storeDir, '_spawner.mjs')
fs.writeFileSync(spawnerScript, `
import { spawn } from 'node:child_process';
const N = ${numWorkers};
const workerScript = process.argv[2];
const children = [];
for (let i = 0; i < N; i++) {
children.push(new Promise((resolve, reject) => {
const p = spawn(process.execPath, [workerScript], { stdio: 'pipe' });
let stderr = '';
p.stderr.on('data', d => { stderr += d; });
p.on('exit', code => code === 0 ? resolve() : reject(new Error('Process ' + i + ' exited ' + code + ': ' + stderr)));
}));
}
const results = await Promise.allSettled(children);
const failures = results.filter(r => r.status === 'rejected');
if (failures.length > 0) {
for (const f of failures) console.error(f.reason.message);
process.exit(1);
}
`)
execSync(`node ${JSON.stringify(spawnerScript)} ${JSON.stringify(workerScript)}`, {
timeout: 30000,
stdio: 'pipe',
})
const resultFiles = fs.readdirSync(resultsDir)
return resultFiles.map(file =>
JSON.parse(fs.readFileSync(path.join(resultsDir, file), 'utf8'))
)
}