mirror of
https://github.com/pnpm/pnpm.git
synced 2026-06-28 09:55:39 -04:00
e3f2be02f0
GitHub's merge queue runs each entry on a temporary `gh-readonly-queue/**` branch, whose creation also fires a `push` event. For `ci.yml` (`on: [push, pull_request, merge_group]`) that produced two TS CI runs for the identical commit: one `push`, one `merge_group`. Both reach the reusable `test.yml`, whose concurrency group keys on `github.ref` with `cancel-in-progress: true`. Since the two runs share `github.ref`, their per-(platform, node, chunk) test jobs land in the same group and cancel each other. The Windows shards are gated only on compile-and-lint + build-pnpr, so both runs' Windows jobs start near-simultaneously and reliably collide. The `merge_group` run — the only one the queue's required `TS CI / Success` check reads — lost the race, so its cancelled test jobs failed `Success` and ejected the PR for "failed status checks". Restrict the `push` trigger to ignore `gh-readonly-queue/**` so only the `merge_group` run executes for queued commits. `pacquet-ci.yml` already scopes push to `main` and was unaffected. Apply the same `branches-ignore` to `audit.yml` to drop its redundant push run on those branches.
221 lines
8.3 KiB
YAML
221 lines
8.3 KiB
YAML
name: TS CI
|
|
|
|
on:
|
|
push:
|
|
# The merge queue runs each entry on a temporary `gh-readonly-queue/**`
|
|
# branch, whose creation also fires a `push` event. That duplicate run
|
|
# shares `github.ref` (hence the test.yml concurrency group) with the
|
|
# `merge_group` run for the same commit, so with `cancel-in-progress`
|
|
# the two cancel each other's test jobs — failing `TS CI / Success` and
|
|
# ejecting the PR. Only the `merge_group` run reports to the queue, so
|
|
# skip `push` for those branches.
|
|
branches-ignore:
|
|
- 'gh-readonly-queue/**'
|
|
pull_request:
|
|
merge_group:
|
|
|
|
permissions:
|
|
contents: read # to fetch code (actions/checkout)
|
|
|
|
jobs:
|
|
changes:
|
|
name: TS CI / Detect Changes
|
|
runs-on: ubuntu-latest
|
|
permissions:
|
|
contents: read
|
|
pull-requests: read
|
|
outputs:
|
|
ts: ${{ steps.force.outputs.ts || steps.filter.outputs.ts }}
|
|
steps:
|
|
# In the merge queue the full suite must run: `TS CI / Compile & Lint`
|
|
# is itself a required check, and a skipped job never reports its
|
|
# context, which would leave the queue waiting forever. Forcing
|
|
# detection true also tests the merged result, which is the point of
|
|
# the queue.
|
|
- name: Force TS CI for merge queue
|
|
if: github.event_name == 'merge_group'
|
|
id: force
|
|
run: echo "ts=true" >> "$GITHUB_OUTPUT"
|
|
- uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
|
|
if: github.event_name != 'merge_group'
|
|
with:
|
|
persist-credentials: false
|
|
- uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
|
|
if: github.event_name != 'merge_group'
|
|
id: filter
|
|
with:
|
|
# The TypeScript pnpm stack lives under pnpm11/, plus the
|
|
# workspace-root tooling that drives its build/lint/test.
|
|
filters: |
|
|
ts:
|
|
- 'pnpm11/**'
|
|
- '.meta-updater/**'
|
|
- '__patches__/**'
|
|
- 'package.json'
|
|
- 'pnpm-workspace.yaml'
|
|
- 'pnpm-lock.yaml'
|
|
- '.pnpmfile.cjs'
|
|
- 'eslint.config.mjs'
|
|
- 'tsconfig.lint.json'
|
|
- 'cspell.json'
|
|
- '.github/workflows/ci.yml'
|
|
- '.github/workflows/test.yml'
|
|
- '.github/workflows/build-pnpr.yml'
|
|
- '.github/scripts/**'
|
|
|
|
compile-and-lint:
|
|
needs: changes
|
|
# Run only when TypeScript-relevant files changed. Also skip
|
|
# pull_request events from PRs in the same repo to prevent duplicate
|
|
# build jobs (the push event already covers them).
|
|
# Exception: chore/update-lockfile PRs (created by automation with GITHUB_TOKEN, which doesn't trigger push events)
|
|
if: ${{ !cancelled() && needs.changes.outputs.ts == 'true' && (github.event_name == 'push' || github.event_name == 'merge_group' || github.event.pull_request.head.repo.full_name != github.repository || github.head_ref == 'chore/update-lockfile') }}
|
|
|
|
name: TS CI / Compile & Lint
|
|
runs-on: ubuntu-latest
|
|
|
|
steps:
|
|
- name: Checkout Commit
|
|
uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6.0.3
|
|
with:
|
|
persist-credentials: false
|
|
- name: Install pnpm
|
|
uses: pnpm/setup@b1cac37306e39c21283b9dd6cb0ac288fb35ba6b
|
|
- name: Compile TypeScript
|
|
run: pn compile-only
|
|
- name: Lint
|
|
run: pn lint
|
|
- name: Package compiled artifacts
|
|
shell: bash
|
|
run: |
|
|
mapfile -d '' -t lib_dirs < <(find . -type d -name lib -not -path '*/node_modules/*' -print0)
|
|
mapfile -d '' -t tsbuildinfo_files < <(find . -name 'tsconfig.tsbuildinfo' -not -path '*/node_modules/*' -print0)
|
|
tar -czf compiled.tar.gz --exclude='node_modules' "${lib_dirs[@]}" "${tsbuildinfo_files[@]}" pnpm11/pnpm/dist
|
|
- name: Upload compiled artifacts
|
|
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
|
|
with:
|
|
name: compiled-packages
|
|
path: compiled.tar.gz
|
|
retention-days: 1
|
|
|
|
# Build the pnpr binaries once per OS via a per-OS reusable workflow (not a
|
|
# single matrix job) so each platform's test jobs gate only on their own
|
|
# build. `needs` can only target a whole job, never an individual matrix
|
|
# leg, so a matrix build would make the ubuntu tests wait for the slower
|
|
# windows build and vice versa.
|
|
build-pnpr-linux:
|
|
needs: changes
|
|
if: ${{ !cancelled() && needs.changes.outputs.ts == 'true' && (github.event_name == 'push' || github.event_name == 'merge_group' || github.event.pull_request.head.repo.full_name != github.repository || github.head_ref == 'chore/update-lockfile') }}
|
|
name: TS CI / Build pnpr
|
|
uses: ./.github/workflows/build-pnpr.yml
|
|
with:
|
|
os: ubuntu-latest
|
|
|
|
build-pnpr-windows:
|
|
needs: changes
|
|
if: ${{ !cancelled() && needs.changes.outputs.ts == 'true' && (github.event_name == 'push' || github.event_name == 'merge_group' || github.event.pull_request.head.repo.full_name != github.repository || github.head_ref == 'chore/update-lockfile') }}
|
|
name: TS CI / Build pnpr
|
|
uses: ./.github/workflows/build-pnpr.yml
|
|
with:
|
|
os: windows-latest
|
|
|
|
test-smoke:
|
|
name: TS CI / Test / ubuntu
|
|
needs: [compile-and-lint, build-pnpr-linux]
|
|
uses: ./.github/workflows/test.yml
|
|
with:
|
|
node: '24.0.0'
|
|
node_major: '24'
|
|
platform: ubuntu-latest
|
|
garnet: true
|
|
secrets:
|
|
GARNET_API_TOKEN: ${{ secrets.GARNET_API_TOKEN }}
|
|
|
|
test:
|
|
name: TS CI / Test / ${{ matrix.platform_label }}
|
|
needs: test-smoke
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
- node: '22.13.0'
|
|
node_major: '22'
|
|
platform: ubuntu-latest
|
|
platform_label: ubuntu
|
|
test_chunk: '1'
|
|
test_chunk_total: '1'
|
|
- node: '26.3.1'
|
|
node_major: '26'
|
|
platform: ubuntu-latest
|
|
platform_label: ubuntu
|
|
test_chunk: '1'
|
|
test_chunk_total: '1'
|
|
uses: ./.github/workflows/test.yml
|
|
with:
|
|
node: ${{ matrix.node }}
|
|
node_major: ${{ matrix.node_major }}
|
|
platform: ${{ matrix.platform }}
|
|
test_chunk: ${{ matrix.test_chunk }}
|
|
test_chunk_total: ${{ matrix.test_chunk_total }}
|
|
|
|
# Windows is the slowest platform. Gate it only on compile-and-lint so its
|
|
# shards run in parallel with the ubuntu smoke job, instead of waiting for
|
|
# the smoke job like the other Node.js versions do.
|
|
test-windows:
|
|
name: TS CI / Test / ${{ matrix.platform_label }}
|
|
needs: [compile-and-lint, build-pnpr-windows]
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
include:
|
|
- node: '22.13.0'
|
|
node_major: '22'
|
|
platform: windows-latest
|
|
platform_label: windows 1/3
|
|
test_chunk: '1'
|
|
test_chunk_total: '3'
|
|
- node: '22.13.0'
|
|
node_major: '22'
|
|
platform: windows-latest
|
|
platform_label: windows 2/3
|
|
test_chunk: '2'
|
|
test_chunk_total: '3'
|
|
- node: '22.13.0'
|
|
node_major: '22'
|
|
platform: windows-latest
|
|
platform_label: windows 3/3
|
|
test_chunk: '3'
|
|
test_chunk_total: '3'
|
|
uses: ./.github/workflows/test.yml
|
|
with:
|
|
node: ${{ matrix.node }}
|
|
node_major: ${{ matrix.node_major }}
|
|
platform: ${{ matrix.platform }}
|
|
test_chunk: ${{ matrix.test_chunk }}
|
|
test_chunk_total: ${{ matrix.test_chunk_total }}
|
|
|
|
# Single aggregate gate — the only TS CI context branch protection needs
|
|
# to require. Listing the individual jobs as required checks does not
|
|
# work: they skip on non-TypeScript PRs, and a matrix job skipped at the
|
|
# job level never expands its `${{ matrix.* }}` name, so the per-platform
|
|
# contexts it would report never appear and the PR blocks forever waiting
|
|
# for them. This job always runs (it reports under a static name in every
|
|
# state) and fails only if a dependency actually failed or was cancelled —
|
|
# skipped dependencies count as a pass.
|
|
success:
|
|
name: TS CI / Success
|
|
if: ${{ always() }}
|
|
needs:
|
|
- changes
|
|
- compile-and-lint
|
|
- build-pnpr-linux
|
|
- build-pnpr-windows
|
|
- test-smoke
|
|
- test
|
|
- test-windows
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Fail if any dependency failed or was cancelled
|
|
if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}
|
|
run: exit 1
|