Rust CI / Clippy ran on Ubuntu only, so no job linted the #[cfg(windows)]
half of the workspace. The test job builds that code, which type-checks it
but runs no lints.
Add a windows row to the Clippy matrix and clear what it found: a raw-pointer
borrow of the console-mode out-parameter, an unused type parameter on the
Windows stub of link_symlinked_executable, a redundant clone in the cmd-shim
tests, and imports and test helpers that only unix code reaches.
Two findings come from Windows's wider PathBuf. PackageManifest measures 200
bytes on Linux and 208 on Windows, which crosses large_enum_variant's
threshold, so GateManifest::Found boxes it. result_large_err is allowed
workspace-wide instead: with large-error-threshold lowered on Linux, error
enums across ten crates sit just under the 128-byte limit, and the same
8-byte creep pushes them over. Boxing every one of them is its own refactor.
zizmor needs the benchmark workflow's checks: write scoped to the job that
posts a check, since a fork PR has advanced-security off and fails on any
finding.
Fixespnpm/pnpm#14801.
Ayush Singh
3a99eaea72