mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-13 02:55:56 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
51 lines
2.0 KiB
TypeScript
51 lines
2.0 KiB
TypeScript
import { expect, test } from '@jest/globals'
|
|
import { FetchError, PnpmError } from '@pnpm/error'
|
|
|
|
test('PnpmError exposes cause when provided', () => {
|
|
const cause = new Error('original failure')
|
|
const error = new PnpmError('TEST_CODE', 'something went wrong', { cause })
|
|
expect(error.cause).toBe(cause)
|
|
expect(error.message).toBe('something went wrong')
|
|
expect(error.code).toBe('ERR_PNPM_TEST_CODE')
|
|
})
|
|
|
|
test('PnpmError cause is undefined when omitted', () => {
|
|
const error = new PnpmError('TEST_CODE', 'something went wrong')
|
|
expect(error.cause).toBeUndefined()
|
|
})
|
|
|
|
test('PnpmError cause works with non-Error values', () => {
|
|
const error = new PnpmError('TEST_CODE', 'something went wrong', { cause: 'string cause' })
|
|
expect(error.cause).toBe('string cause')
|
|
})
|
|
|
|
test('FetchError escapes auth tokens', () => {
|
|
const error = new FetchError(
|
|
{ url: 'https://foo.com', authHeaderValue: 'Bearer 00000000000000000000' },
|
|
{ status: 401, statusText: 'Unauthorized' }
|
|
)
|
|
expect(error.message).toBe('GET https://foo.com: Unauthorized - 401')
|
|
expect(error.hint).toBe('An authorization header was used: Bearer 0000[hidden]')
|
|
expect(error.request.authHeaderValue).toBe('Bearer 0000[hidden]')
|
|
})
|
|
|
|
test('FetchError escapes short auth tokens', () => {
|
|
const error = new FetchError(
|
|
{ url: 'https://foo.com', authHeaderValue: 'Bearer 0000000000' },
|
|
{ status: 401, statusText: 'Unauthorized' }
|
|
)
|
|
expect(error.message).toBe('GET https://foo.com: Unauthorized - 401')
|
|
expect(error.hint).toBe('An authorization header was used: Bearer [hidden]')
|
|
expect(error.request.authHeaderValue).toBe('Bearer [hidden]')
|
|
})
|
|
|
|
test('FetchError escapes non-standard auth header', () => {
|
|
const error = new FetchError(
|
|
{ url: 'https://foo.com', authHeaderValue: '0000000000' },
|
|
{ status: 401, statusText: 'Unauthorized' }
|
|
)
|
|
expect(error.message).toBe('GET https://foo.com: Unauthorized - 401')
|
|
expect(error.hint).toBe('An authorization header was used: [hidden]')
|
|
expect(error.request.authHeaderValue).toBe('[hidden]')
|
|
})
|