Files
pnpm/installing/commands/test/remove/remove.ts
Zoltan Kochan 187049055f chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2 (#11332)
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2

- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
  20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
  `it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
  instead of relying on `@types/jest` ambient declarations. Under the
  new tsgo build, `import { jest } from '@jest/globals'` shadows the
  ambient `jest` namespace, breaking `@types/jest`'s `declare var
  describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
  now import from it, and add `@types/node` to packages that need it
  but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
  no longer globally available.

* chore: fix remaining tsgo type-strictness errors

- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
  toStrictEqual / toEqual; @jest/globals rejects the typed objects
  (which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
  for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
  return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
  expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
  for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
  that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
  two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.

* chore: address Copilot review on #11332

- Move misplaced `@jest/globals` imports to the top import block in
  checkEngine, run.ts, and workspace/root-finder tests where the
  script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
  in bins/linker, lockfile/fs, and resolving/local-resolver tests with
  `await expect(x()).rejects.toMatchObject({...})`. The old pattern
  swallowed an unrelated `throw` if the under-test call silently
  succeeded, which would fail on the catch-block assertion with a
  misleading message.
2026-04-21 22:50:40 +02:00

164 lines
4.8 KiB
TypeScript

import { expect, test } from '@jest/globals'
import type { PnpmError } from '@pnpm/error'
import { remove } from '@pnpm/installing.commands'
import { prepare } from '@pnpm/prepare'
import { DEFAULT_OPTS } from '../utils/index.js'
test('remove should fail if no dependency is specified for removal', async () => {
prepare()
let err!: PnpmError
try {
await remove.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
}, [])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_MUST_REMOVE_SOMETHING')
expect(err.message).toBe('At least one dependency name should be specified for removal')
})
test('remove should fail if the project has no dependencies at all', async () => {
prepare()
{
let err!: PnpmError
try {
await remove.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
}, ['express'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_CANNOT_REMOVE_MISSING_DEPS')
expect(err.message).toBe("Cannot remove 'express': project has no dependencies of any kind")
}
{
let err!: PnpmError
try {
await remove.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
saveProd: true,
}, ['express'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_CANNOT_REMOVE_MISSING_DEPS')
expect(err.message).toBe("Cannot remove 'express': project has no 'dependencies'")
}
{
let err!: PnpmError
try {
await remove.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
saveDev: true,
}, ['express'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_CANNOT_REMOVE_MISSING_DEPS')
expect(err.message).toBe("Cannot remove 'express': project has no 'devDependencies'")
}
{
let err!: PnpmError
try {
await remove.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
saveOptional: true,
}, ['express'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_CANNOT_REMOVE_MISSING_DEPS')
expect(err.message).toBe("Cannot remove 'express': project has no 'optionalDependencies'")
}
})
test('remove should fail if the project does not have one of the removed dependencies', async () => {
prepare({
dependencies: {
'prod-dep-1': '1.0.0',
'prod-dep-2': '1.0.0',
},
devDependencies: {
'dev-dep-1': '1.0.0',
'dev-dep-2': '1.0.0',
},
optionalDependencies: {
'optional-dep-1': '1.0.0',
'optional-dep-2': '1.0.0',
},
})
{
let err!: PnpmError
try {
await remove.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
saveProd: true,
}, ['prod-dep-1', 'dev-dep-1', 'optional-dep-1'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_CANNOT_REMOVE_MISSING_DEPS')
expect(err.message).toBe('Cannot remove \'dev-dep-1\', \'optional-dep-1\': \
no such dependencies found in \'dependencies\'')
expect(err.hint).toBe('Available dependencies: prod-dep-1, prod-dep-2')
}
{
let err!: PnpmError
try {
await remove.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
saveDev: true,
}, ['prod-dep-1', 'dev-dep-1', 'optional-dep-1'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_CANNOT_REMOVE_MISSING_DEPS')
expect(err.message).toBe('Cannot remove \'prod-dep-1\', \'optional-dep-1\': \
no such dependencies found in \'devDependencies\'')
expect(err.hint).toBe('Available dependencies: dev-dep-1, dev-dep-2')
}
{
let err!: PnpmError
try {
await remove.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
saveOptional: true,
}, ['prod-dep-1', 'dev-dep-1', 'optional-dep-1'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_CANNOT_REMOVE_MISSING_DEPS')
expect(err.message).toBe('Cannot remove \'prod-dep-1\', \'dev-dep-1\': \
no such dependencies found in \'optionalDependencies\'')
expect(err.hint).toBe('Available dependencies: optional-dep-1, optional-dep-2')
}
{
let err!: PnpmError
try {
await remove.handler({
...DEFAULT_OPTS,
dir: process.cwd(),
}, ['express', 'prod-dep-1', 'dev-dep-1', 'optional-dep-1'])
} catch (_err: any) { // eslint-disable-line
err = _err
}
expect(err.code).toBe('ERR_PNPM_CANNOT_REMOVE_MISSING_DEPS')
expect(err.message).toBe("Cannot remove 'express': no such dependency found")
expect(err.hint).toBe('Available dependencies: dev-dep-1, dev-dep-2, \
prod-dep-1, prod-dep-2, optional-dep-1, optional-dep-2')
}
})