mirror of
https://github.com/pnpm/pnpm.git
synced 2026-05-13 02:55:56 -04:00
187049055f
* chore: upgrade @typescript/native-preview to 7.0.0-dev.20260421.2
- Add explicit `types: ["node"]` to the shared tsconfig because tsgo
20260421 no longer auto-acquires `@types/*` from `node_modules`.
- Refactor test files to explicitly import jest globals (`describe`,
`it`, `test`, `expect`, `beforeEach`, etc.) from `@jest/globals`
instead of relying on `@types/jest` ambient declarations. Under the
new tsgo build, `import { jest } from '@jest/globals'` shadows the
ambient `jest` namespace, breaking `@types/jest`'s `declare var
describe: jest.Describe;` globals.
- Add `@jest/globals` to each package's devDependencies where tests
now import from it, and add `@types/node` to packages that need it
but were relying on hoisted resolution.
- Replace `fail()` calls with `throw new Error(...)` since `fail` is
no longer globally available.
* chore: fix remaining tsgo type-strictness errors
- Strip `as <PnpmType>` casts on objects passed to toMatchObject /
toStrictEqual / toEqual; @jest/globals rejects the typed objects
(which include AsymmetricMatchers) vs. the repo-specific type.
- Type `jest.fn<...>()` explicitly where the mock's signature matters
for toHaveBeenCalledWith.
- Replace `beforeEach(() => X)` with `beforeEach(() => { X })` so the
return value is void, as the stricter jest typing requires.
- Use `expect.objectContaining({...})` in one place where the full
expected object triggered stricter type resolution.
- Cast `prompt.mock.calls` arg through `as unknown as Record<...>[]`
for patch.test.ts's nested-array matchers.
- Fix off-by-one `<reference path>` in pnpm/test/getConfig.test.ts
that only surfaced now.
- Move `@jest/globals` from devDependencies to dependencies in the
two `__utils__` packages that import it from `src/`.
- Clean up unused imports from the @jest/globals migration.
* chore: address Copilot review on #11332
- Move misplaced `@jest/globals` imports to the top import block in
checkEngine, run.ts, and workspace/root-finder tests where the
script dropped them below executable code.
- Replace `try { await x(); throw new Error('should have thrown') } catch`
in bins/linker, lockfile/fs, and resolving/local-resolver tests with
`await expect(x()).rejects.toMatchObject({...})`. The old pattern
swallowed an unrelated `throw` if the under-test call silently
succeeded, which would fail on the catch-block assertion with a
misleading message.
115 lines
2.9 KiB
TypeScript
115 lines
2.9 KiB
TypeScript
import { describe, expect, it } from '@jest/globals'
|
|
import { DedupeCheckIssuesError, dedupeDiffCheck } from '@pnpm/installing.dedupe.check'
|
|
import type { LockfileObject } from '@pnpm/lockfile.types'
|
|
import type { DepPath, ProjectId } from '@pnpm/types'
|
|
|
|
describe('dedupeDiffCheck', () => {
|
|
it('should have no changes for same lockfile', () => {
|
|
const lockfile: LockfileObject = {
|
|
importers: {
|
|
['.' as ProjectId]: {
|
|
specifiers: {},
|
|
},
|
|
},
|
|
lockfileVersion: 'testLockfileVersion',
|
|
}
|
|
|
|
expect(() => {
|
|
dedupeDiffCheck(lockfile, lockfile)
|
|
}).not.toThrow()
|
|
})
|
|
|
|
it('throws DedupeCheckIssuesError on changes', () => {
|
|
const before: LockfileObject = {
|
|
importers: {
|
|
['packages/a' as ProjectId]: {
|
|
specifiers: {
|
|
'is-positive': '^3.0.0',
|
|
},
|
|
dependencies: {
|
|
'is-positive': '3.0.0',
|
|
},
|
|
},
|
|
['packages/b' as ProjectId]: {
|
|
specifiers: {
|
|
'is-positive': '^3.1.0',
|
|
},
|
|
dependencies: {
|
|
'is-positive': '3.1.0',
|
|
},
|
|
},
|
|
},
|
|
packages: {
|
|
['is-positive@3.0.0' as DepPath]: {
|
|
resolution: {
|
|
integrity: 'sha512-JDkaKp5jWv24ZaFuYDKTcBrC/wBOHdjhzLDkgrrkJD/j7KqqXsGcAkex336qHoOFEajMy7bYqUgm0KH9/MzQvw==',
|
|
},
|
|
engines: {
|
|
node: '>=0.10.0',
|
|
},
|
|
},
|
|
['is-positive@3.1.0' as DepPath]: {
|
|
resolution: {
|
|
integrity: 'sha1-hX21hKG6XRyymAUn/DtsQ103sP0=',
|
|
},
|
|
engines: {
|
|
node: '>=0.10.0',
|
|
},
|
|
},
|
|
},
|
|
lockfileVersion: 'testLockfileVersion',
|
|
}
|
|
|
|
const after: LockfileObject = {
|
|
importers: {
|
|
['packages/a' as ProjectId]: {
|
|
specifiers: {
|
|
'is-positive': '^3.0.0',
|
|
},
|
|
dependencies: {
|
|
'is-positive': '3.1.0',
|
|
},
|
|
},
|
|
['packages/b' as ProjectId]: {
|
|
specifiers: {
|
|
'is-positive': '^3.1.0',
|
|
},
|
|
dependencies: {
|
|
'is-positive': '3.1.0',
|
|
},
|
|
},
|
|
},
|
|
packages: {
|
|
['is-positive@3.1.0' as DepPath]: {
|
|
resolution: {
|
|
integrity: 'sha1-hX21hKG6XRyymAUn/DtsQ103sP0=',
|
|
},
|
|
engines: {
|
|
node: '>=0.10.0',
|
|
},
|
|
},
|
|
},
|
|
lockfileVersion: 'testLockfileVersion',
|
|
}
|
|
|
|
expect(() => {
|
|
dedupeDiffCheck(before, after)
|
|
}).toThrow(new DedupeCheckIssuesError({
|
|
importerIssuesByImporterId: {
|
|
added: [],
|
|
removed: [],
|
|
updated: {
|
|
'packages/a': {
|
|
'is-positive': { type: 'updated', prev: '3.0.0', next: '3.1.0' },
|
|
},
|
|
},
|
|
},
|
|
packageIssuesByDepPath: {
|
|
added: [],
|
|
removed: ['/is-positive@3.0.0'],
|
|
updated: {},
|
|
},
|
|
}))
|
|
})
|
|
})
|