From aa108924ea2c8a5d9cfac98d53f762371cc30f09 Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Tue, 17 Sep 2024 17:28:06 +0200 Subject: [PATCH] test/system: remove wait workaround The issue is closed and I recently fixed a number of races (bf74797c69) in the remote attach API that sound like exactly like the same error that was mentioned in issue #9597. As such I think this works, if it start flaking again we can revert this or better fix the actual bug. Signed-off-by: Paul Holzinger --- test/system/035-logs.bats | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/system/035-logs.bats b/test/system/035-logs.bats index 47cac2aee0..c0e74fd250 100644 --- a/test/system/035-logs.bats +++ b/test/system/035-logs.bats @@ -136,10 +136,6 @@ function _log_test_restarted() { fi cname="c-ltr-$(safename)" run_podman run --log-driver=$driver ${events_backend} --name $cname $IMAGE sh -c 'start=0; if test -s log; then start=`tail -n 1 log`; fi; seq `expr $start + 1` `expr $start + 10` | tee -a log' - # FIXME: #9597 - # run/start is flaking for remote so let's wait for the container condition - # to stop wasting energy until the root cause gets fixed. - run_podman container wait --condition=exited --condition=stopped $cname run_podman ${events_backend} start -a $cname logfile=$(mktemp -p ${PODMAN_TMPDIR} logfileXXXXXXXX) $PODMAN $_PODMAN_TEST_OPTS ${events_backend} logs -f $cname > $logfile