From d63ac0652181fead09eb9c64647e30154bfdf69f Mon Sep 17 00:00:00 2001 From: Chris Evich Date: Mon, 7 Aug 2023 11:37:33 -0400 Subject: [PATCH] Minor: Add important comment to windows GHA workflow Ref: https://github.com/containers/podman/pull/19418#issuecomment-1665938019 Signed-off-by: Chris Evich --- .github/workflows/upload-win-installer.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/upload-win-installer.yml b/.github/workflows/upload-win-installer.yml index df7bfb949e..c26bb2d533 100644 --- a/.github/workflows/upload-win-installer.yml +++ b/.github/workflows/upload-win-installer.yml @@ -55,6 +55,13 @@ jobs: - uses: actions/checkout@v3 with: ref: ${{steps.getversion.outputs.version}} + # This step is super-duper critical for the built/signed windows installer .exe file. + # It ensures the referenced $version github release page does NOT already contain + # this file. Windows assigns a UUID to the installer at build time, it's assumed + # by windows that one release version == one UUID (always). Breaking this assumption + # has some rather nasty side-effects in windows, such as possibly breaking 'uninstall' + # functionality. For dry-runs, the .exe is saved in the workflow artifacts for a human + # to judge w/n (i.e. in some extreme case) it should be uploaded to the release page. - name: Check id: check run: |