From e36e2c97d2cb9cec76bc191473d272dff7eab84d Mon Sep 17 00:00:00 2001 From: Byounguk Lee Date: Sun, 17 May 2026 08:11:53 +0000 Subject: [PATCH] bindings/artifacts: remove redundant nameOrID parameter from Remove for 6.0 Signed-off-by: Byounguk Lee --- pkg/bindings/artifacts/remove.go | 7 +------ pkg/domain/infra/tunnel/artifact.go | 4 ++-- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/pkg/bindings/artifacts/remove.go b/pkg/bindings/artifacts/remove.go index 2e9962f114..5af761e5d0 100644 --- a/pkg/bindings/artifacts/remove.go +++ b/pkg/bindings/artifacts/remove.go @@ -9,17 +9,12 @@ import ( ) // Remove removes an artifact from local storage. -// TODO (6.0): nameOrID parameter should be removed -func Remove(ctx context.Context, nameOrID string, options *RemoveOptions) (*entities.ArtifactRemoveReport, error) { +func Remove(ctx context.Context, options *RemoveOptions) (*entities.ArtifactRemoveReport, error) { conn, err := bindings.GetClient(ctx) if err != nil { return nil, err } - if nameOrID != "" { - options.Artifacts = append(options.Artifacts, nameOrID) - } - params, err := options.ToParams() if err != nil { return nil, err diff --git a/pkg/domain/infra/tunnel/artifact.go b/pkg/domain/infra/tunnel/artifact.go index 7de730e7f1..54c37bb7e3 100644 --- a/pkg/domain/infra/tunnel/artifact.go +++ b/pkg/domain/infra/tunnel/artifact.go @@ -65,7 +65,7 @@ func (ir *ImageEngine) ArtifactRm(_ context.Context, opts entities.ArtifactRemov Ignore: &opts.Ignore, } - return artifacts.Remove(ir.ClientCtx, "", &removeOptions) + return artifacts.Remove(ir.ClientCtx, &removeOptions) } func (ir *ImageEngine) ArtifactPush(_ context.Context, name string, opts entities.ArtifactPushOptions) (*entities.ArtifactPushReport, error) { @@ -146,7 +146,7 @@ func artifactAddErrorCleanup(ctx context.Context, index int, name string, err er removeOptions := artifacts.RemoveOptions{ Artifacts: []string{name}, } - _, recoverErr := artifacts.Remove(ctx, "", &removeOptions) + _, recoverErr := artifacts.Remove(ctx, &removeOptions) if recoverErr != nil { return fmt.Errorf("failed to cleanup unfinished artifact add: %w", errors.Join(err, recoverErr)) }