diff --git a/pkg/machine/e2e/init_windows_test.go b/pkg/machine/e2e/init_windows_test.go index 74befafd6e..29afe7753d 100644 --- a/pkg/machine/e2e/init_windows_test.go +++ b/pkg/machine/e2e/init_windows_test.go @@ -174,7 +174,7 @@ var _ = Describe("podman machine init - windows only", func() { newFileServerVsocks, err := vsock.LoadAllHVSockRegistryEntriesByPurpose(vsock.Fileserver) Expect(err).ToNot(HaveOccurred()) Expect(newFileServerVsocks).To(HaveLen(countFileServerVsocks)) - for i := 0; i < countFileServerVsocks; i++ { + for i := range countFileServerVsocks { Expect(newFileServerVsocks[i].Port).To(Equal(fileServerVsocks[i].Port)) } diff --git a/pkg/machine/hyperv/vsock/vsock.go b/pkg/machine/hyperv/vsock/vsock.go index 818ed63607..cec3300562 100644 --- a/pkg/machine/hyperv/vsock/vsock.go +++ b/pkg/machine/hyperv/vsock/vsock.go @@ -174,7 +174,7 @@ func (hv *HVSockRegistryEntry) exists() (bool, error) { // already being used by another hvsock in the Windows registry. func findOpenHVSockPort() (uint64, error) { // If we cannot find a free port in 10 attempts, something is wrong - for i := 0; i < 10; i++ { + for range 10 { port, err := utils.GetRandomPort() if err != nil { return 0, err diff --git a/pkg/machine/machine_windows.go b/pkg/machine/machine_windows.go index 670834f361..921e1947de 100644 --- a/pkg/machine/machine_windows.go +++ b/pkg/machine/machine_windows.go @@ -82,7 +82,7 @@ func PipeNameAvailable(pipeName string, maxWait time.Duration) bool { func WaitPipeExists(pipeName string, retries int, checkFailure func() error) error { var err error - for i := 0; i < retries; i++ { + for range retries { err = fileutils.Exists(`\\.\pipe\` + pipeName) if err == nil { break diff --git a/pkg/machine/windows/util_windows.go b/pkg/machine/windows/util_windows.go index 2651b10fe1..443347d9fe 100644 --- a/pkg/machine/windows/util_windows.go +++ b/pkg/machine/windows/util_windows.go @@ -210,12 +210,7 @@ func wrapMaybef(err error, format string, args ...any) error { // IsReExecuting checks if the current process was re-executed with --reexec flag func IsReExecuting() bool { - for _, arg := range os.Args { - if arg == "--reexec" { - return true - } - } - return false + return slices.Contains(os.Args, "--reexec") } func CreateOrTruncateElevatedOutputFile() error {