From f42453457cccf5c9f631aba28fa8391b5d0900ff Mon Sep 17 00:00:00 2001 From: Paul Holzinger Date: Wed, 9 Jul 2025 17:56:26 +0200 Subject: [PATCH] pkg/bindings/containers: don't check for short read io.ReadFull() already returns ErrUnexpectedEOF if there was a short read so this check is redundant and can be dropped. Signed-off-by: Paul Holzinger --- pkg/bindings/containers/attach.go | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/pkg/bindings/containers/attach.go b/pkg/bindings/containers/attach.go index d7bd3e52de..9bb53a5667 100644 --- a/pkg/bindings/containers/attach.go +++ b/pkg/bindings/containers/attach.go @@ -259,14 +259,10 @@ func Attach(ctx context.Context, nameOrID string, stdin io.Reader, stdout io.Wri // DemuxHeader reads header for stream from server multiplexed stdin/stdout/stderr/2nd error channel func DemuxHeader(r io.Reader, buffer []byte) (fd, sz int, err error) { - n, err := io.ReadFull(r, buffer[0:8]) + _, err = io.ReadFull(r, buffer[0:8]) if err != nil { return } - if n < 8 { - err = io.ErrUnexpectedEOF - return - } fd = int(buffer[0]) if fd < 0 || fd > 3 { @@ -284,14 +280,10 @@ func DemuxFrame(r io.Reader, buffer []byte, length int) (frame []byte, err error buffer = append(buffer, make([]byte, length-len(buffer)+1)...) } - n, err := io.ReadFull(r, buffer[0:length]) + _, err = io.ReadFull(r, buffer[0:length]) if err != nil { return nil, err } - if n < length { - err = io.ErrUnexpectedEOF - return - } return buffer[0:length], nil }