Commit Graph

136 Commits

Author SHA1 Message Date
Paul Holzinger
8d8fb726f3 fix broken labeler.yml config
Commit ca66a90b87 was merged without fixing the config. Please read
changelogs before merging renovate PRs, especially when it is a major
version bump.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-12-06 16:06:07 +01:00
renovate[bot]
ca66a90b87 [skip-ci] Update actions/labeler action to v5
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-12-04 15:24:36 +00:00
renovate[bot]
7b826b2306 [skip-ci] Update dessant/lock-threads action to v5
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-11-14 06:24:16 +00:00
renovate[bot]
9cd975d59e [skip-ci] Update github/issue-labeler action to v3.3
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-11-09 01:32:29 +00:00
openshift-ci[bot]
80a9f23f89 Merge pull request #20532 from containers/renovate/dawidd6-action-send-mail-3.x
[skip-ci] Update dawidd6/action-send-mail action to v3.9.0
2023-11-01 13:07:39 +00:00
Chris Evich
4c67a6aed2 Fix secrets scanning GHA Workflow
The podman in `ubuntu-latest` environment apparently is too old to
support `--userns=keep-id:uid=1000,gid=1000`.  Employ workaround in GHA
workflow and in `prebuild.sh` check.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-10-30 12:06:17 -04:00
renovate[bot]
2193bb8fcd [skip-ci] Update dawidd6/action-send-mail action to v3.9.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-30 15:43:25 +00:00
Chris Evich
1146f2ca78 Merge pull request #20136 from cevich/credential_scanning_config
[CI:DOCS] Implement secrets/credential scanning
2023-10-30 11:43:01 -04:00
renovate[bot]
e8183e836c [skip-ci] Update actions/checkout digest to b4ffde6
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-10-19 11:14:37 +00:00
Chris Evich
6cb10425d4 Implement secrets/credential scanning
As an effort to catch potential secrets and/or credential leaks, add a
github-actions workflow which is untouchable in a PR context.
To additionally guard against accidents, also check recent branch
history.  This is especially important on newly created
release-branches, which may begin with content from who-knows-where.

Finally, since the new workflow bypasses PR-level changes to the scanner
config and base-line.  Add a Cirrus-CI invocation of the scanning tool
to help catch tool-breaking changes from being merged.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-10-05 11:16:19 -04:00
Chris Evich
7ef8519f4a Revert "GHA Workflow: Faster discussion-locking"
This reverts commit 618f846edc.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-09-29 16:01:20 -04:00
renovate[bot]
4ed9dc1add [skip-ci] Update dawidd6/action-send-mail action to v3.9.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-09-27 10:32:01 +00:00
Lokesh Mandvekar
59ffea80d2 FCOS+podman-next: correct GHA conditional syntax
Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-contexts

[skip-ci]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-09-26 10:34:52 -04:00
Lokesh Mandvekar
52ba1bfff7 [CI:BUILD] FCOS image: enable nightly build
`wait-for-copr` is still very flaky and has failed more often than not.
Ref: https://github.com/fedora-copr/copr/issues/2819

This change to the fcos GHA will allow nightly builds pulling in
whatever packages exist on podman-next at that time without depending on
wait-for-copr.

The commit id will still be recorded in podman version as well as the
image tag, so auditing is not affected with this change.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-09-25 14:15:01 -04:00
OpenShift Merge Robot
28a1c5492e Merge pull request #20042 from cevich/faster_closed_issue_pr_lock
[skip-ci] GHA Workflow: Faster discussion-locking
2023-09-20 11:58:43 +02:00
Chris Evich
618f846edc GHA Workflow: Faster discussion-locking
The closed issue & PR lock is working fine, but it has a built-in
50-item limit.  The limit is not configurable.  Since there are
tens-of-thousands of issues/prs to go through, 50-per-day could take
almost a year.  Speed things up 24x by running the job every hour
instead of daily.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-09-19 16:01:34 -04:00
Lokesh Mandvekar
fa71504518 [CI:BUILD] followup PR for fcos with podman-next
Followup on #19477

Remove commented out cirrus task for fcos image build with podman-next
and add 2 github actions: 1 for running a simple uni-arch image build
on every PR and another to actually build multiarch images and push to
quay after merge.

`podman --version` will also include git short sha for clarity.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-09-19 10:19:53 -04:00
Daniel J Walsh
b1e3e8d972 Run codespell on code
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2023-09-14 06:13:23 -04:00
renovate[bot]
e825bd5d5e [skip-ci] Update actions/checkout action to v4
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-09-04 12:51:33 +00:00
Lokesh Mandvekar
50cd072bf6 [CI:BUILD] Podman FCOS image from main
Fixes: #19446, #19447, #19448

[NO NEW TESTS NEEDED]

Co-authored-by: Chris Evich <cevich@redhat.com>
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-09-01 09:50:59 -04:00
Lokesh Mandvekar
39c5b7face remove rh.container.bot@gmail.com
Don't need this email as we have podman-monitor email listed wherever
relevant.

[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2023-08-30 15:01:16 -04:00
Chris Evich
21c9517b5e Revert "GHA: Closed issue/PR comment-lock test"
This reverts commit f0e8e79c97.
This is intentional, it was needed for testing. See

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-22 14:51:24 -04:00
Chris Evich
f0e8e79c97 GHA: Closed issue/PR comment-lock test
This commit limits the blast-radius should the workflow fail
catastrophically.  It also instruments the workflow with a job-level
test-failure to trigger a notification mail.  This commit should be
reverted once the workflow is deemed functional.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-22 13:30:04 -04:00
Chris Evich
5477fd38a9 GHA: Add workflow to lock closed issues/PRs
Ref: https://github.com/containers/podman/discussions/19012

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-22 13:30:03 -04:00
renovate[bot]
7988dd82c9 [skip-ci] Update dawidd6/action-send-mail action to v3.8.0
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-08-08 12:38:30 +00:00
Chris Evich
03d7a5120c Minor: Include shasums in GHA workflow artifacts
This may be helpful in case SHA comparison is needed w/ files elsewhere.
For example, the files uploaded to a github release page.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-07 11:42:39 -04:00
Chris Evich
d63ac06521 Minor: Add important comment to windows GHA workflow
Ref:
https://github.com/containers/podman/pull/19418#issuecomment-1665938019

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-07 11:37:33 -04:00
Chris Evich
9d7fe4e90f Minor: Update/fix dry-run input descriptions
These are visible when running either job manually.  Fix the windows
workflow by including a `v` prefix to an obviously fictitious version
number.  For consistency, update the mac workflow text to match.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-07 11:30:32 -04:00
OpenShift Merge Robot
7a2c5422e8 Merge pull request #19418 from cevich/dry_run_actions
[CI:DOCS] GHA: Support testing build/sign workflows
2023-08-03 11:38:56 +02:00
Chris Evich
4d69f01468 GHA: Support testing build/sign workflows
Neither `release` nor `workflow_dispatch` triggers may be tested inside
a PR context.  The workflow steps always run from what's already
committed to `main`.  Rather than waiting for a release to discover
some unforeseen workflow problem, allow manual runs to optionally skip
the release upload step (by default).

Also, update the windows workflow to store an artifact of the signed
build, and migrate away from the deprecated "set-output" command.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-08-02 16:58:16 -04:00
Chris Evich
93f4cc1b51 [CI:DOCS] GHA: Use stable go for Mac/Win builds
Having hard-coded versions burried under a hidden directory is ripe for
maintenance headaches.  Use the latest 'stable' version, since this will
be "close enough" to what we test in CI.

Ref: https://github.com/containers/podman/discussions/19404

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-07-31 10:43:53 -04:00
OpenShift Merge Robot
7c1406f822 Merge pull request #19399 from ashley-cui/cimac
[CI:DOCS] Build and Sign Mac Pkginstaller
2023-07-28 17:54:37 +02:00
Ashley Cui
f592c33fb8 [CI:DOCS] Build and Sign Mac Pkginstaller
Create a new GitHub Action that builds and signs the Mac pkginstaller. The action also uploads the installers to the release, and updates the shasums file.

This action is triggered on release creation, but it can also be triggered manually via a workflow dispatch.

Signed-off-by: Ashley Cui <acui@redhat.com>
2023-07-27 15:17:37 -04:00
Erik Sjölund
8757fe88ad github: add issue type as link to podman github discussions
Some issues reported in the podman github project contains a
question instead of a bug report or feature request. Make it
easier for users to find a place to ask questions.

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
2023-07-27 17:17:45 +02:00
Adam Jones
5aa52659b7 Fix bug report issue template README link
The relative link seems flakey: depending where you're creating the issue this may not take you to the right place.

For example, from https://github.com/containers/podman/issues/new it takes you to https://github.com/containers/podman/README.md, which does not exist.

To fix this, I've replaced it with an absolute link to the README for people to find the version easily. Other places in the same issue template use absolute paths to places in the repo e.g. the wiki, so I think this is acceptable.

Signed-off-by: Adam Jones <domdomegg+git@gmail.com>
2023-07-17 16:51:43 +01:00
renovate[bot]
8d24e28387 [skip-ci] Update github/issue-labeler action to v3.2
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-07-08 19:44:36 +00:00
Paul Holzinger
0714321de9 github: add issue type as link to podman-desktop
I see a lot of podman-desktop bug reports on the podman repo. This is
not the correct place to file these reports but many users seem to be
unaware of that. This is an attempt to point them in the right
direction. It should show up as extra entry in the issue type
selection so hopefully users while read that and follow the link in the
desktop repository.

See this link for the github docs about the configuration:
https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2023-06-12 11:39:22 +02:00
Chris Evich
a7271f9dd7 GHA: Fix bad job-names & links in monitoring emails
Due to a bad file-format design, if a cirrus-cron job happened to have a
name w/ spaces, the generated e-mail text would be broken.  For example:

```
Cron build 'VM' Failed: https://cirrus-ci.com/build/Image Maintenance
5630822628196352
```

Fix this by flipping the field-order in an intermediate file, so the
build ID comes first, then the job name.  This makes it much easier for
`read` to process, since all words will be stored into the final
variable (now the job name).

Also change all variables that reference this intermediate file such
that they continue to reflect the expected field order.  Update script
tests and add a new test to confirm expected file processing and output.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-06-07 15:22:17 -04:00
OpenShift Merge Robot
d7f9ef253a Merge pull request #18532 from vrothberg/template
[CI:DOCS] issue template: mention `su`
2023-05-10 16:10:48 -04:00
Valentin Rothberg
04707f62d6 issue template: mention su
Mention that using `su` does not establish a proper login session
required for running rootless Podman.  It is a common and reoccurring
issue.  Mentioning that in the issue template may guide users into
resolving the issue before opening an issue.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-05-10 14:27:35 +02:00
Chris Evich
2d8929d95d [CI:DOCS] Disable Dependabot in favor of Renovate
Fixes: #18139

Removing the Dependabot configuration file is a required prerequisite to
stopping it from opening update PRs.  Once this commit is merged, the
`Dependabot security updates` repo. setting may also be disabled.  Note:
The `Dependabot alerts` setting should remain enabled, this provides
security-data to renovate for opening important vulnerability fix PRs.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-05-09 12:45:52 -04:00
Ed Santiago
f877d7dcd0 Replace egrep/fgrep with grep -E/-F
There are days when I really, really, really hate GNU. Remember
when someone decided that 'head -1' would no longer work, and
that it was OK to break an infinite number of legacy production
scripts? Someone now decided that egrep/fgrep are deprecated,
and our CI logs (especially pr-should-include-tests) are now
filled with hundreds of warning lines, making it difficult
to find actual errors.

I expect that those warnings will be removed quickly after
furious community backlash, just like the 'head -1' fiasco
was quietly reverted, but ITM the warnings are annoying
so I capitulate.

Signed-off-by: Ed Santiago <santiago@redhat.com>
2023-05-03 07:32:42 -06:00
renovate[bot]
fc8bd45215 [skip-ci] Update dawidd6/action-send-mail action to v3.7.2
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2023-04-25 08:12:08 +00:00
Chris Evich
785c63c0f7 Renovate: Ensure release-note-none label is added
Signed-off-by: Chris Evich <cevich@redhat.com>
2023-04-11 11:02:26 -04:00
Chris Evich
4bc4609d82 Renovate: Update ignore paths
It's desireable for renovate to mange `test/tools/go.mod` however, the
default ignorePaths is:

```
  "ignorePaths": [
    "**/node_modules/**",
    "**/bower_components/**",
    "**/vendor/**",
    "**/examples/**",
    "**/__tests__/**",
    "**/test/**",
    "**/tests/**",
    "**/__fixtures__/**"
  ]
```

Update this list to only include `vendor` and `docs`.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-04-11 10:55:57 -04:00
Chris Evich
d53871cf12 GHA: Use version instead of SHA for actions
It's nearly impossible for humans to tell semantic-version differences
by looking at a commit sha.  Since all the actions in question come from
github, there's little security/safety benefit to using SHAs.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-04-10 14:45:36 -04:00
OpenShift Merge Robot
c04ccdbc55 Merge pull request #18121 from containers/renovate/actions-stale-8.x
[skip-ci] Update actions/stale action to v8
2023-04-09 07:20:31 -04:00
OpenShift Merge Robot
b3dd2dbf4c Merge pull request #18115 from containers/renovate/actions-setup-go-4.x
[skip-ci] Update actions/setup-go action to v4
2023-04-09 07:17:55 -04:00
OpenShift Merge Robot
8a6dc0a822 Merge pull request #18112 from containers/renovate/github-issue-labeler-2.x
[skip-ci] Update github/issue-labeler action to v2.6
2023-04-09 07:15:18 -04:00
renovate[bot]
c5a0d86461 [skip-ci] Update actions/upload-artifact action to v3
Signed-off-by: Renovate Bot <bot@renovateapp.com>
2023-04-09 10:09:56 +00:00