By default something like a 404 will not make curl exit with an error
code. This is problematic for obvious reasons and instead of the file
you want you may now have some 404 html text instead.
I noticed this in #28003 which well just build fine installers except
the binary downloaded by the installer Makefile simply did not exist.
So to address that add --fail to most curl commands.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This is a follow-up of d04c84e7 and fixes the error message that is
displayed if someone tries to run `contrib/win-installer/build.ps1` but
doesn't have the .NET SDK installed.
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
It was failing on darwin, because amd64 is no longer supported.
"build constraints exclude all Go files" in pkg/machine/libkrun
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Update the service description to reflect that it now also restarts
containers with unless-stopped restart policy, not just always.
This was changed in PR #27619 but the description was not updated.
Fixes: #27908
Signed-off-by: Alessio Attilio <attilio.alessio@protonmail.com>
The old setup bundle was still built and released to avoid breaking
downstream projects. This commit removes it and, starting from Podman
v6, only the installer that doesn't require elevated privileges will be
released.
This is a subtask of issue #27624.
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Before running machine e2e tests on Windows, the gvproxy executable was
copied in `C:\Program Files\Redhat\Podman`. This is wrong because the
target folder, where Podman is installed, has changed but is also
useless because, after #27612, podman looks for gvproxy in `podman.exe`
folder too. This commit removes the gvproxy copy step.
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Podman uses this env toi do various things, we don't want the external
env to affect our tests here.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This PR removes support for Intel Apple Macs. The removal includes
impacts to code, tests, Makefile, builds, release builds, and so forth.
Fixes Jira: RUN-3621
Signed-off-by: Brent Baude <bbaude@redhat.com>
- Update documentation: Differentiate `unless-stopped` from `always` - containers stopped by the user before a reboot will not restart.
- Add `should-start-on-boot` filter: Identify containers that require a restart after a system reboot.
- Update command documentation: Add `restart-policy` and `label!` filters to the documentation for container commands (rm, ps, start, stop, pause, unpause, restart).
- Add `restart-policy` and `shoud-start-on-boot` to completions.
- Update service: Update `podman-restart.service` to use the `needs-restart=true` filter.
- Preserve state: Preserve the `StoppedByUser` state across reboots.
- Update API: Add a `ShouldStartOnBoot()` method to the Container API.
- Update documentation: Add descriptions for the `should-start-on-boot` filter.
Fixes: https://issues.redhat.com/browse/RHEL-129405
Fixes: https://github.com/containers/podman/issues/20418
Signed-off-by: Jan Rodák <hony.com@seznam.cz>
This will fetch latest dependencies from podman-next while using podman
from the packit copr builds.
TMT_TREE envvar is ok to use in this case as it will only be used on
upstream packit tests.
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
Bump bundled krunkit to 1.1.1. This is a minor, expedited release
to fix a library linking problem.
Fixes: #27427
Signed-off-by: Sergio Lopez <slp@redhat.com>
The windows installer doesn't like -rc's because it's not strictly semver, but this error can be suppressed.
Signed-off-by: Ashley Cui <acui@redhat.com>
Bump bundled krunkit to 1.1.0. For podman, this release means
better I/O performance due to this libkrun version defaulting to
a more relaxed disk image sync on macOS, and raising the vCPU
limit to the maximum allowed by Hypervisor.framework.
Fixes: #27216
Signed-off-by: Sergio Lopez <slp@redhat.com>
This also includes a number of significant changes to the SQLite
state made possible by removal of the legacy DB.
1. Enable database unit tests for SQLite state, with numerous
tweaks to get tests passing. Most notable changes are to
container removal - where we previously didn't return an error
if there was no container to remove - and RemovePodContainers,
which I don't think ever worked properly from my reading of
the failures.
2. Removal of AddContainerToPod/RemoveContainerToPod. On SQLite,
these functions are identical to AddContainer/RemoveContainer
and there is no reason to retain duplicates.
3. Removal of SafeRewriteContainerConfig - it's identical to
RewriteContainerConfig in SQLite, no reason to have duplicate
entrypoints.
As an exciting side-note, this removes Podman's requirement that
containers and pods cannot share a name, which was a BoltDB
restriction only.
Signed-off-by: Matt Heon <matthew.heon@pm.me>
We started logging this in 5.6. In 5.7, we up to a warning. The
upcoming 5.8 will up the warnings further to errors.
Required as we're removing BoltDB support in 6.0 next Spring.
Signed-off-by: Matt Heon <matthew.heon@pm.me>
Adding a design document for Podman 6. it is a high level design that tries to encompasses proposed changes to Podman and its runtime environment. It should highlight major changes and features; but you will also find nitty detailed changes that have been idenitified. It is quite possible things in this document will change but it allows for open, transparent communication.
Signed-off-by: Brent Baude <bbaude@redhat.com>
This build tag replaces the backend for _verification_
of GPG signatures, to use Sequoia-PGP instead of GNUPG.
Do Rawhide builds with Sequoia; the podman-sequoia package exists
in F43 and later, so we can't do it in earlier versions.
This way we cover both variants (+ containers_image_openpgp
in the podman-remote client, at least that it builds).
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Add a new directory, which I'm currently dubbing "Features", in
which will live design documents - descriptions of Podman
features that will be implemented or are being implemented.
Add a README and template to this directory to make the purpose
clear and enable easy addition of new design documents.
Signed-off-by: Matt Heon <matthew.heon@pm.me>
We already used `x` in tmpfiles, to ensure systemd did not remove
our directories or clean their contents (we really need them to
be left unmodified). However, systemd-tmpfiles lets us use more
than one directive per line, which means we can safely add an R!
(recursive remove on reboot) to these lines to ensure that, if
/tmp is not a tmpfs, systemd-tmpfiles will still remove our
temporary files, ensuring reboots are still accurately detected.
Signed-off-by: Matt Heon <mheon@redhat.com>
As part of my debloat activity I wrote a small script that makes use of
goda[1] to check our imports and what we can likely trim to reduce the
binary size.
I also added a readme to document what I did basically. This should help
anyone doing this work in the future again.
[1] github.com/loov/goda
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Bump bundled krunkit to 0.2.2. This bundle also includes libkrun
1.14.0, allowing us to enable nested virt on M3 and M4 systems by
default.
Signed-off-by: Sergio Lopez <slp@redhat.com>
We used this to load the iptables module, since f41 we use nftables by
default which does not need this at all so drop the module load file.
If some distros default still to the legacy iptables they can manually
add the moduled load file back.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
The config file is installed in the remote zip as an example but the
content in there is not being updated and no longer really the way to do
things. With podman 5.0 we have a proper system connection file and
people in general should just use the system connection commands.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This script was used when dependabot could not deal with vendoring, we
long since moved to renovate which handles it fine with manual steps so
remove this script.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
It doesn't seem to be used anywhere and is not maintained. An up to date
specfile is found in the c/common repo.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
changing the validate-in-container make target to use
quay.io/libpod/validatepr:latest. this allows `make validate` to run to
completion doing linting, ed's perl checks, and pre-commit.]
The image is now based on F42 `awk` is not part of the base image, so I added `awk`.
Signed-off-by: Brent Baude <bbaude@redhat.com>
