Commit Graph

2622 Commits

Author SHA1 Message Date
Brent Baude
517bc28360 system tests must pass
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-28 15:17:00 -05:00
Sujil02
b3cfb20aa2 Fix typos in rm messages
Fix typos in pod rm messages

Signed-off-by: Sujil02 <sushah@redhat.com>
2020-04-28 15:57:40 -04:00
OpenShift Merge Robot
23be7b5049 Merge pull request #6024 from baude/v2checkmediatypew
check image media/manifest type for healthchecks
2020-04-28 19:21:50 +02:00
OpenShift Merge Robot
8f57f312d6 Merge pull request #6020 from giuseppe/fix-exec
v2, podman: fix create tests
2020-04-28 19:19:12 +02:00
Brent Baude
a255075fe8 check image media/manifest type for healthchecks
before looking up a healthcheck in an image, check to make sure it is a dockerv2schema image.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-28 11:49:58 -05:00
OpenShift Merge Robot
4ed125f7b5 Merge pull request #5907 from sujil02/systemprune-v2
Adding system prune for podman v2
2020-04-28 18:11:39 +02:00
Giuseppe Scrivano
a9aa9e2f78 pkg, specgen: do not hardcode user=0 in the config if not specified
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 15:25:59 +02:00
Daniel J Walsh
51585fffdd Set up ulimits for rootless containers.
Currently we are setting the maximum limits for rootful podman containers,
no reason not to set them by default for rootless users as well

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-28 08:09:39 -04:00
OpenShift Merge Robot
f6f7172494 Merge pull request #6000 from mheon/volume_backend_flags
Add support for volumes-from, image volumes, init
2020-04-27 21:53:37 +02:00
OpenShift Merge Robot
8642e256f2 Merge pull request #5978 from rhatdan/ports
Make podman container list == podman ps
2020-04-27 21:27:49 +02:00
OpenShift Merge Robot
618d4be212 Merge pull request #6002 from lsm5/fix-specgen-in-bindings-test
Fix NewSpecGenerator args in pkg/bindings/test
2020-04-27 20:39:27 +02:00
OpenShift Merge Robot
733c38028d Merge pull request #5999 from giuseppe/fix-pod-infra-container
v2, podman: fix pod tests
2020-04-27 20:37:03 +02:00
OpenShift Merge Robot
ccf009d22e Merge pull request #6001 from baude/v2intload
enable load integration tests
2020-04-27 20:34:39 +02:00
OpenShift Merge Robot
e90112a58c Merge pull request #5984 from baude/v2intrestart
enable integration tests for restart
2020-04-27 20:27:36 +02:00
Matthew Heon
67ec4e1d27 Improve Entrypoint and Command support
We should not be overwriting the Specgen's Command and Entrypoint
when building the final command to pass in the OCI spec. Both of
these will be provided to Libpod for use in `podman inspect` and
committing containers, and both must be set to the user's input,
not overwritten by the image if unset.

Fix this by moving command generation into OCI spec generation
and not modifying the SpecGenerator when we do so.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-04-27 13:13:21 -04:00
Matthew Heon
02671a103f Add support for volumes-from, image volumes, init
This should complete Podmanv2's support for volume-related flags.
Most code was sourced from the old pkg/spec implementation with
modifications to account for the split between frontend flags
(volume, mount, tmpfs) and the backend flags implemented here.

Also enables tests for podman run with volumes

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-04-27 13:13:21 -04:00
Lokesh Mandvekar
bee486b91f Fix NewSpecGenerator args in pkg/bindings/test
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2020-04-27 11:29:43 -04:00
Brent Baude
6db081fc5e enable load integration tests
fix bug where multiple images can be loaded and have to be able to handle the return of multiple names

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-27 10:20:53 -05:00
Giuseppe Scrivano
d227d44fd6 namespaces: accept pod namespace
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 17:08:52 +02:00
Giuseppe Scrivano
a7318f7364 pkg, ps: add namespaces methods
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 17:08:52 +02:00
OpenShift Merge Robot
ca1c674d2e Merge pull request #5966 from vrothberg/v2-pod-stats
implement pod stats
2020-04-27 16:15:09 +02:00
Brent Baude
a7b3310db5 enable integration tests for restart
enable integrations tests for container restart.  fixed bug where --running was not being honored.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-27 09:08:27 -05:00
Daniel J Walsh
a83d1a2772 Make podman container list == podman ps
Also make
podman create -p PUBLISHPorts
work.

This PR fixes ps_test.go

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-27 09:51:26 -04:00
OpenShift Merge Robot
fdf64f0c66 Merge pull request #5994 from giuseppe/fix-healthchecks
v2, podman: fix healthchecks
2020-04-27 15:40:24 +02:00
OpenShift Merge Robot
529824ec1e Merge pull request #5997 from giuseppe/fix-pod-create
v2, podman: fix a bunch of "podman pod *" tests
2020-04-27 15:37:58 +02:00
OpenShift Merge Robot
ef46687dc5 Merge pull request #5976 from QiWang19/manifest-add-os
Add --os to manifest add
2020-04-27 15:33:00 +02:00
Giuseppe Scrivano
869a1a211a pkg, pods: report pod rm errors
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 14:02:53 +02:00
Giuseppe Scrivano
1aaef86eb4 pkg, pods: pod rm honors --ignore
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:47:52 +02:00
Giuseppe Scrivano
4028215b6a pkg, pods: not lose pod start/restart errors
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:41:08 +02:00
Giuseppe Scrivano
e589c2219f pkg, pods: honor --ignore for pod stop
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:19:05 +02:00
Giuseppe Scrivano
c2f77a281f specgen: relax test to accept default network
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:12:19 +02:00
Giuseppe Scrivano
adb10783d9 spec, pod: honor --dns
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 12:58:02 +02:00
Valentin Rothberg
7ee0f7e14c implement pod stats
Implement pod stats for the local and remote client. Both code paths end
up in infra/abi to allow for code share.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-27 12:00:35 +02:00
Giuseppe Scrivano
1cd484e13f specgen: read healthchecks from the image
if there is no healthcheck configuration specified, read it from the
image.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 11:22:27 +02:00
Sujil02
c1766d5e64 Enable pod inspect integration test
Enable pod inspect integration  test
Get rid of libpod pod inspect references
Remove libpod PodInspect struct.

Signed-off-by: Sujil02 <sushah@redhat.com>
2020-04-26 16:38:52 -04:00
Brent Baude
942a3ef588 Enable pod ps integration tests
Enable integration tests for pod ps.

In addition, fixed bug where output was still using slice go template routines and would fail when no infra container was present.  Added integration test to prevent future regressions.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-25 13:13:32 -05:00
OpenShift Merge Robot
2afe579c06 Merge pull request #5971 from giuseppe/fix-userns-tests
v2, podman: fix and enable all run_userns_test.go tests
2020-04-24 22:39:26 +02:00
Sujil02
5436e31441 Adding system prune for podman v2
Register system prune route, handler to support system prune,
Adds testcase to validate the system prune flow.

Signed-off-by: Sujil02 <sushah@redhat.com>
2020-04-24 15:44:07 -04:00
Qi Wang
2f3734b143 Add --os to manifest add
Add --os to manifest add for overriding the os field.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-04-24 14:57:56 -04:00
OpenShift Merge Robot
a49d5c9c2f Merge pull request #5974 from giuseppe/fix-init
[v2] containers, init: skip invalid state errors with --all
2020-04-24 20:33:17 +02:00
OpenShift Merge Robot
3c3adac528 Merge pull request #5967 from giuseppe/run-test-fixes
v2, tests: fix various run_test.go failures
2020-04-24 17:46:20 +02:00
Giuseppe Scrivano
bd7cad775a containers, init: skip invalid state errors with --all
reintroduce the same check that exists in v1.9.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 17:33:27 +02:00
Giuseppe Scrivano
88f1994ab9 podman: assume user namespace if there are mappings
if some mappings are specified, assume there is a private user
namespace.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 15:55:38 +02:00
Matthew Heon
b1552d9124 Do not join pod namespaces without an infra ctr
We do not want to join pod namespaces if no infra container is
present. A pod may claim it shares namespaces without an infra
container (I'll take an action item to fix that - it really
should not be allowed), which was tripping up our default
namespace code and forcing us to try and join the namespaces of
the nonexistant infra container.

Signed-off-by: Matthew Heon <mheon@redhat.com>
2020-04-24 09:44:51 -04:00
Giuseppe Scrivano
64d8b4eebb podman: implement userns=keep-id
add missing implementation for userns=keep-id and enable the user
namespaces tests.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 15:03:50 +02:00
Giuseppe Scrivano
a3acc4f977 podman: add support for --rootfs
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:20 +02:00
Giuseppe Scrivano
23d431f0bf specgen: fix error message
the check is correct but the error message was stating the opposite.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 10:49:18 +02:00
Giuseppe Scrivano
36039a38ea create: move validate after setting default ns
validate the configuration only after we set the default namespaces.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 10:48:40 +02:00
Daniel J Walsh
995cd97c10 Fix SELinux functions names to not be repetitive
Since functions are now in an selinux subpackage, they should not start with
SELinux

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-23 15:57:34 -04:00
OpenShift Merge Robot
802763c604 Merge pull request #5933 from giuseppe/fix-namespaces
podman, v2: handle namespaces specified on the CLI
2020-04-23 19:32:08 +02:00