Commit Graph

1540 Commits

Author SHA1 Message Date
Qi Wang
75eeb40f41 testv2: enable attach test
testv2: enable attach test

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-04-29 23:47:15 -04:00
Jhon Honce
a9cc13448e V2 Restore images list tests
* Fix history --quiet formatting
* Fix image inspect --format=json
* Fix image list --sort

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-29 08:24:56 -07:00
Valentin Rothberg
2d10471b8d pull/search options: tls verify -> skip
Change the logic in the options from tls-verify to skipping
verification.  It require a constant brain yoga to translate
from doing verification (CLI logic) to skipping it (c/image logic).
As the code is using c/image, let's make it consistent.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 16:28:12 +02:00
OpenShift Merge Robot
a76a99352a Merge pull request #6037 from vrothberg/enable-push-tests
Enable push tests
2020-04-29 16:20:44 +02:00
OpenShift Merge Robot
6246165f16 Merge pull request #6036 from giuseppe/fix-rootlessport-panic
rootlessport: use two different channels
2020-04-29 16:07:44 +02:00
Valentin Rothberg
5c108f75eb login system test: enable "push ok"
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 15:23:30 +02:00
OpenShift Merge Robot
a22dacfa1b Merge pull request #6035 from giuseppe/move-rootless-open-before-fork
rootless: move ns open before fork
2020-04-29 15:07:07 +02:00
Valentin Rothberg
d6d1e3860c push: fix --tls-verify
Fix --tls-verify parsing and make the associated options reflect the
correct logic.  Other commands are affected as well but will be fixed
later.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 14:33:00 +02:00
Giuseppe Scrivano
6d545bb2f7 rootlessport: use two different channels
The same channel is written to by two different goroutines.

Use a different channel for each of them so to avoid writing to a
closed channel.

Closes: https://github.com/containers/libpod/issues/6018

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-29 12:35:23 +02:00
Giuseppe Scrivano
b8db112436 specgen: honor slirp4netns
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-29 12:13:05 +02:00
Giuseppe Scrivano
89d4940a37 rootless: move ns open before fork
commit 788fdc685b introduced a race
where the target process dies before the child process opens the
namespace files.  Move the open before the fork so if it fails the
parent process can attempt to join a different container instead of
failing.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-29 11:44:24 +02:00
OpenShift Merge Robot
3e912f711b Merge pull request #6022 from vrothberg/enable-inspect-tests
enable inspect tests
2020-04-29 11:21:47 +02:00
OpenShift Merge Robot
62a4befe04 Merge pull request #5998 from vrothberg/generate-systemd
generate systemd
2020-04-29 11:19:15 +02:00
OpenShift Merge Robot
4e21d09f98 Merge pull request #6029 from rhatdan/env
User specified environment happen after other environments are set
2020-04-29 08:52:14 +02:00
Valentin Rothberg
8700c2fd03 enable inspect tests
A surprisingly big change.  A core problem was that `podman inspect`
allows for passing containers AND images with the default `--type=all`.
This only worked partially as the data was processed in isolation which
caused various issues (e.g., two separate outputs instead of one) but it
also caused issues regarding error handling.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 07:25:31 +02:00
Valentin Rothberg
b2414b580e generate systemd
Implement `podman generate systemd` for Podman v2 and enable associated
tests.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 07:22:18 +02:00
OpenShift Merge Robot
bf4efc1953 Merge pull request #6026 from baude/v2forcesystemtests
system tests must pass
2020-04-28 23:29:20 +02:00
OpenShift Merge Robot
30b27819d0 Merge pull request #5991 from sujil02/pod-rm-test
Fix typos in messages pod rm
2020-04-28 22:40:09 +02:00
Daniel J Walsh
e84beeaf94 User specified environment happen after other environments are set
When using varlink we want to make sure that user specified environment variables
take precedence over http-proxy environment.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-28 16:29:01 -04:00
Brent Baude
517bc28360 system tests must pass
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-28 15:17:00 -05:00
Sujil02
b3cfb20aa2 Fix typos in rm messages
Fix typos in pod rm messages

Signed-off-by: Sujil02 <sushah@redhat.com>
2020-04-28 15:57:40 -04:00
OpenShift Merge Robot
23be7b5049 Merge pull request #6024 from baude/v2checkmediatypew
check image media/manifest type for healthchecks
2020-04-28 19:21:50 +02:00
OpenShift Merge Robot
8f57f312d6 Merge pull request #6020 from giuseppe/fix-exec
v2, podman: fix create tests
2020-04-28 19:19:12 +02:00
Brent Baude
a255075fe8 check image media/manifest type for healthchecks
before looking up a healthcheck in an image, check to make sure it is a dockerv2schema image.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-28 11:49:58 -05:00
OpenShift Merge Robot
4ed125f7b5 Merge pull request #5907 from sujil02/systemprune-v2
Adding system prune for podman v2
2020-04-28 18:11:39 +02:00
Giuseppe Scrivano
a9aa9e2f78 pkg, specgen: do not hardcode user=0 in the config if not specified
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 15:25:59 +02:00
OpenShift Merge Robot
f6f7172494 Merge pull request #6000 from mheon/volume_backend_flags
Add support for volumes-from, image volumes, init
2020-04-27 21:53:37 +02:00
OpenShift Merge Robot
8642e256f2 Merge pull request #5978 from rhatdan/ports
Make podman container list == podman ps
2020-04-27 21:27:49 +02:00
OpenShift Merge Robot
618d4be212 Merge pull request #6002 from lsm5/fix-specgen-in-bindings-test
Fix NewSpecGenerator args in pkg/bindings/test
2020-04-27 20:39:27 +02:00
OpenShift Merge Robot
733c38028d Merge pull request #5999 from giuseppe/fix-pod-infra-container
v2, podman: fix pod tests
2020-04-27 20:37:03 +02:00
OpenShift Merge Robot
ccf009d22e Merge pull request #6001 from baude/v2intload
enable load integration tests
2020-04-27 20:34:39 +02:00
OpenShift Merge Robot
e90112a58c Merge pull request #5984 from baude/v2intrestart
enable integration tests for restart
2020-04-27 20:27:36 +02:00
Matthew Heon
67ec4e1d27 Improve Entrypoint and Command support
We should not be overwriting the Specgen's Command and Entrypoint
when building the final command to pass in the OCI spec. Both of
these will be provided to Libpod for use in `podman inspect` and
committing containers, and both must be set to the user's input,
not overwritten by the image if unset.

Fix this by moving command generation into OCI spec generation
and not modifying the SpecGenerator when we do so.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-04-27 13:13:21 -04:00
Matthew Heon
02671a103f Add support for volumes-from, image volumes, init
This should complete Podmanv2's support for volume-related flags.
Most code was sourced from the old pkg/spec implementation with
modifications to account for the split between frontend flags
(volume, mount, tmpfs) and the backend flags implemented here.

Also enables tests for podman run with volumes

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-04-27 13:13:21 -04:00
Lokesh Mandvekar
bee486b91f Fix NewSpecGenerator args in pkg/bindings/test
Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2020-04-27 11:29:43 -04:00
Brent Baude
6db081fc5e enable load integration tests
fix bug where multiple images can be loaded and have to be able to handle the return of multiple names

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-27 10:20:53 -05:00
Giuseppe Scrivano
d227d44fd6 namespaces: accept pod namespace
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 17:08:52 +02:00
Giuseppe Scrivano
a7318f7364 pkg, ps: add namespaces methods
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 17:08:52 +02:00
OpenShift Merge Robot
ca1c674d2e Merge pull request #5966 from vrothberg/v2-pod-stats
implement pod stats
2020-04-27 16:15:09 +02:00
Brent Baude
a7b3310db5 enable integration tests for restart
enable integrations tests for container restart.  fixed bug where --running was not being honored.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-27 09:08:27 -05:00
Daniel J Walsh
a83d1a2772 Make podman container list == podman ps
Also make
podman create -p PUBLISHPorts
work.

This PR fixes ps_test.go

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-27 09:51:26 -04:00
OpenShift Merge Robot
fdf64f0c66 Merge pull request #5994 from giuseppe/fix-healthchecks
v2, podman: fix healthchecks
2020-04-27 15:40:24 +02:00
OpenShift Merge Robot
529824ec1e Merge pull request #5997 from giuseppe/fix-pod-create
v2, podman: fix a bunch of "podman pod *" tests
2020-04-27 15:37:58 +02:00
OpenShift Merge Robot
ef46687dc5 Merge pull request #5976 from QiWang19/manifest-add-os
Add --os to manifest add
2020-04-27 15:33:00 +02:00
Giuseppe Scrivano
869a1a211a pkg, pods: report pod rm errors
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 14:02:53 +02:00
Giuseppe Scrivano
1aaef86eb4 pkg, pods: pod rm honors --ignore
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:47:52 +02:00
Giuseppe Scrivano
4028215b6a pkg, pods: not lose pod start/restart errors
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:41:08 +02:00
Giuseppe Scrivano
e589c2219f pkg, pods: honor --ignore for pod stop
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:19:05 +02:00
Giuseppe Scrivano
c2f77a281f specgen: relax test to accept default network
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:12:19 +02:00
Giuseppe Scrivano
adb10783d9 spec, pod: honor --dns
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 12:58:02 +02:00