Ed Santiago 6a696cb8fd podman-registry: simpler, safer invocations ...

First: fix podman-registry script so it preserves the initial $PODMAN,
so all subsequent invocations of ps, logs, and stop will use the
same binary and arguments. Until now we've handled this by requiring
that our caller manage $PODMAN (and keep it the same), but that's
just wrong.

Next, simplify the golang interface: move the $PODMAN setting into
registry.go, instead of requiring e2e callers to set it. (This
could use some work: the local/remote conditional is icky).

IMPORTANT: To prevent registry.go from using the wrong podman binary,
the Start() call is gone. Only StartWithOptions() is valid now.

And, minor cleanup: comments, and add an actual error-message check

Reason for this PR is a recurring flake, #18355, whose multiple
failure modes I truly can't understand. I don't think this PR
is going to fix it, but this is still necessary work.

Signed-off-by: Ed Santiago <santiago@redhat.com>

2023-06-07 12:16:18 -06:00

..

build

Do not include image annotations when building spec

2023-05-11 23:48:23 -04:00

cdi

build(deps): bump github.com/container-orchestrated-devices/container-device-interface

2023-02-20 14:51:04 +01:00

config

Read kube_generate_type from containers.conf

2023-04-11 09:15:05 -04:00

quadlet

Add support for SecurityLabelNested flag in quadlet

2023-06-06 10:30:48 -04:00

sign

e2e: reduce dependency on /tmp for e2e tests

2023-01-26 22:20:15 +09:00

testdata

Add (podman {image,manifest} push --sign-by-sigstore=param-file.yaml)

2023-01-27 16:47:32 +01:00

attach_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

build_test.go

Support podman --remote when Containerfile is not in context directory

2023-05-22 11:58:36 -04:00

checkpoint_image_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

checkpoint_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

cleanup_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

commit_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

common_test.go

logformatter: better recognition of ginkgo test names

2023-06-06 14:32:15 -06:00

config_amd64.go

e2e tests: stop using UBI images

2023-01-06 08:21:50 -07:00

config_arm64.go

e2e tests: stop using UBI images

2023-01-06 08:21:50 -07:00

config_ppc64le.go

e2e tests: cleanup: capitalize CONSTANTS

2022-07-05 15:36:08 -06:00

config.go

*: migrate image registry to registry.k8s.io

2023-04-11 10:30:43 -04:00

container_clone_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

container_create_volume_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

container_inspect_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

containers_conf_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

cp_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

create_staticip_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

create_staticmac_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

create_test.go

libpod: fix timezone handling

2023-06-01 11:04:13 +02:00

diff_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

events_test.go

fix: podman event --filter volume=vol-name should compare the event name with volume name

2023-05-22 19:11:15 +05:30

exec_test.go

e2e: add ginkgo decorators to address flakes

2023-06-07 07:10:25 -06:00

exists_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

export_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

generate_kube_test.go

Add default ulimit test for gen kube

2023-06-02 11:19:59 +00:00

generate_spec_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

generate_systemd_test.go

generate systemd: error on init containers

2023-05-17 14:50:23 +02:00

healthcheck_run_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

history_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

image_scp_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

image_sign_test.go

e2e: refactor and document serialization

2023-05-16 04:48:55 -06:00

images_test.go

test/e2e: add regression testing for comma-containing labels

2023-05-25 22:56:27 +02:00

import_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

info_test.go

Address review feedback and add manpage notes

2023-06-06 11:04:59 -04:00

init_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

inspect_test.go

set max ulimits for rootless on each start

2023-05-31 09:20:31 +00:00

kill_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

libpod_suite_remote_test.go

podman-registry: simpler, safer invocations

2023-06-07 12:16:18 -06:00

libpod_suite_test.go

test/e2e: switch to GinkgoWriter

2023-05-02 11:27:38 +02:00

load_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

login_logout_test.go

test/e2e: do not call setenforce

2023-05-17 17:28:20 +02:00

logs_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

manifest_test.go

podman-registry: simpler, safer invocations

2023-06-07 12:16:18 -06:00

mount_rootless_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

mount_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

negative_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

network_connect_disconnect_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

network_create_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

network_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pause_test.go

test/e2e: add regression testing for comma-containing labels

2023-05-25 22:56:27 +02:00

play_build_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

play_kube_test.go

Add --configmap to podman-remote kube play

2023-05-17 14:23:55 +00:00

pod_clone_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_create_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_infra_container_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_initcontainers_test.go

source code comments and docs: fix typos, language, Markdown layout

2023-05-22 07:52:16 +02:00

pod_inspect_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_kill_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_pause_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_pod_namespaces_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_prune_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_ps_test.go

test/e2e: add regression testing for comma-containing labels

2023-05-25 22:56:27 +02:00

pod_restart_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_rm_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_start_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_stats_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_stop_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

pod_top_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

port_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

prune_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

ps_test.go

test/e2e: add regression testing for comma-containing labels

2023-05-25 22:56:27 +02:00

pull_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

push_test.go

test/e2e: do not call setenforce

2023-05-17 17:28:20 +02:00

quadlet_test.go

Add support for SecurityLabelNested flag in quadlet

2023-06-06 10:30:48 -04:00

rename_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

restart_test.go

test/e2e: add regression testing for comma-containing labels

2023-05-25 22:56:27 +02:00

rm_test.go

test/e2e: add regression testing for comma-containing labels

2023-05-25 22:56:27 +02:00

rmi_test.go

In a concurrent removal test, don't remove concurrently with builds

2023-05-23 18:14:33 +02:00

run_aardvark_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_apparmor_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_cgroup_parent_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_cleanup_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_cpu_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_device_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_dns_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_entrypoint_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_env_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_exit_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_memory_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_networking_test.go

network create/update: allow dns servers comma separated

2023-05-22 13:30:39 +02:00

run_ns_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_passwd_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_privileged_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_restart_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_seccomp_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_security_labels_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_selinux_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_signal_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_staticip_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_test.go

libpod: fix timezone handling

2023-06-01 11:04:13 +02:00

run_transient_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_userns_test.go

run: ignore PODMAN_USERNS with --pod

2023-05-17 16:49:16 +02:00

run_volume_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

run_working_dir_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

runlabel_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

save_test.go

Merge pull request #18563 from vrothberg/fix-15897

2023-05-15 13:20:18 -04:00

search_test.go

e2e: add ginkgo decorators to address flakes

2023-06-07 07:10:25 -06:00

secret_test.go

test/e2e: add regression testing for comma-containing labels

2023-05-25 22:56:27 +02:00

start_test.go

test/e2e: add regression testing for comma-containing labels

2023-05-25 22:56:27 +02:00

stats_test.go

stats: get mem limit from the cgroup

2023-05-19 14:59:43 +02:00

stop_test.go

test/e2e: add regression testing for comma-containing labels

2023-05-25 22:56:27 +02:00

system_connection_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

system_df_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

system_dial_stdio_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

system_reset_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

system_service_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

systemd_activate_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

systemd_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

tag_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

toolbox_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

top_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

tree_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

trust_test.go

e2e: add ginkgo decorators to address flakes

2023-06-07 07:10:25 -06:00

unshare_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

untag_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

update_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

version_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

volume_create_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

volume_exists_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

volume_inspect_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

volume_ls_test.go

test/e2e: add regression testing for comma-containing labels

2023-05-25 22:56:27 +02:00

volume_plugin_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

volume_prune_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

volume_rm_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00

wait_test.go

test/e2e: dedup Before/AfterEach nodes

2023-05-15 16:56:18 +02:00