mirror/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2026-03-19 07:08:38 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
88b8d2829ced423593f40030c04662ee596740b7
podman/libpod
History
Matthew Heon 4b784b377c Remove all instances of named return "err" from Libpod 
This was inspired by https://github.com/cri-o/cri-o/pull/3934 and
much of the logic for it is contained there. However, in brief,
a named return called "err" can cause lots of code confusion and
encourages using the wrong err variable in defer statements,
which can make them work incorrectly. Using a separate name which
is not used elsewhere makes it very clear what the defer should
be doing.

As part of this, remove a large number of named returns that were
not used anywhere. Most of them were once needed, but are no
longer necessary after previous refactors (but were accidentally
retained).

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-07-09 13:54:47 -04:00
..
common
Set blob cache directory based on GraphDriver
2019-03-29 08:27:33 -04:00
define
Implement --sdnotify cmdline option to control sd-notify behavior
2020-07-06 17:47:18 +00:00
driver
removMergeDir from inspect result if not mounted
2019-08-13 15:13:20 -04:00
events
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
filters
move go module to v2
2020-07-06 15:50:12 +02:00
image
Fix saving in oci format
2020-07-09 08:03:54 -04:00
layers
Initial checkin from CRI-O repo
2017-11-01 11:24:59 -04:00
linkmode
Add podman static build
2020-05-11 13:11:07 +02:00
lock
move go module to v2
2020-07-06 15:50:12 +02:00
logs
move go module to v2
2020-07-06 15:50:12 +02:00
boltdb_state_internal.go
move go module to v2
2020-07-06 15:50:12 +02:00
boltdb_state_linux.go
move go module to v2
2020-07-06 15:50:12 +02:00
boltdb_state_unsupported.go
podman-remote inspect
2019-01-18 15:43:11 -06:00
boltdb_state.go
move go module to v2
2020-07-06 15:50:12 +02:00
common_test.go
move go module to v2
2020-07-06 15:50:12 +02:00
container_api.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
container_commit.go
move go module to v2
2020-07-06 15:50:12 +02:00
container_exec.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
container_graph_test.go
move go module to v2
2020-07-06 15:50:12 +02:00
container_graph.go
move go module to v2
2020-07-06 15:50:12 +02:00
container_inspect.go
Merge pull request #6836 from ashley-cui/tzlibpod
2020-07-06 13:28:20 -04:00
container_internal_linux_test.go
Add username to /etc/passwd inside of container if --userns keep-id
2020-07-07 08:34:31 -04:00
container_internal_linux.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
container_internal_test.go
vendor: update seccomp/containers-golang to v0.4.1
2020-05-21 16:16:09 +02:00
container_internal_unsupported.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
container_internal.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
container_linux.go
Do not fetch pod and ctr State on retrieval in Bolt
2018-07-31 14:19:50 +00:00
container_log_linux.go
log API: add context to allow for cancelling
2020-07-09 15:13:07 +02:00
container_log_unsupported.go
log API: add context to allow for cancelling
2020-07-09 15:13:07 +02:00
container_log.go
log API: add context to allow for cancelling
2020-07-09 15:13:07 +02:00
container_top_linux.go
move go module to v2
2020-07-06 15:50:12 +02:00
container_top_unsupported.go
move go module to v2
2020-07-06 15:50:12 +02:00
container_unsupported.go
Do not fetch pod and ctr State on retrieval in Bolt
2018-07-31 14:19:50 +00:00
container_validate.go
move go module to v2
2020-07-06 15:50:12 +02:00
container.go
Add username to /etc/passwd inside of container if --userns keep-id
2020-07-07 08:34:31 -04:00
diff.go
move go module to v2
2020-07-06 15:50:12 +02:00
events.go
fix race condition in libpod.GetEvents(...)
2020-07-07 16:22:22 +02:00
healthcheck_linux.go
move go module to v2
2020-07-06 15:50:12 +02:00
healthcheck_unsupported.go
move go module to v2
2020-07-06 15:50:12 +02:00
healthcheck.go
move go module to v2
2020-07-06 15:50:12 +02:00
in_memory_state.go
move go module to v2
2020-07-06 15:50:12 +02:00
info.go
move go module to v2
2020-07-06 15:50:12 +02:00
kube.go
move go module to v2
2020-07-06 15:50:12 +02:00
mounts_linux.go
set root propagation based on volume properties
2018-11-26 13:55:02 +01:00
networking_linux.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
networking_unsupported.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
oci_attach_linux_cgo.go
Implement conmon exec
2019-07-22 15:57:23 -04:00
oci_attach_linux_nocgo.go
Implement conmon exec
2019-07-22 15:57:23 -04:00
oci_attach_linux.go
move go module to v2
2020-07-06 15:50:12 +02:00
oci_attach_unsupported.go
move go module to v2
2020-07-06 15:50:12 +02:00
oci_conmon_exec_linux.go
Implement --sdnotify cmdline option to control sd-notify behavior
2020-07-06 17:47:18 +00:00
oci_conmon_linux.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
oci_conmon_unsupported.go
move go module to v2
2020-07-06 15:50:12 +02:00
oci_conmon.go
podman: add new cgroup mode split
2020-06-25 17:16:12 +02:00
oci_missing.go
move go module to v2
2020-07-06 15:50:12 +02:00
oci_util.go
move go module to v2
2020-07-06 15:50:12 +02:00
oci.go
move go module to v2
2020-07-06 15:50:12 +02:00
options.go
Add username to /etc/passwd inside of container if --userns keep-id
2020-07-07 08:34:31 -04:00
pod_api.go
move go module to v2
2020-07-06 15:50:12 +02:00
pod_internal.go
move go module to v2
2020-07-06 15:50:12 +02:00
pod_status.go
move go module to v2
2020-07-06 15:50:12 +02:00
pod_top_linux.go
move go module to v2
2020-07-06 15:50:12 +02:00
pod_top_unsupported.go
move go module to v2
2020-07-06 15:50:12 +02:00
pod.go
move go module to v2
2020-07-06 15:50:12 +02:00
reset.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime_cstorage.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime_ctr.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
runtime_img_test.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime_img.go
Fix saving in oci format
2020-07-09 08:03:54 -04:00
runtime_migrate_unsupported.go
Add podman system reset command
2019-11-29 05:34:52 -05:00
runtime_migrate.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime_pod_infra_linux.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime_pod_linux.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime_pod_unsupported.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime_pod.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime_renumber.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime_volume_linux.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime_volume_unsupported.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime_volume.go
move go module to v2
2020-07-06 15:50:12 +02:00
runtime.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
state_test.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
state.go
Add support for containers.conf
2020-03-27 14:36:03 -04:00
stats_unsupported.go
move go module to v2
2020-07-06 15:50:12 +02:00
stats.go
move go module to v2
2020-07-06 15:50:12 +02:00
storage.go
Remove all instances of named return "err" from Libpod
2020-07-09 13:54:47 -04:00
util_linux.go
move go module to v2
2020-07-06 15:50:12 +02:00
util_test.go
move go module to v2
2020-07-06 15:50:12 +02:00
util_unsupported.go
move go module to v2
2020-07-06 15:50:12 +02:00
util.go
move go module to v2
2020-07-06 15:50:12 +02:00
volume_inspect.go
move go module to v2
2020-07-06 15:50:12 +02:00
volume_internal_linux.go
move go module to v2
2020-07-06 15:50:12 +02:00
volume_internal_unsupported.go
move go module to v2
2020-07-06 15:50:12 +02:00
volume_internal.go
move go module to v2
2020-07-06 15:50:12 +02:00
volume.go
move go module to v2
2020-07-06 15:50:12 +02:00