Matt Heon 925794c6aa
Ensure HC events fire after logs are written ...
HC events were firing as part of the `exec` call, before it had
even been decided whether the HC succeeded or failed. As such,
the status was not going to be correct any time there was a
change (e.g. the first event after a container went healthy to
unhealthy would still read healthy). Move the event into the
actual Healthcheck function and throw it in a defer to make sure
it happens at the very end, after logs are written.
Ignores several conditions that did not log previously (container
in question does not have a healthcheck, or an internal failure
that should not really happen).
Still not a perfect solution. This relies on the HC log being
written, when instead we could just get the status straight from
the function writing the event - so if we fail to write the log,
we can still report a bad status. But if the log wasn't written,
we're in bad shape regardless - `podman ps` would disagree with
the event written, for example.
Fixes #19237
Signed-off-by: Matt Heon <mheon@redhat.com >
2023-09-11 08:02:46 -04:00
2023-09-07 15:18:02 +02:00
2022-01-18 12:47:07 +01:00
2023-07-24 11:18:25 +02:00
2017-11-01 11:24:59 -04:00
2022-03-18 09:11:53 +01:00
2023-06-12 13:27:34 -04:00
2023-08-09 14:48:01 +02:00
2022-10-17 09:19:41 +02:00
2023-02-28 13:45:36 -05:00
2023-07-11 15:16:11 +02:00
2022-08-23 15:31:00 +01:00
2023-05-25 13:14:27 +02:00
2022-01-18 12:47:07 +01:00
2023-09-07 15:18:02 +02:00
2023-04-20 06:24:35 -04:00
2023-07-30 06:09:30 -04:00
2022-09-20 08:36:23 +01:00
2022-09-20 08:36:23 +01:00
2022-09-20 08:36:23 +01:00
2022-09-20 08:36:23 +01:00
2023-09-11 08:02:46 -04:00
2022-12-16 18:30:12 +01:00
2022-01-18 12:47:07 +01:00
2023-06-01 16:27:27 -04:00
2022-09-15 08:10:34 +01:00
2023-02-20 14:51:04 +01:00
2023-09-08 06:56:05 -04:00
2023-08-31 12:34:58 +02:00
2023-08-17 14:04:53 +01:00
2023-02-07 09:34:15 -05:00
2023-08-17 14:04:53 +01:00
2023-07-06 11:16:34 +02:00
2022-09-05 10:12:12 +01:00
2023-09-08 14:58:48 +02:00
2022-12-16 18:30:12 +01:00
2023-02-20 13:58:16 +01:00
2023-02-20 13:58:16 +01:00
2023-08-09 14:48:01 +02:00
2022-09-14 17:09:04 +02:00
2023-07-14 07:17:21 -04:00
2023-02-09 21:56:27 +01:00
2022-09-20 08:36:23 +01:00
2022-09-20 08:36:23 +01:00
2022-09-20 08:36:23 +01:00
2023-07-28 10:52:20 +01:00
2023-07-10 13:32:55 +02:00
2023-08-11 13:43:23 +02:00
2023-07-10 13:32:55 +02:00
2022-08-23 15:31:00 +01:00
2022-12-16 14:20:14 +01:00
2023-08-07 08:16:48 +01:00
2022-07-05 16:06:32 +02:00
2022-03-23 19:05:29 +01:00
2022-11-29 10:40:24 +01:00
2022-12-08 15:01:57 +01:00
2022-12-05 20:58:30 +01:00
2023-07-25 15:30:28 +01:00
2023-09-11 08:02:46 -04:00
2022-09-10 07:52:00 -04:00
2023-06-22 11:16:13 +02:00
2022-11-13 10:56:15 +00:00
2022-08-24 10:55:52 +01:00
2023-07-24 19:53:34 +02:00
2023-09-07 09:49:11 -04:00
2022-03-18 09:11:53 +01:00
2023-07-31 17:40:41 +02:00
2023-08-21 16:00:41 +01:00
2022-04-25 13:23:20 +02:00
2023-07-31 17:40:41 +02:00
2022-09-20 15:34:27 -04:00
2023-06-15 16:14:49 +02:00
2023-06-22 11:16:13 +02:00
2023-07-24 11:18:25 +02:00
2023-07-25 11:17:44 +02:00
2022-08-18 08:07:30 +01:00
2022-08-18 08:05:42 +01:00
2023-09-07 14:13:14 -06:00
2023-08-28 19:43:24 +02:00
2022-09-07 07:58:37 +01:00
2022-09-07 07:58:37 +01:00
2022-08-29 13:04:04 +01:00
2023-08-17 15:32:59 +02:00
2022-08-18 08:07:30 +01:00
2020-06-25 17:16:12 +02:00
2022-09-01 13:02:01 -04:00
2022-07-05 16:06:32 +02:00
2022-10-17 09:19:41 +02:00
2023-08-04 08:36:45 -04:00
2023-09-08 14:58:48 +02:00
2022-10-07 08:26:10 +01:00
2023-07-10 22:37:43 +02:00
2023-02-22 11:00:50 -05:00
2022-01-18 12:47:07 +01:00
2023-07-28 10:52:20 +01:00
2022-05-25 12:30:19 +02:00
2023-07-28 10:52:20 +01:00
2023-09-08 14:58:48 +02:00
2023-06-01 16:24:59 -04:00
2023-05-31 09:20:31 +00:00
2023-05-31 09:20:31 +00:00
2022-09-22 13:07:40 -04:00
2022-09-05 10:20:50 +01:00
2022-09-05 10:20:50 +01:00
2023-09-05 14:35:37 -04:00
2023-06-01 16:27:27 -04:00
2022-08-17 11:45:07 +01:00
2023-04-11 10:57:46 +02:00
2023-09-08 14:58:48 +02:00
2023-09-08 14:58:48 +02:00
2023-09-08 14:58:48 +02:00
2022-10-07 08:27:27 +01:00
2023-06-01 16:24:59 -04:00
2023-04-26 14:55:03 -04:00
2023-01-26 10:20:38 +01:00
2023-04-26 14:55:03 -04:00
2023-07-14 07:17:21 -04:00
2022-09-27 16:31:40 +01:00
2022-07-04 15:39:00 +02:00
2022-05-25 10:17:46 +02:00
2023-06-06 11:04:59 -04:00
2023-05-25 14:46:34 +02:00
2023-07-11 15:16:11 +02:00
2023-06-19 14:31:40 +02:00
2023-02-22 11:00:50 -05:00
2023-02-22 11:00:50 -05:00
2023-05-31 07:41:30 +03:00
2023-07-28 10:52:20 +01:00
2023-05-31 07:41:30 +03:00
2022-09-14 08:29:26 +01:00
2023-04-05 17:58:30 -04:00
2023-03-09 12:36:52 -05:00
2023-03-09 12:36:52 -05:00
2023-09-08 14:58:48 +02:00
2022-01-18 12:47:07 +01:00
2023-03-09 12:36:52 -05:00
2023-08-24 16:22:28 +02:00
2023-06-05 12:28:50 -04:00
2023-07-14 07:17:21 -04:00
2022-09-27 16:31:40 +01:00
2022-09-27 16:31:40 +01:00
2022-09-27 16:31:40 +01:00
2023-02-22 11:00:50 -05:00
2023-05-09 09:33:37 -04:00
925794c6aa