mirror/podman
1
0
Fork 0
mirror of https://github.com/containers/podman.git synced 2026-03-17 22:28:22 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
92cdad0315d42b4d9bc36d1cd7aa1752a31f2db3
podman/libpod
History
Matthew Heon 92cdad0315 Fix a potential defer logic error around locking 
in several top-level API functions. These are the first line of
the function that contains them, which makes sense; we want to
capture any error returned by the function. However, making this
the first defer means that it is the last thing to run after the
function returns - meaning that the container's
`defer c.lock.Unlock()` has already fired, leading to a chance we
modify the container without holding its lock.

We could move the function around so it's no longer the first
defer, but then we'd have to call it twice (immediately after
`defer c.lock.Unlock()` if the container is not batched, and a
second time in a new `else` block right after the lock/sync call
to make sure we handle batched containers). Seems simpler to just
leave it like this.

[NO NEW TESTS NEEDED] Can't really test for DB corruption easily.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2023-01-06 13:12:19 -05:00
..
define
libpod: remove CNI word were no longer applicable
2022-12-16 14:20:14 +01:00
driver
bump go module to version 4
2022-01-18 12:47:07 +01:00
events
journald: podman logs --until --follow exit after time
2023-01-06 15:19:22 +01:00
layers
Initial checkin from CRI-O repo
2017-11-01 11:24:59 -04:00
linkmode
go fmt: use go 1.18 conditional-build syntax
2022-03-18 09:11:53 +01:00
lock
Update c/storage after https://github.com/containers/storage/pull/1436
2022-12-01 16:05:13 +01:00
logs
bump golangci-lint to v1.50.1
2022-12-15 13:39:56 +01:00
plugin
bump golangci-lint to v1.49.0
2022-10-17 09:19:41 +02:00
shutdown
libpod: switch to golang native error wrapping
2022-07-05 16:06:32 +02:00
boltdb_state_internal.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
boltdb_state_unsupported.go
libpod: Add definition of containerPlatformState for FreeBSD
2022-08-23 15:31:00 +01:00
boltdb_state.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
common_test.go
bump go module to version 4
2022-01-18 12:47:07 +01:00
container_api.go
Fix a potential defer logic error around locking
2023-01-06 13:12:19 -05:00
container_commit.go
Fix stutters
2022-09-10 07:52:00 -04:00
container_config.go
libpod: remove CNI word were no longer applicable
2022-12-16 14:20:14 +01:00
container_copy_common.go
libpod: Implement 'podman cp' for FreeBSD
2022-09-20 08:36:23 +01:00
container_copy_freebsd.go
libpod: Implement 'podman cp' for FreeBSD
2022-09-20 08:36:23 +01:00
container_copy_linux.go
libpod: Move jointMountAndExec to container_copy_linux.go
2022-09-20 08:36:23 +01:00
container_copy_unsupported.go
libpod: Implement 'podman cp' for FreeBSD
2022-09-20 08:36:23 +01:00
container_exec.go
Replace deprecated ioutil
2022-09-20 15:34:27 -04:00
container_freebsd.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
container_graph_test.go
bump go module to version 4
2022-01-18 12:47:07 +01:00
container_graph.go
Introduce graph-based pod container removal
2022-09-14 13:44:48 -04:00
container_inspect_freebsd.go
libpod: Factor out platform-specfic code from generateInspectContainerHostConfig
2022-09-15 08:10:34 +01:00
container_inspect_linux.go
Vendor in latest containers/common with default capabilities
2022-12-15 14:28:30 -05:00
container_inspect.go
Add container error message to ContainerState
2023-01-03 13:21:24 -05:00
container_internal_common.go
Merge pull request #16800 from Luap99/restore-static-ip
2022-12-16 11:03:40 -05:00
container_internal_freebsd.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
container_internal_linux_test.go
test: use T.TempDir to create temporary test directory
2022-05-05 21:09:41 +08:00
container_internal_linux.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
container_internal_test.go
When in transient store mode, use rundir for bundlepath
2022-12-21 12:50:23 +01:00
container_internal_unsupported.go
libpod: Add FreeBSD implementation of container internals
2022-09-05 10:12:12 +01:00
container_internal.go
libpod: fix race condition rm'ing stopping containers
2023-01-04 08:53:19 +01:00
container_linux.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
container_log_linux.go
journald: podman logs --until --follow exit after time
2023-01-06 15:19:22 +01:00
container_log_unsupported.go
libpod: switch to golang native error wrapping
2022-07-05 16:06:32 +02:00
container_log.go
k8s-file: podman logs --until --follow exit after time
2023-01-06 15:19:23 +01:00
container_path_resolution_test.go
libpod: fix lookup for subpath in volumes
2022-09-14 17:09:04 +02:00
container_path_resolution.go
bump golangci-lint to v1.49.0
2022-10-17 09:19:41 +02:00
container_stat_common.go
libpod: Implement 'podman cp' for FreeBSD
2022-09-20 08:36:23 +01:00
container_stat_freebsd.go
libpod: Implement 'podman cp' for FreeBSD
2022-09-20 08:36:23 +01:00
container_stat_linux.go
libpod: Move part of (*Container).stat to container_stat_linux.go
2022-09-20 08:36:23 +01:00
container_stat_unsupported.go
libpod: Implement 'podman cp' for FreeBSD
2022-09-20 08:36:23 +01:00
container_top_freebsd.go
libpod: Add support for 'podman top' on FreeBSD
2022-10-17 16:43:53 +01:00
container_top_linux.go
Fix stutters
2022-09-10 07:52:00 -04:00
container_top_unsupported.go
libpod: Add support for 'podman top' on FreeBSD
2022-10-17 16:43:53 +01:00
container_unsupported.go
libpod: Add definition of containerPlatformState for FreeBSD
2022-08-23 15:31:00 +01:00
container_validate.go
libpod: remove CNI word were no longer applicable
2022-12-16 14:20:14 +01:00
container.go
Add container error message to ContainerState
2023-01-03 13:21:24 -05:00
diff.go
libpod: switch to golang native error wrapping
2022-07-05 16:06:32 +02:00
doc.go
document that using libpod package directly is not supported
2022-03-23 19:05:29 +01:00
events.go
container create: add inspect data to event
2022-11-29 10:40:24 +01:00
healthcheck_linux.go
health check: ignore dependencies of transient systemd units/timers
2022-12-08 15:01:57 +01:00
healthcheck_nosystemd_linux.go
disable healthchecks automatically on non systemd systems
2022-12-05 20:58:30 +01:00
healthcheck_unsupported.go
libpod: Track healthcheck API changes in healthcheck_unsupported.go
2022-12-02 16:41:21 +00:00
healthcheck.go
disable healthchecks automatically on non systemd systems
2022-12-05 20:58:30 +01:00
info_freebsd.go
Fix stutters
2022-09-10 07:52:00 -04:00
info_linux.go
Fix stutters
2022-09-10 07:52:00 -04:00
info_test.go
libpod: Make unit test for statToPercent Linux only
2022-11-13 10:56:15 +00:00
info_unsupported.go
libpod: Enable 'podman info' for FreeBSD
2022-08-24 10:55:52 +01:00
info.go
runtime: Handle the transient store options
2022-12-05 18:09:21 +01:00
kube.go
Vendor in latest containers/common with default capabilities
2022-12-15 14:28:30 -05:00
mounts_linux.go
go fmt: use go 1.18 conditional-build syntax
2022-03-18 09:11:53 +01:00
networking_common.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
networking_freebsd.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
networking_linux_test.go
enable unparam linter
2022-04-25 13:23:20 +02:00
networking_linux.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
networking_machine.go
Replace deprecated ioutil
2022-09-20 15:34:27 -04:00
networking_pasta_linux.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
networking_slirp4netns.go
libpod: move NetNS into state db instead of extra bucket
2022-12-16 18:30:12 +01:00
networking_unsupported.go
libpod: remove CNI word were no longer applicable
2022-12-16 14:20:14 +01:00
oci_conmon_attach_common.go
bump golangci-lint to v1.49.0
2022-10-17 09:19:41 +02:00
oci_conmon_attach_freebsd.go
libpod: Build oci_conmon_common.go and oci_conmon_attach_common on FreeBSD
2022-08-18 08:07:30 +01:00
oci_conmon_attach_linux.go
libpod: Move openUnixSocket to oci_conmon_attach_linux.go
2022-08-18 08:05:42 +01:00
oci_conmon_common.go
libpod: fix header length in http attach with logs
2022-12-16 14:18:30 +01:00
oci_conmon_exec_common.go
Replace deprecated ioutil
2022-09-20 15:34:27 -04:00
oci_conmon_exec_freebsd.go
libpod: Factor out capabilites code from prepareProcessExec
2022-09-07 07:58:37 +01:00
oci_conmon_exec_linux.go
libpod: Factor out capabilites code from prepareProcessExec
2022-09-07 07:58:37 +01:00
oci_conmon_freebsd.go
libpod: Make sure writeConmonPipeData is called on FreeBSD
2022-08-29 13:04:04 +01:00
oci_conmon_linux.go
Add and use Container.LinuxResource() helper
2022-10-12 13:45:49 +02:00
oci_conmon_unsupported.go
libpod: Build oci_conmon_common.go and oci_conmon_attach_common on FreeBSD
2022-08-18 08:07:30 +01:00
oci_conmon.go
podman: add new cgroup mode split
2020-06-25 17:16:12 +02:00
oci_missing.go
implement podman update
2022-09-01 13:02:01 -04:00
oci_util.go
libpod: switch to golang native error wrapping
2022-07-05 16:06:32 +02:00
oci.go
bump golangci-lint to v1.49.0
2022-10-17 09:19:41 +02:00
options.go
libpod: remove CNI word were no longer applicable
2022-12-16 14:20:14 +01:00
pod_api.go
Merge pull request #16818 from SoMuchForSubtlety/api-port-bindings
2022-12-15 20:19:53 -05:00
pod_internal_freebsd.go
libpod: Factor out cgroups handling from (*Pod).refresh
2022-10-07 08:26:10 +01:00
pod_internal_linux.go
libpod: Factor out cgroups handling from (*Pod).refresh
2022-10-07 08:26:10 +01:00
pod_internal.go
bump golangci-lint to v1.50.1
2022-12-15 13:39:56 +01:00
pod_status.go
bump go module to version 4
2022-01-18 12:47:07 +01:00
pod_top_linux.go
libpod/pod_top_linux.go: s/TODO/NOTE/
2022-05-25 12:30:19 +02:00
pod_top_unsupported.go
libpod: Add stubs for non-linux builds
2022-08-17 11:45:07 +01:00
pod.go
resource limits for pods
2022-07-21 14:50:01 -04:00
reset.go
Update c/storage after https://github.com/containers/storage/pull/1436
2022-12-01 16:05:13 +01:00
runtime_cstorage.go
Add support for 'image' volume driver
2022-09-22 13:07:40 -04:00
runtime_ctr_freebsd.go
libpod: Don't mount /dev/shm in containers on FreeBSD
2022-09-05 10:20:50 +01:00
runtime_ctr_linux.go
libpod: Don't mount /dev/shm in containers on FreeBSD
2022-09-05 10:20:50 +01:00
runtime_ctr.go
runtime: do not chown idmapped volumes
2022-12-05 14:10:43 +01:00
runtime_img.go
Add support for 'image' volume driver
2022-09-22 13:07:40 -04:00
runtime_migrate_unsupported.go
libpod: Add stubs for non-linux builds
2022-08-17 11:45:07 +01:00
runtime_migrate.go
Replace deprecated ioutil
2022-09-20 15:34:27 -04:00
runtime_pod_common.go
libpod: Add support for 'podman pod' on FreeBSD
2022-10-07 08:27:27 +01:00
runtime_pod_freebsd.go
libpod: Add support for 'podman pod' on FreeBSD
2022-10-07 08:27:27 +01:00
runtime_pod_linux.go
libpod: Factor out cgroup validation from (*Runtime).NewPod
2022-10-07 08:27:27 +01:00
runtime_pod_unsupported.go
libpod: Add support for 'podman pod' on FreeBSD
2022-10-07 08:27:27 +01:00
runtime_pod.go
libpod/runtime: switch to golang native error wrapping
2022-07-04 15:39:00 +02:00
runtime_renumber.go
Fix stutters
2022-09-10 07:52:00 -04:00
runtime_test.go
libpod: Ensure that generated container names are random
2022-09-01 10:27:04 +01:00
runtime_volume_common.go
Add podman volume create --ignore
2022-10-24 17:30:31 +02:00
runtime_volume_unsupported.go
libpod: Add volume support for FreeBSD
2022-09-27 16:31:40 +01:00
runtime_volume.go
libpod/runtime: switch to golang native error wrapping
2022-07-04 15:39:00 +02:00
runtime_worker.go
work queue: simplify and use a wait group
2022-05-25 10:17:46 +02:00
runtime.go
rootless: always create userns with euid != 0
2022-12-20 13:33:23 +01:00
service.go
libpod: switch to golang native error wrapping
2022-07-05 16:06:32 +02:00
state_test.go
Replace deprecated ioutil
2022-09-20 15:34:27 -04:00
state.go
checkpoint restore: fix --ignore-static-ip/mac
2022-12-12 18:34:49 +01:00
stats_common.go
libpod: Split out the common code from GetContainerStats
2022-09-14 08:29:26 +01:00
stats_freebsd.go
Fix swapped NetInput/-Output stats
2022-11-28 12:26:41 +01:00
stats_linux.go
Fix swapped NetInput/-Output stats
2022-11-28 12:26:41 +01:00
stats_unsupported.go
libpod: Add support for 'podman stats' on FreeBSD
2022-09-14 08:29:26 +01:00
storage.go
libpod: switch to golang native error wrapping
2022-07-05 16:06:32 +02:00
util_freebsd.go
libpod: Add support for 'podman pod' on FreeBSD
2022-10-07 08:27:27 +01:00
util_linux_test.go
Fix mismatch between log messages and behavior of libpod.LabelVolumePath.
2020-09-13 23:24:15 -04:00
util_linux.go
Fix stutters
2022-09-10 07:52:00 -04:00
util_test.go
bump go module to version 4
2022-01-18 12:47:07 +01:00
util_unsupported.go
libpod: Add volume support for FreeBSD
2022-09-27 16:31:40 +01:00
util.go
remove unmapped ports from inspect port bindings
2022-12-15 23:18:50 +01:00
volume_inspect.go
Add support for 'image' volume driver
2022-09-22 13:07:40 -04:00
volume_internal_common.go
libpod: Add volume support for FreeBSD
2022-09-27 16:31:40 +01:00
volume_internal_freebsd.go
libpod: Add volume support for FreeBSD
2022-09-27 16:31:40 +01:00
volume_internal_linux.go
libpod: Factor out usage of unix.MNT_DETACH from (*Volume).unmount
2022-09-27 16:31:40 +01:00
volume_internal_unsupported.go
libpod: Add volume support for FreeBSD
2022-09-27 16:31:40 +01:00
volume_internal.go
Add support for 'image' volume driver
2022-09-22 13:07:40 -04:00
volume.go
Merge pull request #16243 from alexlarsson/volume-create-ignore
2022-10-26 15:00:51 -04:00