mirror of
https://github.com/containers/podman.git
synced 2026-06-07 23:36:09 -04:00
dc80267b59
* Support the `X-Registry-Auth` http-request header. * The content of the header is a base64 encoded JSON payload which can either be a single auth config or a map of auth configs (user+pw or token) with the corresponding registries being the keys. Vanilla Docker, projectatomic Docker and the bindings are transparantly supported. * Add a hidden `--registries-conf` flag. Buildah exposes the same flag, mostly for testing purposes. * Do all credential parsing in the client (i.e., `cmd/podman`) pass the username and password in the backend instead of unparsed credentials. * Add a `pkg/auth` which handles most of the heavy lifting. * Go through the authentication-handling code of most commands, bindings and endpoints. Migrate them to the new code and fix issues as seen. A final evaluation and more tests is still required *after* this change. * The manifest-push endpoint is missing certain parameters and should use the ABI function instead. Adding auth-support isn't really possible without these parts working. * The container commands and endpoints (i.e., create and run) have not been changed yet. The APIs don't yet account for the authfile. * Add authentication tests to `pkg/bindings`. Fixes: #6384 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
50 lines
1.3 KiB
Go
50 lines
1.3 KiB
Go
package containers
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
"net/url"
|
|
"strconv"
|
|
|
|
"github.com/containers/libpod/pkg/api/handlers"
|
|
"github.com/containers/libpod/pkg/bindings"
|
|
)
|
|
|
|
// Commit creates a container image from a container. The container is defined by nameOrId. Use
|
|
// the CommitOptions for finer grain control on characteristics of the resulting image.
|
|
func Commit(ctx context.Context, nameOrId string, options CommitOptions) (handlers.IDResponse, error) {
|
|
id := handlers.IDResponse{}
|
|
conn, err := bindings.GetClient(ctx)
|
|
if err != nil {
|
|
return id, err
|
|
}
|
|
params := url.Values{}
|
|
params.Set("container", nameOrId)
|
|
if options.Author != nil {
|
|
params.Set("author", *options.Author)
|
|
}
|
|
for _, change := range options.Changes {
|
|
params.Set("changes", change)
|
|
}
|
|
if options.Comment != nil {
|
|
params.Set("comment", *options.Comment)
|
|
}
|
|
if options.Format != nil {
|
|
params.Set("format", *options.Format)
|
|
}
|
|
if options.Pause != nil {
|
|
params.Set("pause", strconv.FormatBool(*options.Pause))
|
|
}
|
|
if options.Repo != nil {
|
|
params.Set("repo", *options.Repo)
|
|
}
|
|
if options.Tag != nil {
|
|
params.Set("tag", *options.Tag)
|
|
}
|
|
response, err := conn.DoRequest(nil, http.MethodPost, "/commit", params, nil)
|
|
if err != nil {
|
|
return id, err
|
|
}
|
|
return id, response.Process(&id)
|
|
}
|