mirror of
https://github.com/containers/podman.git
synced 2026-07-09 23:05:00 -04:00
With podman machine, gvproxy forwards published ports by binding them on the host (not inside the VM) and runs unprivileged. macOS refuses to bind a privileged port (< 1024) to a specific IP for a normal user, even though binding all interfaces is fine, so publishing e.g. -p 127.0.0.1:80:80 used to fail with an opaque "something went wrong with the request". Pass the published ip:port into the gvproxy error helper and, when the body says "permission denied" for a < 1024 port on a specific IP, return an error that explains gvproxy binds on the host and suggests dropping the host IP or using a port >= 1024. The raw body is kept for every other case. Add unit tests for the helper. Fixes: #28009 Signed-off-by: Grzegorz Szczepanczyk <g.szczepanczyk@getprintbox.com>
157 lines
5.1 KiB
Go
157 lines
5.1 KiB
Go
//go:build !remote && (linux || freebsd)
|
|
|
|
package libpod
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"io"
|
|
"net"
|
|
"net/http"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/sirupsen/logrus"
|
|
"go.podman.io/common/libnetwork/types"
|
|
"go.podman.io/common/pkg/machine"
|
|
)
|
|
|
|
const machineGvproxyEndpoint = "gateway.containers.internal"
|
|
|
|
// machineExpose is the struct for the gvproxy port forwarding api send via json
|
|
type machineExpose struct {
|
|
// Local is the local address on the vm host, format is ip:port
|
|
Local string `json:"local"`
|
|
// Remote is used to specify the vm ip:port
|
|
Remote string `json:"remote,omitempty"`
|
|
// Protocol to forward, tcp or udp
|
|
Protocol string `json:"protocol"`
|
|
}
|
|
|
|
func requestMachinePorts(expose bool, ports []types.PortMapping) error {
|
|
url := "http://" + machineGvproxyEndpoint + "/services/forwarder/"
|
|
if expose {
|
|
url += "expose"
|
|
} else {
|
|
url += "unexpose"
|
|
}
|
|
ctx := context.Background()
|
|
client := &http.Client{
|
|
Transport: &http.Transport{
|
|
// make sure to not set a proxy here so explicitly ignore the proxy
|
|
// since we want to talk directly to gvproxy
|
|
// https://github.com/containers/podman/issues/13628
|
|
Proxy: nil,
|
|
MaxIdleConns: 50,
|
|
IdleConnTimeout: 30 * time.Second,
|
|
TLSHandshakeTimeout: 10 * time.Second,
|
|
ExpectContinueTimeout: 1 * time.Second,
|
|
},
|
|
}
|
|
buf := new(bytes.Buffer)
|
|
for num, port := range ports {
|
|
protocols := strings.SplitSeq(port.Protocol, ",")
|
|
for protocol := range protocols {
|
|
for i := uint16(0); i < port.Range; i++ {
|
|
machinePort := machineExpose{
|
|
Local: net.JoinHostPort(port.HostIP, strconv.FormatInt(int64(port.HostPort+i), 10)),
|
|
Protocol: protocol,
|
|
}
|
|
if expose {
|
|
// only set the remote port the ip will be automatically be set by gvproxy
|
|
machinePort.Remote = ":" + strconv.FormatInt(int64(port.HostPort+i), 10)
|
|
}
|
|
|
|
// post request
|
|
if err := json.NewEncoder(buf).Encode(machinePort); err != nil {
|
|
if expose {
|
|
// in case of an error make sure to unexpose the other ports
|
|
if cerr := requestMachinePorts(false, ports[:num]); cerr != nil {
|
|
logrus.Errorf("failed to free gvproxy machine ports: %v", cerr)
|
|
}
|
|
}
|
|
return err
|
|
}
|
|
if err := makeMachineRequest(ctx, client, url, buf, machinePort); err != nil {
|
|
if expose {
|
|
// in case of an error make sure to unexpose the other ports
|
|
if cerr := requestMachinePorts(false, ports[:num]); cerr != nil {
|
|
logrus.Errorf("failed to free gvproxy machine ports: %v", cerr)
|
|
}
|
|
}
|
|
return err
|
|
}
|
|
buf.Reset()
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func makeMachineRequest(ctx context.Context, client *http.Client, url string, buf io.Reader, port machineExpose) error {
|
|
req, err := http.NewRequestWithContext(ctx, http.MethodPost, url, buf)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
req.Header.Add("Accept", "application/json")
|
|
req.Header.Add("Content-Type", "application/json")
|
|
resp, err := client.Do(req)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer resp.Body.Close()
|
|
if resp.StatusCode != http.StatusOK {
|
|
return annotateGvproxyResponseError(resp.Body, port)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func annotateGvproxyResponseError(r io.Reader, port machineExpose) error {
|
|
b, err := io.ReadAll(r)
|
|
if err == nil && len(b) > 0 {
|
|
body := string(b)
|
|
// gvproxy runs unprivileged on the host and binds the published port
|
|
// there, not inside the VM. On macOS, binding a privileged port
|
|
// (< 1024) to a specific IP address is rejected for a normal user even
|
|
// though binding to all interfaces is allowed, so give a more
|
|
// actionable error in that case instead of the raw gvproxy message.
|
|
// See https://github.com/containers/podman/issues/28009
|
|
if host, portStr, perr := net.SplitHostPort(port.Local); perr == nil && strings.Contains(body, "permission denied") {
|
|
if p, cerr := strconv.Atoi(portStr); cerr == nil && p < 1024 && !unspecifiedHostIP(host) {
|
|
return fmt.Errorf("cannot bind port %s: %q: with podman machine the published port is bound on the host by gvproxy, which runs unprivileged; macOS does not permit binding a privileged port (< 1024) to a specific IP address as a normal user. Publish the port without a host IP to bind all interfaces, or use a port >= 1024", port.Local, body)
|
|
}
|
|
}
|
|
return fmt.Errorf("something went wrong with the request: %q", body)
|
|
}
|
|
return errors.New("something went wrong with the request, could not read response")
|
|
}
|
|
|
|
// unspecifiedHostIP reports whether the host part of a published port maps to
|
|
// "all interfaces": an empty host or the unspecified address (0.0.0.0 / ::).
|
|
func unspecifiedHostIP(host string) bool {
|
|
if host == "" {
|
|
return true
|
|
}
|
|
ip := net.ParseIP(host)
|
|
return ip != nil && ip.IsUnspecified()
|
|
}
|
|
|
|
// exposeMachinePorts exposes the ports for podman machine via gvproxy
|
|
func (r *Runtime) exposeMachinePorts(ports []types.PortMapping) error {
|
|
if !machine.IsGvProxyBased() {
|
|
return nil
|
|
}
|
|
return requestMachinePorts(true, ports)
|
|
}
|
|
|
|
// unexposeMachinePorts closes the ports for podman machine via gvproxy
|
|
func (r *Runtime) unexposeMachinePorts(ports []types.PortMapping) error {
|
|
if !machine.IsGvProxyBased() {
|
|
return nil
|
|
}
|
|
return requestMachinePorts(false, ports)
|
|
}
|