mirror/python
1
0
Fork 0
mirror of https://github.com/meshtastic/python.git synced 2026-03-03 14:10:01 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor camel and snake naming in setPref

Browse Source 
Same change as done in getPerf to have less branches (simplifies the
code).
This commit is contained in:
Felix Moessbauer
2024-10-25 14:58:04 +02:00
committed by Felix Moessbauer
parent 839bbbcad2
commit 4c29d7dd0f
1 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
meshtastic/__main__.py
View File

@@ -177,6 +177,7 @@ def setPref(config, comp_name, valStr) -> bool:
snake_name = meshtastic.util.camel_to_snake(name[-1]) snake_name = meshtastic.util.camel_to_snake(name[-1])
camel_name = meshtastic.util.snake_to_camel(name[-1]) camel_name = meshtastic.util.snake_to_camel(name[-1])
uni_name = camel_name if mt_config.camel_case else snake_name
logging.debug(f"snake_name:{snake_name}") logging.debug(f"snake_name:{snake_name}")
logging.debug(f"camel_name:{camel_name}") logging.debug(f"camel_name:{camel_name}")
@@ -213,13 +214,8 @@ def setPref(config, comp_name, valStr) -> bool:
if e: if e:
val = e.number val = e.number
else: else:
if mt_config.camel_case:
print( print(
f"{name[0]}.{camel_name} does not have an enum called {val}, so you can not set it." f"{name[0]}.{uni_name} does not have an enum called {val}, so you can not set it."
)
else:
print(
f"{name[0]}.{snake_name} does not have an enum called {val}, so you can not set it."
) )
print(f"Choices in sorted order are:") print(f"Choices in sorted order are:")
names = [] names = []
@@ -255,10 +251,7 @@ def setPref(config, comp_name, valStr) -> bool:
getattr(config_values, pref.name)[:] = cur_vals getattr(config_values, pref.name)[:] = cur_vals
prefix = f"{'.'.join(name[0:-1])}." if config_type.message_type is not None else "" prefix = f"{'.'.join(name[0:-1])}." if config_type.message_type is not None else ""
if mt_config.camel_case: print(f"Set {prefix}{uni_name} to {valStr}")
print(f"Set {prefix}{camel_name} to {valStr}")
else:
print(f"Set {prefix}{snake_name} to {valStr}")
return True return True